stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2024-03-27T16:57:15Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/1348Remove stork-repo tag from .gitlab-ci.yaml2024-03-27T16:57:15ZSlawek FigielRemove stork-repo tag from .gitlab-ci.yamlThe `upload_to_repo` CI task is not working as described [on MM QA channel](https://mattermost.isc.org/isc/pl/eoq3yfamnbfz7n6tfaewdmc6mh).
We got this error:
> This job is stuck because of one of the following problems. There are no ac...The `upload_to_repo` CI task is not working as described [on MM QA channel](https://mattermost.isc.org/isc/pl/eoq3yfamnbfz7n6tfaewdmc6mh).
We got this error:
> This job is stuck because of one of the following problems. There are no active runners online, no runners for the protected branch, or no
runners that match all of the job's tags:
Its tags defined in the .gitlab-ci.yml file are:
- linux
- aws
- runner-manager
- amd64
- stork-repo
I checked the Stork repository settings and it seems there is no runner that matches the requirements.
The `aws` tag is missing in all runners that have the stork-repo tag.
### Proposed solution:
* remove `stork-repo` tag from `upload_to_repo` job in .gitlab-ci.yml.
* remove `-4` (which enforces IPv4 connection) from `ssh-keyscan -4 repo.isc.org >> ~/.ssh/known_hosts`https://gitlab.isc.org/isc-projects/stork/-/issues/1342Agent installation script doesn't work with stork configured for https2024-03-27T10:50:22Zjerry bonnerAgent installation script doesn't work with stork configured for https---
name: Bug report
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. Please use https://www.isc.org/community/report-bug/...---
name: Bug report
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. Please use https://www.isc.org/community/report-bug/ instead or send mail to
security-office(at)isc(dot)org.
**Describe the bug**
Stork 1.15.0 configured with https. Agent installation script from GUI details :
wget https://x.x.x.x:8080/stork-install-agent.sh
However, stork-install-agent.sh is configured to download package via :
curl -o /tmp/isc-stork-agent.deb "x.x.x.x:8080/assets/pkgs/isc-stork-agent_1.15.0.240205220739_amd64.deb"
Note that "https://" is not specified.
Resulting in a downloaded file that contains:
Client sent an HTTP request to an HTTPS server.
**To Reproduce**
Steps to reproduce the behavior:
1. Install Stork 1.15.0 and configure with https
2. Execute provided agent installation from GUI
3. Script fails because isc stork agent package is attempted to be downloaded via http, but stork is configured with https
**Expected behavior**
Stork should code agent installation script to download asset package via https, if STORK_REST_TLS_CERTIFICATE is configured.
**Environment:**
- Stork: 1.15.0
- OS: Ubuntu 20.04https://gitlab.isc.org/isc-projects/stork/-/issues/1337reservations without an IP do not show up in host reservations2024-03-27T18:24:20Zmichael balesreservations without an IP do not show up in host reservations---
name: reservations without an IP do not show up in host reservations
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. ...---
name: reservations without an IP do not show up in host reservations
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. Please use https://www.isc.org/community/report-bug/ instead or send mail to
security-office(at)isc(dot)org.
**Describe the bug**
Stork allows the creation of reservations with just a mac address and client class but the reservation does not show up in the host reservation list.
**To Reproduce**
Steps to reproduce the behavior:
1. Install BIND9, Kea, Stork (which versions?) and run them with the following configs: '...'
2. I do the following: ...
3. A device in my network does the following: ...
4. Kea/BIND9 server does the following: ...
5. Stork does the following: ...
**Expected behavior**
A clear and concise description of what you expected to happen:
The Stork is supposed to report/do A, but didn't or did B instead.
**Environment:**
- Kea version:
2.5.6
isc20240226130228 deb
linked with:
log4cplus 2.0.5
OpenSSL 3.0.2 15 Mar 2022
database:
MySQL backend 21.0, library 8.0.36
PostgreSQL backend 20.0, library 140011
Memfile backend 3.0
- Stork: 1.15.0
- OS: Ubuntu 22.04.4 LTS x86_64
- Kea: "hooks-libraries": [
{
"library": "/usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_stat_cmds.so"
},
{
"library": "/usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_lease_cmds.so"
},
{
"library": "/usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_pgsql_cb.so"
},
{
"library": "/usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_host_cmds.so"
}
**Additional Information**
logs from adding the reservation:
```
082 17:40:10.417 kea-dhcp4.commands COMMAND_SOCKET_CONNECTION_OPENED Opened socket 37 for incoming command connection
082 17:40:10.417 kea-dhcp4.commands COMMAND_SOCKET_READ Received 212 bytes over command socket 37
082 17:40:10.418 kea-dhcp4.commands COMMAND_RECEIVED Received command 'reservation-add'
082 17:40:10.418 kea-dhcp4.callouts HOOKS_CALLOUTS_BEGIN begin all callouts for hook $reservation_add
082 17:40:10.418 kea-dhcp4.host-cmds-hooks HOST_CMDS_RESERV_ADD reservation-add command called (parameters: { "reservation": { "client-classes": [ "known-clients-106" ], "hw-address": "C03EBA93B18D", "subnet-id": 3 } })
082 17:40:10.418 kea-dhcp4.database DATABASE_PGSQL_START_TRANSACTION starting a new PostgreSQL transaction
082 17:40:10.422 kea-dhcp4.database DATABASE_PGSQL_COMMIT committing to PostgreSQL database
082 17:40:10.423 kea-dhcp4.host-cmds-hooks HOST_CMDS_RESERV_ADD_SUCCESS reservation-add command success (parameters: { "reservation": { "client-classes": [ "known-clients-106" ], "hw-address": "C03EBA93B18D", "subnet-id": 3 } })
082 17:40:10.423 kea-dhcp4.callouts HOOKS_CALLOUT_CALLED hooks library with index 4 has called a callout on hook $reservation_add that has address 0x7ff4efd4e900 (callout duration: 5.567 ms)
082 17:40:10.423 kea-dhcp4.callouts HOOKS_CALLOUTS_COMPLETE completed callouts for hook $reservation_add (total callouts duration: 5.567 ms)
082 17:40:10.423 kea-dhcp4.commands COMMAND_SOCKET_WRITE Sent response of 38 bytes (0 bytes left to send) over command socket 37
082 17:40:10.423 kea-dhcp4.commands COMMAND_SOCKET_CONNECTION_CLOSED Closed socket 37 for existing command connection
```
after the reservation is added the reservation list in stork does not show the mac address or hostname
**Describe the solution you'd like*
Reservations without an assigned IP address should show the hostname and mac address in the reservation list.
**Additional context**
We use small DHCP pools of 20 or so addresses so handle mobile devices that are occasionally connected to the network. We managed this with isc-dhcpd previously by using global reservations with just a mac address. It looks like in isc-kea a mac address and a resource are required and my understanding is that a client class counts as a resource so the reservation should be valid. Instead of global reservations we are now using per subnet reservations.
**Funding its development**
Kea is run by ISC, which is a small non-profit organization without any government funding or any
permanent sponsorship organizations. Are you able and willing to participate financially in the
development costs?
Yes this is a possibility
**Participating in development**
Are you willing to participate in the feature development? ISC team always tries to make a feature
as generic as possible, so it can be used in wide variety of situations. That means the proposed
solution may be a bit different that you initially thought. Are you willing to take part in the
design discussions? Are you willing to test an unreleased engineering code?
Yes i am willing to participate in development.
**Contacting you**
How can ISC reach you to discuss this matter further? If you do not specify any means such as
e-mail, jabber id or a telephone, we may send you a message on github with questions when we have
them.1.17https://gitlab.isc.org/isc-projects/stork/-/issues/1333Incorrect error handing of the bind9 app state causes no transition to the in...2024-03-14T12:23:22ZMarcin SiodelskiIncorrect error handing of the bind9 app state causes no transition to the inactive stateThe `GetAppState()` logic returns early when communication with named fails. As a result, the info about the app is not updated in the database. So, for example, the active flag remains true, while it should be put to false. The daemon a...The `GetAppState()` logic returns early when communication with named fails. As a result, the info about the app is not updated in the database. So, for example, the active flag remains true, while it should be put to false. The daemon appears to be online in the UI even though there is no connection to it.https://gitlab.isc.org/isc-projects/stork/-/issues/1320Duplicated rows in the service table2024-02-28T16:28:53ZSlawek FigielDuplicated rows in the service tableThe problem was reported [on the Stork-users mailing list](https://lists.isc.org/pipermail/stork-users/2024-February/000245.html).
The `service` table rows may be duplicated on some unknown conditions. It causes the HA status displayed ...The problem was reported [on the Stork-users mailing list](https://lists.isc.org/pipermail/stork-users/2024-February/000245.html).
The `service` table rows may be duplicated on some unknown conditions. It causes the HA status displayed on the Dashboard to diverge from the status presented on the application page.
The user reports that the problem occurs in Stork 1.15 but was also observed in the previous versions. The first installed version was 1.12.
Stork was installed long after configuring HA in Kea.
It seems the same problem was reported in #616 and #818.
We should check if the problem were fixed correctly in 1.7 and if the invalid table state may preserved from the previous versions.
We should also analyze if adding the unique constraint on the `service` table would be beneficial to avoid similar issues.1.16Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1313Incorrect default *.env file.2024-02-27T09:52:35ZAndreas JentschIncorrect default *.env file.---
name: Bug report
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. Please use https://www.isc.org/community/report-bug/...---
name: Bug report
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. Please use https://www.isc.org/community/report-bug/ instead or send mail to
security-office(at)isc(dot)org.
**Describe the bug**
If you start the agent with the following command, this output is generated.
/usr/bin/stork-agent --use-env-file
FATA[2024-02-08 10:39:55] main.go:406 invalid environment file: '/etc/stork/server.env': ...
**To Reproduce**
Steps to reproduce the behavior:
1. /usr/bin/stork-agent --env-file '/etc/stork/agent.env' --use-env-file
**Expected behavior**
You should adjust the default value for the .*env file.
**Environment:**
/usr/bin/stork-agent -v
1.15.0
Static hostname: dhcp-01-xgs.glattnet.ch
Icon name: computer-server
Chassis: server 🖳
Machine ID: cf6ef911a0974dbfa031e35e8f775125
Boot ID: 96edd982af2d4745a030003205e7fae2
Operating System: Rocky Linux 9.3 (Blue Onyx)
CPE OS Name: cpe:/o:rocky:rocky:9::baseos
Kernel: Linux 5.14.0-362.18.1.el9_3.x86_64
Architecture: x86-64
Hardware Vendor: HPE
Hardware Model: ProLiant DL360 Gen10
Firmware Version: U32
- Kea version: 2.2.0
tarball
linked with:
log4cplus 2.0.5
OpenSSL 3.0.7 1 Nov 2022
database:
MySQL backend 14.0, library 3.2.6
PostgreSQL backend 13.0, library 130013
Memfile backend 2.1
- Stork: 1.15.0
- OS: Rocky Linux 9.3 (Blue Onyx)
- Kea: Which features were compiled in (in particular which backends)
- Kea: If/which hooks where loaded in
**Contacting you**
E-Mail1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1311After PrimeNG update some buttons behave differently2024-03-26T14:48:07ZPiotrek ZadrogaAfter PrimeNG update some buttons behave differentlyFor example, Machines list view - Authorized and Unauthorized buttons work like toggles now. 2 consecutive clicks on Unauthorized toggles active/non-active state of the button, and the list itself shows different data.
![image](/uploads...For example, Machines list view - Authorized and Unauthorized buttons work like toggles now. 2 consecutive clicks on Unauthorized toggles active/non-active state of the button, and the list itself shows different data.
![image](/uploads/19aefedb53d49f7863cd891a01f5631c/image.png)
![image](/uploads/109a5db2e701ab2e044ef08c6b6ca0f8/image.png)1.17https://gitlab.isc.org/isc-projects/stork/-/issues/1307Missing empty placeholder in some tables2024-03-28T15:28:30ZSlawek FigielMissing empty placeholder in some tablesThe issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434139
Some tables don't display feedback about empty data set:
![image](https://gitlab.isc.org/isc-projects/stork/...The issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434139
Some tables don't display feedback about empty data set:
![image](https://gitlab.isc.org/isc-projects/stork/uploads/497ba0f438fff4d1587a392bfe251491/image.png)
Also Total# of subnets is not 0, but nothing is displayed.1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1306Reset subnet pagination on filter2024-03-05T14:32:02ZSlawek FigielReset subnet pagination on filterThe issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434138
Pagination not reset when filtering Subnets by Kea app: ![image](https://gitlab.isc.org/isc-projects/stork/up...The issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434138
Pagination not reset when filtering Subnets by Kea app: ![image](https://gitlab.isc.org/isc-projects/stork/uploads/d75cedb560b9c06590aa8c95ccd96d23/image.png)1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1304Host reservation list - Reset or re-apply the filter2024-03-05T14:30:07ZSlawek FigielHost reservation list - Reset or re-apply the filterThe issue was found during 1.15 sanity checks by @piotrek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434121 and @slawek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434179
Piotrek wrote:
Yet another ...The issue was found during 1.15 sanity checks by @piotrek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434121 and @slawek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434179
Piotrek wrote:
Yet another issue found in filtered tables. This applies to all tables that use `queryParams` to keep the filter state and use `TabView` / `TabPanel` (most of tables use it).
E.g. for hosts:
* go to any Kea app
* Host Reservations -> button click
* We have filtered hosts only for that Kea app
* Click on a reservation
* Detailed view opens in tab
* Click on Host Reservations tab to go back to Table view
* We see all Host Reservations (filtering by Kea app is cleared). Text input of the filter displays remaining filter by Kea `appId`.
Slawek wrote:
Clicking the first tab on the host page lists all results but keeps the old filter.
Steps to reproduce:
1. Go to the host reservation list
1. Provide any valid value in the filter box
1. Click the first tab titled "Host Reservations"
1. Observe the table contains all host reservations, but the filter box is not empty1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1301Length of input for lease6-get-by-duid is not validated2024-03-28T12:24:48ZSlawek FigielLength of input for lease6-get-by-duid is not validatedThe issue was found by @andrei during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434113
Searching leases by two-character or four-character words provide warnings.
![image](https://gitlab.isc.org/i...The issue was found by @andrei during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434113
Searching leases by two-character or four-character words provide warnings.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/084c42bee2b770bbb47bad0d3e83212d/image.png)
This is caused by an error response e.g. `[ { "result": 1, "text": "identifier is too short (2), at least 3 is required" } ]` to the `lease6-get-by-duid` command. This could be avoided by having Stork check this requirement up front and prevent the command from being sent, as it does with other input. As the comment in `lease.go` says
> // Kea does not accept empty DUIDs. Empty DUID in Kea is represented by 1 zero byte (Kea < 2.3.8) or 3 zero bytes (Kea >= 2.3.8).\`
The current situation can be confusing to a user trying to determine why an even number of characters and bytes is more problematic than an odd number of characters which is checked upfront by Stork.1.16Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1294Menubar bugs after PrimeNG update2024-02-13T14:40:45ZSlawek FigielMenubar bugs after PrimeNG update[Original source](https://gitlab.isc.org/isc-projects/stork/-/merge_requests/712#note_433295)
Buttons on the top bar
* On hover
* On master, the dropdown is not expanded.
* ![image](https://gitlab.isc.org/isc-projects/stork/uploa...[Original source](https://gitlab.isc.org/isc-projects/stork/-/merge_requests/712#note_433295)
Buttons on the top bar
* On hover
* On master, the dropdown is not expanded.
* ![image](https://gitlab.isc.org/isc-projects/stork/uploads/4af3ff65063b39f15a25b7654b20828c/image.png)
* On this branch, the dropdown is expanded.
* ![image](https://gitlab.isc.org/isc-projects/stork/uploads/45bc7214bf46f737c6c37a714c0ac4fa/image.png)
* On unhover
* On master, it returns to the initial state.
* ![image](https://gitlab.isc.org/isc-projects/stork/uploads/d084acfb2bb1b9934e562beb4389fd1f/image.png)
* On this branch, the dropdown remains expanded.
* ![image](https://gitlab.isc.org/isc-projects/stork/uploads/1891a06b3bd24907247771ba866b11a8/image.png)
Andrei likes the on-hover change. He doesn't like the on-unhover change.
It is a bug in [the PrimeNG 17.4.0 internals](https://github.com/primefaces/primeng/issues/13512). I didn't find the workaround.outstandinghttps://gitlab.isc.org/isc-projects/stork/-/issues/1287Deadlock during removing a machine2024-01-31T18:51:40ZSlawek FigielDeadlock during removing a machineThe database deadlock may occur if the machine is deleted during the config review.
```
problem deleting machine 1: ERROR #40P01 deadlock detected" file="machines.go:688"
```
It causes the `test_delete_machine_with_config_reports` syst...The database deadlock may occur if the machine is deleted during the config review.
```
problem deleting machine 1: ERROR #40P01 deadlock detected" file="machines.go:688"
```
It causes the `test_delete_machine_with_config_reports` system test to fail often.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1275Password change fails with character '+' that form states is allowable2024-01-16T14:41:07ZBaxil (aka Horizon)Password change fails with character '+' that form states is allowable
**Description**
Stork will refuse to validate passwords using the plus sign, one of the characters the password change screen explicitly states is an allowed special character.
**To Reproduce**
1. visit /profile/password page for passw...
**Description**
Stork will refuse to validate passwords using the plus sign, one of the characters the password change screen explicitly states is an allowed special character.
**To Reproduce**
1. visit /profile/password page for password change
2. In both password and confirm password boxes type: abc+123
3. Password box will error out with an allowed characters message and confirm box will error out stating passwords don't match
![20240109-stork-passwords](/uploads/76d84e097f9c19cc31850f9bc204c36e/20240109-stork-passwords.png)
**Expected behavior**
Any characters which cause password processing errors should be removed from acceptable character lists.
**Environment:**
- Stork: 1.14.0
- OS: unknown, my apologies (I'm an end user)
- Kea version: unknown
- BIND9 version: unknown
**Additional Information**
This is possibly related to issue #1246 if the db password is processed in the same fashion.1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1265Hosts reservations filter improvements2024-03-27T14:12:45ZPiotrek ZadrogaHosts reservations filter improvementsText Input type filter used currently in Hosts reservations view has some limitations and drawbacks (https://gitlab.isc.org/isc-projects/stork/-/issues/917#note_423973).
E.g. it is not possible to filter out all reservations in 2 subnet...Text Input type filter used currently in Hosts reservations view has some limitations and drawbacks (https://gitlab.isc.org/isc-projects/stork/-/issues/917#note_423973).
E.g. it is not possible to filter out all reservations in 2 subnets.
This could be improved by leaving existing Text Input only for filtering `byText` and introducing something different for filtering by `appId`, `subnetId`, `keaSubnetId`, `global`. This could be e.g. `multiselect` (https://primeng.org/multiselect).1.16Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/1261The list tab link doesn't include the already specified filter2024-03-13T18:41:07ZSlawek FigielThe list tab link doesn't include the already specified filterThe list tab link doesn't include the already specified filter.
![image](/uploads/975779709fab2fb25c2959373d7d2081/image.png)
After clicking on it, the list presents non-filtered results, although the filter is still specified.
![imag...The list tab link doesn't include the already specified filter.
![image](/uploads/975779709fab2fb25c2959373d7d2081/image.png)
After clicking on it, the list presents non-filtered results, although the filter is still specified.
![image](/uploads/946de8fa616032c96e97f1157e526afa/image.png)1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1251LDAP hook: Build fails on some Linux distributions2023-12-19T14:47:34ZSlawek FigielLDAP hook: Build fails on some Linux distributionsThe issue was found by @andrei during 1.14 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421471
```
Another one I had forgotten. I understand that this one as well is not a task that you usually run on a ta...The issue was found by @andrei during 1.14 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421471
```
Another one I had forgotten. I understand that this one as well is not a task that you usually run on a tarball.
rake hook:init MODULE=stork-server-ldap; rake hook:build results in error when run on a tarball. It seems like it is not picking up on DEFAULT_HOOK_DIRECTORY.
rm -f
Removing old compiled hooks...
cp go.mod go.sum /tmp/d20231205-1147463-kn7j49
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/tools/golang/go/bin/go mod edit -replace isc.org/stork=../../../../../Descărcări/sanity-checks/stork-1.14.0/backend
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/tools/golang/go/bin/go mod tidy
rake build
Building stork-server-ldap...
mkdir -p build
rm
rm: missing operand
Try 'rm --help' for more information.
rake aborted!
Command failed with status (1): [rm...]
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/hooks/stork-server-ldap/Rakefile:17:in `block in <top (required)>'
Tasks: TOP => build
(See full trace by running task with --trace)
rake aborted!
Command failed with status (1): [rake build...]
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:150:in `block (4 levels) in <top (required)>'
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:141:in `block (3 levels) in <top (required)>'
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:66:in `block (3 levels) in forEachHook'
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:65:in `chdir'
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:65:in `block (2 levels) in forEachHook'
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:46:in `chdir'
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:46:in `block in forEachHook'
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:42:in `foreach'
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:42:in `forEachHook'
/home/andrei/Descărcări/sanity-checks/stork-1.14.0/rakelib/90_hooks.rake:139:in `block (2 levels) in <top (required)>'
Tasks: TOP => hook:build
(See full trace by running task with --trace)
```1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1249Problem installing danger on operating system with non-US locale2023-12-19T14:42:10ZSlawek FigielProblem installing danger on operating system with non-US localeThe issue was found by @andrei during 1.14 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421412
* I could not run system tests. I get this error on `rake systemtest`. Not sure what is wrong. Sounds like an ...The issue was found by @andrei during 1.14 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421412
* I could not run system tests. I get this error on `rake systemtest`. Not sure what is wrong. Sounds like an encoding could be enforced somewhere.
```
143.7 Bundler version 2.3.26
143.7 /app/tools/ruby/bin/bundle install --gemfile /app/rakelib/init_deps/danger/Gemfile --path /app/tools/ruby --binstubs /app/tools/ruby/bin_bundle
143.7 Preparing: /app/tools/ruby/bin_bundle/danger...
143.7 mkdir -p /app/tools/ruby/bin_bundle
143.9 /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/yaml_serializer.rb:54:in `split': invalid byte sequence in US-ASCII (ArgumentError)
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/yaml_serializer.rb:54:in `load'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/settings.rb:459:in `block in load_config'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/shared_helpers.rb:103:in `filesystem_access'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/settings.rb:455:in `load_config'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/settings.rb:91:in `initialize'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler.rb:342:in `new'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler.rb:342:in `settings'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/env.rb:20:in `report'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/friendly_errors.rb:74:in `request_issue_report_for'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/friendly_errors.rb:53:in `log_error'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/friendly_errors.rb:126:in `rescue in with_friendly_errors'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/friendly_errors.rb:118:in `with_friendly_errors'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/exe/bundle:36:in `<top (required)>'
143.9 from /app/tools/ruby/bin/bundle:25:in `load'
143.9 from /app/tools/ruby/bin/bundle:25:in `<main>'
143.9 /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/yaml_serializer.rb:54:in `split': invalid byte sequence in US-ASCII (ArgumentError)
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/yaml_serializer.rb:54:in `load'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/settings.rb:459:in `block in load_config'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/shared_helpers.rb:103:in `filesystem_access'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/settings.rb:455:in `load_config'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/settings.rb:91:in `initialize'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler.rb:342:in `new'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler.rb:342:in `settings'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/cli.rb:66:in `initialize'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor.rb:388:in `new'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor.rb:388:in `dispatch'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/cli.rb:31:in `dispatch'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/cli.rb:25:in `start'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/exe/bundle:48:in `block in <top (required)>'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/lib/bundler/friendly_errors.rb:120:in `with_friendly_errors'
143.9 from /app/tools/ruby/gems/bundler-2.3.26/exe/bundle:36:in `<top (required)>'
143.9 from /app/tools/ruby/bin/bundle:25:in `load'
143.9 from /app/tools/ruby/bin/bundle:25:in `<main>'
143.9 rake aborted!
143.9 Command failed with status (1): [/app/tools/ruby/bin/bundle install --gemfi...]
143.9 /app/rakelib/00_init.rake:795:in `block in <top (required)>'
143.9 /app/rakelib/00_init.rake:133:in `block in find_and_prepare_deps'
143.9 /app/rakelib/00_init.rake:115:in `each'
143.9 /app/rakelib/00_init.rake:115:in `find_and_prepare_deps'
143.9 /app/rakelib/00_init.rake:1113:in `block in <top (required)>'
143.9 Tasks: TOP => /app/tools/ruby/bin_bundle/danger
143.9 (See full trace by running task with --trace)
```backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1247DB password prompt hangs out on Ctrl-C2023-12-19T14:40:48ZSlawek FigielDB password prompt hangs out on Ctrl-CThe issue was found by @piotrek during [1.14 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421388).
Other thing observed is, interrupting `rake` task with `Ctrl+C` when it asks for some password, breaks the...The issue was found by @piotrek during [1.14 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421388).
Other thing observed is, interrupting `rake` task with `Ctrl+C` when it asks for some password, breaks the terminal behavior afterwards. Terminal still waits for password and you can't type nor use the terminal in a normal way. This is not the case when you use e.g. `psql` and use `Ctrl+C` when it asks for password. You get back to normal operation of your terminal afterwards, which is expected.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1246DB password prompt doesn't handle special characters properly2024-01-16T13:32:04ZSlawek FigielDB password prompt doesn't handle special characters properlyThe issue was found by @piotrek during [1.14 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421388).
I'm using password with special characters both for my `postgres` user and db user. When calling:
```shel...The issue was found by @piotrek during [1.14 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421388).
I'm using password with special characters both for my `postgres` user and db user. When calling:
```shell
$ rake unittest:backend
```
password is given but it looks like `rake` task doesn't escape special characters correctly, and the task fails.
Exporting env var e.g. `$ export DB_MAINTENANCE_PASSWORD='***'` and then calling the task helps.
I'm using `GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)` as a shell.1.16