stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2019-12-27T17:30:26Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/29CI: pre-commit git hook2019-12-27T17:30:26ZTomek MrugalskiCI: pre-commit git hookWe need a hook that will put the [#issue number] in the commit message automatically. @fdupont may have such a script already.We need a hook that will put the [#issue number] in the commit message automatically. @fdupont may have such a script already.Stork-0.3Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/127Rename app-kea-daemons-tabs2020-02-04T13:00:12ZMatthijs Mekkingmatthijs@isc.orgRename app-kea-daemons-tabsIn webui: app-kea-daemons-tabs should be renamed to app-kea-app-tabIn webui: app-kea-daemons-tabs should be renamed to app-kea-app-tabStork-0.4https://gitlab.isc.org/isc-projects/stork/-/issues/181Replace int64 conversion to EqualValues in tests2020-03-13T17:17:26ZMatthijs Mekkingmatthijs@isc.orgReplace int64 conversion to EqualValues in tests0.6Matthijs Mekkingmatthijs@isc.orgMatthijs Mekkingmatthijs@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/171UI tweak: pagination/total entries layout should be unified2020-04-20T09:44:05ZTomek MrugalskiUI tweak: pagination/total entries layout should be unifiedA minor UI usability improvement.
When viewing Kea services, BIND services or Machines, the bar with X of Y pages/show Z per page line is above the content. The subnets and networks views has it below the content. This should be unified...A minor UI usability improvement.
When viewing Kea services, BIND services or Machines, the bar with X of Y pages/show Z per page line is above the content. The subnets and networks views has it below the content. This should be unified.
I think the standard is to keep it at the bottom.0.7Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/236typos and other minor tweaks2020-05-06T09:13:14ZTomek Mrugalskitypos and other minor tweaks1. go to machines page, click Add new machine. there's a typo: describer => described
2. in the readme.md there are some screenshots that are from master, but the text earlier says version 0.6.0. We need to clarify that those features (d...1. go to machines page, click Add new machine. there's a typo: describer => described
2. in the readme.md there are some screenshots that are from master, but the text earlier says version 0.6.0. We need to clarify that those features (dashboard, HA status) will be in 0.7.0.0.7Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/202man pages for agent/server must be updated2020-08-12T16:43:39ZTomek Mrugalskiman pages for agent/server must be updated* [x] agent man page does not list STORK_AGENT_PROMETHEUS_* variables.
* [x] server man page does not list any variables at all. A good list is in agent.env and server.env.
* [x] some agent switches are not documented (done in #265)
* [...* [x] agent man page does not list STORK_AGENT_PROMETHEUS_* variables.
* [x] server man page does not list any variables at all. A good list is in agent.env and server.env.
* [x] some agent switches are not documented (done in #265)
* [x] some server switches are not documented (done in #265)0.10Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/112Improve UI tables2020-08-12T10:49:24ZMatthijs Mekkingmatthijs@isc.orgImprove UI tablesFrom https://gitlab.isc.org/isc-projects/stork/merge_requests/41:
- There is missing unit of memory ie. GB
- Rename "address" column on Machines page to "location"
- CPUs Load is not intuitive, add explanation in hovering mouse text
- U...From https://gitlab.isc.org/isc-projects/stork/merge_requests/41:
- There is missing unit of memory ie. GB
- Rename "address" column on Machines page to "location"
- CPUs Load is not intuitive, add explanation in hovering mouse text
- Used column is not intuitive, rename to "Memory usage"0.10Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/365not monitored services should not be shown in the dashboard2020-09-02T15:49:56ZTomek Mrugalskinot monitored services should not be shown in the dashboardThe services that are not monitored (e.g. dhcpv6 on agent-kea) are still shown on a dashboard. They shouldn't be.
![Screenshot_2020-08-11_at_11.40.23](/uploads/762c86ee31b69c60a31ce25e3fff9c87/Screenshot_2020-08-11_at_11.40.23.png)The services that are not monitored (e.g. dhcpv6 on agent-kea) are still shown on a dashboard. They shouldn't be.
![Screenshot_2020-08-11_at_11.40.23](/uploads/762c86ee31b69c60a31ce25e3fff9c87/Screenshot_2020-08-11_at_11.40.23.png)0.11Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/366Debug/verbose mode to db migration2021-03-05T13:12:51ZTomek MrugalskiDebug/verbose mode to db migrationOur DB schema is not documented anywhere and it's stored in .go files. There was one incident when migration failed and it was difficult to debug what exactly was going on. We need a `--debug` or `--verbose` flag that would print each DB...Our DB schema is not documented anywhere and it's stored in .go files. There was one incident when migration failed and it was difficult to debug what exactly was going on. We need a `--debug` or `--verbose` flag that would print each DB migration schema before it's actually applied.0.12Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/431doc updates: prerequisite section2020-10-27T15:59:41ZTomek Mrugalskidoc updates: prerequisite sectionAs reported here https://gitlab.isc.org/isc-projects/stork/-/issues/426#note_169318 by @marcin:
Prerequisites section of the Stork ARM is outdated. A couple of examples:
```
Stork Server and Stork Agent have been tested thoroughly on t...As reported here https://gitlab.isc.org/isc-projects/stork/-/issues/426#note_169318 by @marcin:
Prerequisites section of the Stork ARM is outdated. A couple of examples:
```
Stork Server and Stork Agent have been tested thoroughly on the Ubuntu 18.04 system. They have been tested and run on the Fedora 31 system as well.
```
So we fixed list of systems in one place but left this. I think we generally have too many places where we list systems on which it has been tested.
Another place:
```
The status-get command was introduced in Kea 1.7.3. At this time, Stork works with Kea version 1.7.3 and later versions only, although we intend to backport the status-get command to Kea 1.6.3.
```
In fact, we have already back ported it to 1.6.3.0.13Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/497spellcheck2021-05-02T19:58:38ZAndrei Pavelandrei@isc.orgspellcheck0.15Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/430UI tooltips misaligned2021-01-28T10:43:36ZTomek MrugalskiUI tooltips misalignedAs reported here https://gitlab.isc.org/isc-projects/stork/-/issues/426#note_169320 by @godfryd:
![image](/uploads/6ba0d52a3875a0d8261d90788910060b/image.png)
Help box text is centered instead of aligned to the left.
This is probably d...As reported here https://gitlab.isc.org/isc-projects/stork/-/issues/426#note_169320 by @godfryd:
![image](/uploads/6ba0d52a3875a0d8261d90788910060b/image.png)
Help box text is centered instead of aligned to the left.
This is probably due to the fact that question mark icon is located in the table header which is also centered. The problem applies to other boxes that have its question mark icon in table headers.0.15https://gitlab.isc.org/isc-projects/stork/-/issues/656Stork Tool is wrong described as optional in the doc.2022-01-27T15:52:37ZSlawek FigielStork Tool is wrong described as optional in the doc.The issue was found during sanity checks for the 1.0 release.
Source: https://gitlab.isc.org/isc-projects/stork/-/issues/645#note_253014
In the Stork Tool section of our ARM we have this text: "To initialize the database directly, the ...The issue was found during sanity checks for the 1.0 release.
Source: https://gitlab.isc.org/isc-projects/stork/-/issues/645#note_253014
In the Stork Tool section of our ARM we have this text: "To initialize the database directly, the Stork Tool must be built and used to initialize and upgrade the database to the latest schema. However, this is optional, as the database migration is triggered automatically upon server startup."
In fact, the `rake install_server` builds and installs the tool. So, there is no optionality.1.1Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/654PrimeNG errors during UI unit tests2022-02-08T12:57:21ZSlawek FigielPrimeNG errors during UI unit testsThe issue was found during sanity checks for the 1.0 release.
Source: https://gitlab.isc.org/isc-projects/stork/-/issues/645#note_253008
While running `rake ng_test` I got this error in between some tests:
`TypeError: Cannot read prop...The issue was found during sanity checks for the 1.0 release.
Source: https://gitlab.isc.org/isc-projects/stork/-/issues/645#note_253008
While running `rake ng_test` I got this error in between some tests:
`TypeError: Cannot read properties of undefined (reading 'offsetHeight')`1.2Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/437failed unit-tests due to missing dependency2022-05-11T09:37:48ZTomek Mrugalskifailed unit-tests due to missing dependencyTried running `rake unittest_backend` on my fresh Ubuntu 20.04. They failed with this:
```
rm -f backend/server/agentcomm/api_mock.go
for db in $(psql -t -h localhost -p 5432 -U storktest -c "select datname from pg_database wher...Tried running `rake unittest_backend` on my fresh Ubuntu 20.04. They failed with this:
```
rm -f backend/server/agentcomm/api_mock.go
for db in $(psql -t -h localhost -p 5432 -U storktest -c "select datname from pg_database where datname ~ 'storktest.*'"); do
dropdb -h localhost -p 5432 -U storktest $db
done
sh: 2: psql: not found
createdb -h localhost -p 5432 -U storktest -O storktest storktest
rake aborted!
Command failed with status (127): [createdb -h localhost -p 5432 -U storktest...]
/home/thomson/devel/stork/Rakefile:405:in `block in <top (required)>'
/usr/share/rubygems-integration/all/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
Tasks: TOP => unittest_backend
(See full trace by running task with --trace)
```
We should either make a check if psql is available (maybe make an array of tools we require in the system)?1.3https://gitlab.isc.org/isc-projects/stork/-/issues/722Stork server/agent log setting.2022-05-30T17:49:10ZSina HosseiniStork server/agent log setting.Hello, I have some troubles with the Stork server & agent logging mechanism.
There is just no way to configure how these two handle their logs, by default they send their logs to `/var/log/syslog` but the problem is on top of not being ...Hello, I have some troubles with the Stork server & agent logging mechanism.
There is just no way to configure how these two handle their logs, by default they send their logs to `/var/log/syslog` but the problem is on top of not being able to disable it, there are ANSI color codes in the log messages ( which I have no idea how they're getting logged in the first place ) and that is causing issues for my log management.
Sample:
```bash
#011/tmp/build/tools/1.17.5/go/src/runtime/asm_amd64.s:1581
#033[31mERRO#033[0m[2022-04-03 14:00:31] periodicexecutor.go:169 errors were encountered while pulling data from apps: missing Arguments from Lease Stats response {ResponseHeader:{Result:2 Text:'stat-lease6-get' command not supported. Daemon:dhcp6} Arguments:<nil>}
#033[36mINFO#033[0m[2022-04-03 14:00:31] statspuller.go:69 completed pulling lease stats from Kea apps: 0/1 succeeded
```
I found out that these logs are correctly formatted when using the `journalctl` command, however, the ANSI color codes exist in the `/var/log/syslog` and since my log management is gathering all logs through `syslog` the ANSI color codes are proving problematic.
Please address this issue, any help regarding how to drop these codes, fix them, or any workaround is appreciated.
Many thanks in advance.1.4Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/142UI improvement: hooks should display name only2022-11-21T14:30:58ZTomek MrugalskiUI improvement: hooks should display name onlyWe're now able to display a list of hooks. The UI for this should be improved:
- the UI should display the hooks name, not the full path kea (libdhcp_stat_cmds, not /usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_stat_cmds.so). the full pat...We're now able to display a list of hooks. The UI for this should be improved:
- the UI should display the hooks name, not the full path kea (libdhcp_stat_cmds, not /usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_stat_cmds.so). the full path could possibly be displayed when you hover cursor over it.
- the name itself could be a link to appropriate section of kea.readthedocs.io (or small [doc] link added after it).1.8Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/1004User with no groups is not allowed to log out.2023-03-30T10:25:00ZSlawek FigielUser with no groups is not allowed to log out.Steps to reproduce:
1. Create a user with no groups
2. Log-in
3. Try to log-outSteps to reproduce:
1. Create a user with no groups
2. Log-in
3. Try to log-out1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/987CodeQL: Uncontrolled data used in path expression2023-03-30T16:43:00ZSlawek FigielCodeQL: Uncontrolled data used in path expressionWe use the URL path to construct the location of the static file to serve.
If we don't sanitize this path, the attacker may traverse over directories (e.g., by providing the `../../` prefix) to read filesystem files.
The vurnerability is...We use the URL path to construct the location of the static file to serve.
If we don't sanitize this path, the attacker may traverse over directories (e.g., by providing the `../../` prefix) to read filesystem files.
The vurnerability is available for unprivileged users.
[Source](https://github.com/isc-projects/stork/security/code-scanning/119)1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/971The log level inside the dump package should be human-readable2023-03-23T14:23:07ZSlawek FigielThe log level inside the dump package should be human-readableThe issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348492).
![image](https://gitlab.isc.org/isc-projects/stork/uploads/93658e2adc9e86cbade94679bedbedee/image....The issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348492).
![image](https://gitlab.isc.org/isc-projects/stork/uploads/93658e2adc9e86cbade94679bedbedee/image.png)
The log level inside the dump package should be human-readable.1.10Slawek FigielSlawek Figiel