stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2024-01-31T11:44:39Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/994CodeQL: Unused variable, import, function or class in UI2024-01-31T11:44:39ZSlawek FigielCodeQL: Unused variable, import, function or class in UISome imports in many UI files are not used. We should enable a linter to detect similar issues.
This affects many (81 last time we checked) issues reported on github.Some imports in many UI files are not used. We should enable a linter to detect similar issues.
This affects many (81 last time we checked) issues reported on github.1.15Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/1280Minor doc update: server limitations update after ping-check2024-01-15T12:31:16ZTomek MrugalskiMinor doc update: server limitations update after ping-checkThe section 8.12 (DHCPv4 server limitations) still claims this:
> _The DHCPv4 server does not verify that an assigned address is unused. According to RFC 2131, the allocating server should verify that an address is not used by sending a...The section 8.12 (DHCPv4 server limitations) still claims this:
> _The DHCPv4 server does not verify that an assigned address is unused. According to RFC 2131, the allocating server should verify that an address is not used by sending an ICMP echo request._
This is no longer true after ping-check was implemented.https://gitlab.isc.org/isc-projects/stork/-/issues/1260Long IPv6 address overlaps the reservation status2024-01-03T14:03:25ZSlawek FigielLong IPv6 address overlaps the reservation statusThe long IPv6 address overlaps the reservation status on the host reservation page.
![image](/uploads/53dfcad412a5fa954c4d5a851069c506/image.png)The long IPv6 address overlaps the reservation status on the host reservation page.
![image](/uploads/53dfcad412a5fa954c4d5a851069c506/image.png)1.15Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/776Avoid using long numbers for IPv6 statistics2023-10-09T14:08:40ZSlawek FigielAvoid using long numbers for IPv6 statisticsThe issue was found during 1.4 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/771#note_289567)
Counting the IPv6 addresses is intimidating task. Instead of printing awfully long number of digits, we could try...The issue was found during 1.4 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/771#note_289567)
Counting the IPv6 addresses is intimidating task. Instead of printing awfully long number of digits, we could try to say something like "5 /16 prefixes". I think this could be done with the tooltip. Although I admit that it may get very messy very quickly if you mix subnets with different lengths...
This particular screenshot taken on the shared networks page, but this problem appears in many places.
![counting-v6](https://gitlab.isc.org/isc-projects/stork/uploads/a2098d549399833b79a953c97790383d/counting-v6.png)backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/973Excessive errors when certs are inaccessible2023-08-02T09:32:55ZTomek MrugalskiExcessive errors when certs are inaccessibleThe stork agent prints excessive errors (140+ lines), including a total of 6 back traces, full of cryptic error that's useless for average users when TLS certs are inaccessible.
Example output: $1041
Steps to reproduce:
1. files in /v...The stork agent prints excessive errors (140+ lines), including a total of 6 back traces, full of cryptic error that's useless for average users when TLS certs are inaccessible.
Example output: $1041
Steps to reproduce:
1. files in /var/lib/stork-agent/certs/ are owned by `stork-agent` (permissions 600)
2. run `stork-agent` as a different user
Another case to check here is the behavior when the files (or whole dir) are missing.1.12Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1053Bunch of small UI problems2023-07-19T12:52:08ZSlawek FigielBunch of small UI problemsThe issues were found by @slawek [during 1.11 sanity checks].
[Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1048#note_379502)
The initial focus on the login page should be set on the login input box.
[Source](https://git...The issues were found by @slawek [during 1.11 sanity checks].
[Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1048#note_379502)
The initial focus on the login page should be set on the login input box.
[Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1048#note_379618)
The buttons for toggling the DHCP identifier between hex and text values are enormous wide.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/c72020f7cc91b29318e0fc1e200760fb/image.png)
[Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1048#note_379658)
JSON content under the section "User Context" on the lease search page shouldn't expand to full width if not necessary. It is how it works on the main JSON viewer page.
Actual:
![image](https://gitlab.isc.org/isc-projects/stork/uploads/1e557ab31b4ddcf9e82c692cc6b58e50/image.png)
Expected:
![expected](https://gitlab.isc.org/isc-projects/stork/uploads/b66788b71dbcdebdb0d3715eb46033ad/expected.png)1.12Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1015Format stork-tool help text2023-05-31T17:33:35ZSlawek FigielFormat stork-tool help textThe issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364521).
The help text for the `stork-tool` is not formatted properly:
```
$ ./stork-tool --help
NAME:
...The issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364521).
The help text for the `stork-tool` is not formatted properly:
```
$ ./stork-tool --help
NAME:
stork-tool - A tool for managing Stork Server.
The tool operates in three areas:
- Certificate Management - it allows for exporting Stork Server keys, certificates,
and tokens that are used to secure communication between the Stork Server
and Stork Agents;
- Database Creation - it facilitates creating a new database for the Stork Server,
and a user that can access this database with a generated password;
- Database Migration - it allows for performing database schema migrations,
overwriting the db schema version and getting its current value.
USAGE:
stork-tool [global options] command [command options] [arguments...]
```
There is an exceptionally big indentation of the paragraph starting with "The tool operates in...."1.11Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1000Use proper logo font on login page2023-05-31T13:01:50ZSlawek FigielUse proper logo font on login pageThe logo on the Stork login page and the [Stork page](https://stork.isc.org/) look different. We should unify it.
Login page:
![image](/uploads/1e2bfb196c2fee35ef4f9ca0fe5e7480/image.png)
Web page:
![image](/uploads/bac635b5dc441c46e...The logo on the Stork login page and the [Stork page](https://stork.isc.org/) look different. We should unify it.
Login page:
![image](/uploads/1e2bfb196c2fee35ef4f9ca0fe5e7480/image.png)
Web page:
![image](/uploads/bac635b5dc441c46e4e7c08ee1ac2dcf/image.png)1.11https://gitlab.isc.org/isc-projects/stork/-/issues/987CodeQL: Uncontrolled data used in path expression2023-03-30T16:43:00ZSlawek FigielCodeQL: Uncontrolled data used in path expressionWe use the URL path to construct the location of the static file to serve.
If we don't sanitize this path, the attacker may traverse over directories (e.g., by providing the `../../` prefix) to read filesystem files.
The vurnerability is...We use the URL path to construct the location of the static file to serve.
If we don't sanitize this path, the attacker may traverse over directories (e.g., by providing the `../../` prefix) to read filesystem files.
The vurnerability is available for unprivileged users.
[Source](https://github.com/isc-projects/stork/security/code-scanning/119)1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1004User with no groups is not allowed to log out.2023-03-30T10:25:00ZSlawek FigielUser with no groups is not allowed to log out.Steps to reproduce:
1. Create a user with no groups
2. Log-in
3. Try to log-outSteps to reproduce:
1. Create a user with no groups
2. Log-in
3. Try to log-out1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/971The log level inside the dump package should be human-readable2023-03-23T14:23:07ZSlawek FigielThe log level inside the dump package should be human-readableThe issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348492).
![image](https://gitlab.isc.org/isc-projects/stork/uploads/93658e2adc9e86cbade94679bedbedee/image....The issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348492).
![image](https://gitlab.isc.org/isc-projects/stork/uploads/93658e2adc9e86cbade94679bedbedee/image.png)
The log level inside the dump package should be human-readable.1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/966Empty placeholder for hooks section should start with uppercase2023-03-02T07:35:13ZSlawek FigielEmpty placeholder for hooks section should start with uppercaseThe issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348417):
![image](https://gitlab.isc.org/isc-projects/stork/uploads/57a0ac6b4b3b661204f2e2da231998d3/image....The issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348417):
![image](https://gitlab.isc.org/isc-projects/stork/uploads/57a0ac6b4b3b661204f2e2da231998d3/image.png)
An empty placeholder in the hook list should start with the uppercase.1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/842BuildNameToCertificate is deprecated2022-12-13T12:20:43ZSlawek FigielBuildNameToCertificate is deprecatedThe `backend/server/restservice/restservice.go:261` line:
```go
// must have at least one certificate or panics
httpServer.TLSConfig.BuildNameToCertificate()
```
causes a deprecation warning:
> httpServer.TLSConfig.BuildNameToCertif...The `backend/server/restservice/restservice.go:261` line:
```go
// must have at least one certificate or panics
httpServer.TLSConfig.BuildNameToCertificate()
```
causes a deprecation warning:
> httpServer.TLSConfig.BuildNameToCertificate has been deprecated since Go 1.14: NameToCertificate only allows associating a single certificate with a given name. Leave that field nil to let the library select the first compatible chain from Certificates. (SA1019)go-staticcheckbackloghttps://gitlab.isc.org/isc-projects/stork/-/issues/142UI improvement: hooks should display name only2022-11-21T14:30:58ZTomek MrugalskiUI improvement: hooks should display name onlyWe're now able to display a list of hooks. The UI for this should be improved:
- the UI should display the hooks name, not the full path kea (libdhcp_stat_cmds, not /usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_stat_cmds.so). the full pat...We're now able to display a list of hooks. The UI for this should be improved:
- the UI should display the hooks name, not the full path kea (libdhcp_stat_cmds, not /usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_stat_cmds.so). the full path could possibly be displayed when you hover cursor over it.
- the name itself could be a link to appropriate section of kea.readthedocs.io (or small [doc] link added after it).1.8Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/554alpine support for "rake unittest_backend"2022-10-25T12:10:56ZAndrei Pavelandrei@isc.orgalpine support for "rake unittest_backend"It currently complains about `--waitretry=3` not being available for Alpine's busybox wget. Rakefile could be improved to drop this flag in Alpine's case.It currently complains about `--waitretry=3` not being available for Alpine's busybox wget. Rakefile could be improved to drop this flag in Alpine's case.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/496Many warnings when running ci_ui2022-10-25T11:59:03ZTomek MrugalskiMany warnings when running ci_uiWhile the `ci_ui` checks [pass now](https://gitlab.isc.org/isc-projects/stork/-/jobs/1543321), there are many warning such as these:
```
WARN: ''app-help-tip' is not a known element:
1. If 'app-help-tip' is an Angular component, then ve...While the `ci_ui` checks [pass now](https://gitlab.isc.org/isc-projects/stork/-/jobs/1543321), there are many warning such as these:
```
WARN: ''app-help-tip' is not a known element:
1. If 'app-help-tip' is an Angular component, then verify that it is part of this module.
2. If 'app-help-tip' is a Web Component then add 'CUSTOM_ELEMENTS_SCHEMA' to the '@NgModule.schemas' of this component to
```
There are warnings about app-breadcrumbs, app-settings-menu, p-panel, p-tabMenu, p-table, app-settings-menu, p-dialog, p-footer, app-help-tip, app-rename-app-dialog, app-events-panel, p-paginator, p-overlayPanel, p-menu, p-button.
Seems we're missing a lot of imports somewhere.outstandinghttps://gitlab.isc.org/isc-projects/stork/-/issues/443test improvement: listing system tests should not require packages2022-06-21T12:33:57ZTomek Mrugalskitest improvement: listing system tests should not require packagesI've tried to get a list of system tests, but was told I need to build packages first.
```
$ ./venv/bin/pytest --collect-only tests.py
Cannot find deb or rpm Stork packages.
To prepare them run `rake build_pkgs_in_docker`.
```
Annoyin...I've tried to get a list of system tests, but was told I need to build packages first.
```
$ ./venv/bin/pytest --collect-only tests.py
Cannot find deb or rpm Stork packages.
To prepare them run `rake build_pkgs_in_docker`.
```
Annoying, but I can live with it now.outstandinghttps://gitlab.isc.org/isc-projects/stork/-/issues/722Stork server/agent log setting.2022-05-30T17:49:10ZSina HosseiniStork server/agent log setting.Hello, I have some troubles with the Stork server & agent logging mechanism.
There is just no way to configure how these two handle their logs, by default they send their logs to `/var/log/syslog` but the problem is on top of not being ...Hello, I have some troubles with the Stork server & agent logging mechanism.
There is just no way to configure how these two handle their logs, by default they send their logs to `/var/log/syslog` but the problem is on top of not being able to disable it, there are ANSI color codes in the log messages ( which I have no idea how they're getting logged in the first place ) and that is causing issues for my log management.
Sample:
```bash
#011/tmp/build/tools/1.17.5/go/src/runtime/asm_amd64.s:1581
#033[31mERRO#033[0m[2022-04-03 14:00:31] periodicexecutor.go:169 errors were encountered while pulling data from apps: missing Arguments from Lease Stats response {ResponseHeader:{Result:2 Text:'stat-lease6-get' command not supported. Daemon:dhcp6} Arguments:<nil>}
#033[36mINFO#033[0m[2022-04-03 14:00:31] statspuller.go:69 completed pulling lease stats from Kea apps: 0/1 succeeded
```
I found out that these logs are correctly formatted when using the `journalctl` command, however, the ANSI color codes exist in the `/var/log/syslog` and since my log management is gathering all logs through `syslog` the ANSI color codes are proving problematic.
Please address this issue, any help regarding how to drop these codes, fix them, or any workaround is appreciated.
Many thanks in advance.1.4Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/437failed unit-tests due to missing dependency2022-05-11T09:37:48ZTomek Mrugalskifailed unit-tests due to missing dependencyTried running `rake unittest_backend` on my fresh Ubuntu 20.04. They failed with this:
```
rm -f backend/server/agentcomm/api_mock.go
for db in $(psql -t -h localhost -p 5432 -U storktest -c "select datname from pg_database wher...Tried running `rake unittest_backend` on my fresh Ubuntu 20.04. They failed with this:
```
rm -f backend/server/agentcomm/api_mock.go
for db in $(psql -t -h localhost -p 5432 -U storktest -c "select datname from pg_database where datname ~ 'storktest.*'"); do
dropdb -h localhost -p 5432 -U storktest $db
done
sh: 2: psql: not found
createdb -h localhost -p 5432 -U storktest -O storktest storktest
rake aborted!
Command failed with status (127): [createdb -h localhost -p 5432 -U storktest...]
/home/thomson/devel/stork/Rakefile:405:in `block in <top (required)>'
/usr/share/rubygems-integration/all/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
Tasks: TOP => unittest_backend
(See full trace by running task with --trace)
```
We should either make a check if psql is available (maybe make an array of tools we require in the system)?1.3https://gitlab.isc.org/isc-projects/stork/-/issues/654PrimeNG errors during UI unit tests2022-02-08T12:57:21ZSlawek FigielPrimeNG errors during UI unit testsThe issue was found during sanity checks for the 1.0 release.
Source: https://gitlab.isc.org/isc-projects/stork/-/issues/645#note_253008
While running `rake ng_test` I got this error in between some tests:
`TypeError: Cannot read prop...The issue was found during sanity checks for the 1.0 release.
Source: https://gitlab.isc.org/isc-projects/stork/-/issues/645#note_253008
While running `rake ng_test` I got this error in between some tests:
`TypeError: Cannot read properties of undefined (reading 'offsetHeight')`1.2Marcin SiodelskiMarcin Siodelski