stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2020-06-12T12:38:38Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/313Docker up does fails on rebuild2020-06-12T12:38:38ZMarcin SiodelskiDocker up does fails on rebuildThe original problem was found here: https://gitlab.isc.org/isc-projects/stork/-/merge_requests/139#note_13813
I ran this on macOS. After switching between the branches containing code differences I got build failures. Apparently, the d...The original problem was found here: https://gitlab.isc.org/isc-projects/stork/-/merge_requests/139#note_13813
I ran this on macOS. After switching between the branches containing code differences I got build failures. Apparently, the docker_up does not rebuild the code when necessary.0.9Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/265-v, --version: agent, server should report version2020-06-12T17:45:50ZTomek Mrugalski-v, --version: agent, server should report versionThis is a ticket for addressing the 0.6.0 sanity checks issue raised by @marcin here: https://gitlab.isc.org/isc-projects/stork/-/issues/227#note_122037
The idea is obvious: we need a way to identify agent and server version. We need a ...This is a ticket for addressing the 0.6.0 sanity checks issue raised by @marcin here: https://gitlab.isc.org/isc-projects/stork/-/issues/227#note_122037
The idea is obvious: we need a way to identify agent and server version. We need a `-v` and `--version` command line switches for this.0.9Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/320adapt deploy_demo in .gitlab-ci.yml to new model of building demo (docker_up)2020-06-16T13:22:15ZMichal Nowikowskiadapt deploy_demo in .gitlab-ci.yml to new model of building demo (docker_up)0.9Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/319Don't log error on missing BIND 9 stats2020-06-17T06:16:08ZMatthijs Mekkingmatthijs@isc.orgDon't log error on missing BIND 9 stats```
agent-bind9-2_1 | ERRO[2020-06-10 18:00:04]prombind9exporter.go:663 no 'qtypes' in response:
agent-bind9-2_1 | ERRO[2020-06-10 18:00:04]prombind9exporter.go:663 no 'nsstats' in response: ...```
agent-bind9-2_1 | ERRO[2020-06-10 18:00:04]prombind9exporter.go:663 no 'qtypes' in response:
agent-bind9-2_1 | ERRO[2020-06-10 18:00:04]prombind9exporter.go:663 no 'nsstats' in response:
agent-bind9_1 | ERRO[2020-06-10 18:00:05]prombind9exporter.go:663 no 'qtypes' in response:
agent-bind9_1 | ERRO[2020-06-10 18:00:05]prombind9exporter.go:663 no 'nsstats' in response:
```
When certain statistics are not reported by the statistics-channel, this should be omitted with a notice not an error.0.9Matthijs Mekkingmatthijs@isc.orgMatthijs Mekkingmatthijs@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/76Req 10.1.3 - Standalone use of Prometheus and Grafana2020-06-18T16:21:50ZVicky Riskvicky@isc.orgReq 10.1.3 - Standalone use of Prometheus and GrafanaThe user is already using Prometheus and Grafana with other network elements and does not wish to add a new GUI (Stork). Some users will want to use the Prometheus exporter and Grafana template without Stork. If this project can deliver ...The user is already using Prometheus and Grafana with other network elements and does not wish to add a new GUI (Stork). Some users will want to use the Prometheus exporter and Grafana template without Stork. If this project can deliver supported modules for these two popular open source projects, that would be valuable.0.9Vicky Riskvicky@isc.orgVicky Riskvicky@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/305error while pulling reservations by server from agent2020-06-22T10:48:18ZMichal Nowikowskierror while pulling reservations by server from agentThe problem appears in subsequent fetch of reservations in case when kea-dhcp4 daemon is stopped.
```
ERRO[2020-05-31 11:14:47] host.go:88 error occurred while fetching hosts from app {ID:1 CreatedAt:2020-05-31 09:14:02.2...The problem appears in subsequent fetch of reservations in case when kea-dhcp4 daemon is stopped.
```
ERRO[2020-05-31 11:14:47] host.go:88 error occurred while fetching hosts from app {ID:1 CreatedAt:2020-05-31 09:14:02.279493 +0000 UTC MachineID:1 Machine:0xc000844160 Type:kea Active:false Meta:{Version:1.7.3 ExtendedVersion:} AccessPoints:[0xc0009b20f0] Daemons:[0xc0007c2fc0 0xc0007c3080 0xc0007c3140 0xc0007c3200]}: error returned by Kea in response to reservation-get-page command
isc.org/stork/server/apps/kea.(*HostDetectionIterator).sendReservationGetPage
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:253
isc.org/stork/server/apps/kea.(*HostDetectionIterator).DetectHostsPageFromHostCmds
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:366
isc.org/stork/server/apps/kea.updateHostsFromHostCmds
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:546
isc.org/stork/server/apps/kea.(*HostsPuller).pullData
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:85
isc.org/stork/server/agentcomm.(*PeriodicPuller).pullerLoop
/home/godfryd/isc/repos/stork-dashb/backend/server/agentcomm/puller.go:93
runtime.goexit
/home/godfryd/isc/repos/stork-dashb/tools/1.13.5/go/src/runtime/asm_amd64.s:1357
problem with sending reservation-get-page command upon attempt to detect host reservations over the host_cmds hooks library
WARN[2020-05-31 11:14:47] statspuller.go:49 missing key total-addreses in LocalSubnet 15 stats
INFO[2020-05-31 11:14:47] host.go:101 completed pulling hosts from Kea apps: 0/1 succeeded
ERRO[2020-05-31 11:14:47] puller.go:95 errors were encountered while pulling data from Kea apps: error returned by Kea in response to reservation-get-page command
isc.org/stork/server/apps/kea.(*HostDetectionIterator).sendReservationGetPage
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:253
isc.org/stork/server/apps/kea.(*HostDetectionIterator).DetectHostsPageFromHostCmds
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:366
isc.org/stork/server/apps/kea.updateHostsFromHostCmds
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:546
isc.org/stork/server/apps/kea.(*HostsPuller).pullData
/home/godfryd/isc/repos/stork-dashb/backend/server/apps/kea/host.go:85
isc.org/stork/server/agentcomm.(*PeriodicPuller).pullerLoop
/home/godfryd/isc/repos/stork-dashb/backend/server/agentcomm/puller.go:93
runtime.goexit
/home/godfryd/isc/repos/stork-dashb/tools/1.13.5/go/src/runtime/asm_amd64.s:1357
problem with sending reservation-get-page command upon attempt to detect host reservations over the host_cmds hooks library
```0.9Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/261switch from DefaultRegisterer to our own in prometheus exporters in agent2020-06-23T08:37:59ZMichal Nowikowskiswitch from DefaultRegisterer to our own in prometheus exporters in agentCurrently we are using defaul DefaultRegisterer. It comes with pre-installed collectors for current process information and Go runtime information. This does not have to be exposed. Additionally it raises some errors to console.
We shou...Currently we are using defaul DefaultRegisterer. It comes with pre-installed collectors for current process information and Go runtime information. This does not have to be exposed. Additionally it raises some errors to console.
We should create our own Registerer and collect there only Kea/BIND9 stats.0.9Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/322improve preparing and cleaning db for server unit tests2020-06-23T09:01:23ZMichal Nowikowskiimprove preparing and cleaning db for server unit tests1) it should create test db from template db to speed up the setup process
2) it should prepare automatically template db before testing
3) it should remove any reminding test dbs from previous runs
4) switch to machines with SSD1) it should create test db from template db to speed up the setup process
2) it should prepare automatically template db before testing
3) it should remove any reminding test dbs from previous runs
4) switch to machines with SSD0.9Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/45Req 2.2 - Host Reservations List2020-06-23T15:59:26ZVicky Riskvicky@isc.orgReq 2.2 - Host Reservations ListAs an administrator, I would like to be able to browse a list of host reservations.
* [ ] I would like to be able to sort this list by IP, ~~date the lease was assigned to a client,~~ or host name.
* [x] I would like to be able to searc...As an administrator, I would like to be able to browse a list of host reservations.
* [ ] I would like to be able to sort this list by IP, ~~date the lease was assigned to a client,~~ or host name.
* [x] I would like to be able to searching for a host reservation based on IP address
* [x] I would like to be able to searching for a host reservation based on hostname
* [ ] ~~I would like to be able to apply a filter to show either all addresses assigned, or all host reservations not claimed.~~
* [ ] ~~I would like to see if a lease for this reservation has actually been requested and assigned.~~
* [ ] ~~I would like to see the pxeboot file option value for each host.~~
* [x] Filter the reservations list by type (hw-address, duid, client-id, flex-id etc)
* [x] Search for a host reservation based on MAC address, client-id, duid, flex-id values.
There were several more requirements here that needed lease information. I moved them to #237.
Those related to displaying options were pushed back to #314.
Details:
* What additional options from the HR can we display?0.9https://gitlab.isc.org/isc-projects/stork/-/issues/327Handle HTTP 403 errors for unauthorized users2020-06-24T13:52:25ZMarcin SiodelskiHandle HTTP 403 errors for unauthorized usersThis is the follow up ticket to #119. It was found that when the session is destroyed (e.g. removed from the database) but the session information is stored in the local storage (the user didn't log off explicitly via the UI), the user g...This is the follow up ticket to #119. It was found that when the session is destroyed (e.g. removed from the database) but the session information is stored in the local storage (the user didn't log off explicitly via the UI), the user gets redirected to the forbidden page when trying to navigate to the login page. This is because, the login page sends some REST calls to the server and the server apparently returns error 403 for the unauthorized user, rather than 401. This case has to be handled and if the session doesn't exist the user must not navigate to forbidden page, even upon receiving error 403.0.9Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/119Intercept common access denied errors and display it as a separate page2020-06-25T17:20:22ZMarcin SiodelskiIntercept common access denied errors and display it as a separate pageAs pointed out in the following review comment: https://gitlab.isc.org/isc-projects/stork/merge_requests/28#note_99381, we need to intercept certain access errors and display appropriate error page rather than an empty table. This ticket...As pointed out in the following review comment: https://gitlab.isc.org/isc-projects/stork/merge_requests/28#note_99381, we need to intercept certain access errors and display appropriate error page rather than an empty table. This ticket is to deal with this issue in a generic way.0.9Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/3320.9 release changes2020-07-09T15:26:50ZMichal Nowikowski0.9 release changes0.9Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/235dashboard: the pool utilization should be shown as a progress bar2020-07-09T15:26:50ZMichal Nowikowskidashboard: the pool utilization should be shown as a progress bar... similar to how it's shown in the subnets view.... similar to how it's shown in the subnets view.0.9Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/stork/-/issues/323go-swagger build error workaround (docker/ubuntu 20.04)2020-07-09T15:26:50ZTomek Mrugalskigo-swagger build error workaround (docker/ubuntu 20.04)I've tried to build Stork demo on Ubuntu 20.04. And ended with this error:
```
rake docker_up
[...]
/repo/build-root/tools/v0.23.0/swagger_linux_amd64 generate server -s server/gen/restapi -m server/gen/models --name Stork --exclude-ma...I've tried to build Stork demo on Ubuntu 20.04. And ended with this error:
```
rake docker_up
[...]
/repo/build-root/tools/v0.23.0/swagger_linux_amd64 generate server -s server/gen/restapi -m server/gen/models --name Stork --exclude-main --spec /repo/build-root/api/swagger.yaml --template stratoscale --regenerate-configureapi
2020/06/18 19:11:51 loading contrib stratoscale
2020/06/18 19:11:51 added contributed template client/client.gotmpl from templates/contrib/stratoscale/client/client.gotmpl
2020/06/18 19:11:51 added contributed template client/facade.gotmpl from templates/contrib/stratoscale/client/facade.gotmpl
2020/06/18 19:11:51 added contributed template server/configureapi.gotmpl from templates/contrib/stratoscale/server/configureapi.gotmpl
2020/06/18 19:11:51 added contributed template server/server.gotmpl from templates/contrib/stratoscale/server/server.gotmpl
runtime: mlock of signal stack failed: 12
runtime: increase the mlock limit (ulimit -l) or
runtime: update your kernel to 5.3.15+, 5.4.2+, or 5.5+
fatal error: mlock failed
runtime stack:
runtime.throw(0xd2780f, 0xc)
/usr/local/go/src/runtime/panic.go:1112 +0x72
runtime.mlockGsignal(0xc000603e00)
/usr/local/go/src/runtime/os_linux_x86.go:72 +0x107
runtime.mpreinit(0xc000588a80)
/usr/local/go/src/runtime/os_linux.go:341 +0x78
runtime.mcommoninit(0xc000588a80)
/usr/local/go/src/runtime/proc.go:630 +0x108
runtime.allocm(0xc000061800, 0xd6dda8, 0x0)
/usr/local/go/src/runtime/proc.go:1390 +0x14e
runtime.newm(0xd6dda8, 0xc000061800)
/usr/local/go/src/runtime/proc.go:1704 +0x39
runtime.startm(0x0, 0xc000510301)
/usr/local/go/src/runtime/proc.go:1869 +0x12a
runtime.wakep(...)
/usr/local/go/src/runtime/proc.go:1953
runtime.resetspinning()
/usr/local/go/src/runtime/proc.go:2415 +0x93
runtime.schedule()
/usr/local/go/src/runtime/proc.go:2527 +0x2de
runtime.park_m(0xc000001980)
/usr/local/go/src/runtime/proc.go:2690 +0x9d
runtime.mcall(0x0)
/usr/local/go/src/runtime/asm_amd64.s:318 +0x5b
goroutine 1 [runnable]:
github.com/go-openapi/swag.WriteJSON(0xbefca0, 0xc000be60e0, 0x4, 0x10, 0x0, 0x0, 0x0)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/json.go:56 +0x1ef
github.com/go-openapi/swag.JSONMapItem.MarshalEasyJSON(0xc00089bc7c, 0x4, 0xbefca0, 0xc000be60e0, 0xc000c00620)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:125 +0x6e
github.com/go-openapi/swag.JSONMapSlice.MarshalEasyJSON(0xc000be8000, 0x6, 0x6, 0xc000c00620)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:75 +0x97
github.com/go-openapi/swag.WriteJSON(0xc48420, 0xc000be62c0, 0x3, 0x556a7c, 0x50, 0x68, 0xc000c005b0)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/json.go:59 +0x92
github.com/go-openapi/swag.JSONMapItem.MarshalEasyJSON(0xc00089bc2b, 0x3, 0xc48420, 0xc000be62c0, 0xc000c005b0)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:125 +0x6e
github.com/go-openapi/swag.JSONMapSlice.MarshalEasyJSON(0xc000be60c0, 0x1, 0x1, 0xc000c005b0)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:75 +0x97
github.com/go-openapi/swag.WriteJSON(0xc48420, 0xc000be62e0, 0x7, 0x236, 0x0, 0x0, 0x0)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/json.go:59 +0x92
github.com/go-openapi/swag.JSONMapItem.MarshalEasyJSON(0xc00089bc24, 0x7, 0xc48420, 0xc000be62e0, 0xc000bb0e00)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:125 +0x6e
github.com/go-openapi/swag.JSONMapSlice.MarshalEasyJSON(0xc0001c4780, 0x14, 0x14, 0xc000bb0e00)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:75 +0x97
github.com/go-openapi/swag.WriteJSON(0xc48420, 0xc000bec340, 0x5, 0x80, 0x0, 0x0, 0x0)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/json.go:59 +0x92
github.com/go-openapi/swag.JSONMapItem.MarshalEasyJSON(0xc00089b2b6, 0x5, 0xc48420, 0xc000bec340, 0xc000bb0c40)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:125 +0x6e
github.com/go-openapi/swag.JSONMapSlice.MarshalEasyJSON(0xc0001d4280, 0xa, 0xa, 0xc000bb0c40)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:75 +0x97
github.com/go-openapi/swag.WriteJSON(0xc48420, 0xc000bf01a0, 0xc48420, 0xc000bf01a0, 0x0, 0x0, 0x0)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/json.go:59 +0x92
github.com/go-openapi/swag.YAMLToJSON(0xc15fe0, 0xc000be1020, 0xc15fe0, 0xc000be1020, 0x0, 0x0, 0x5)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:40 +0x85
github.com/go-openapi/swag.YAMLDoc(0x7fffdebefe13, 0x21, 0xc000149d01, 0x0, 0x0, 0xc000787980, 0x4ffd00)
/go/pkg/mod/github.com/go-openapi/swag@v0.19.8/yaml.go:230 +0x60
github.com/go-openapi/loads.Spec(0x7fffdebefe13, 0x21, 0xd49261, 0xc000787a08, 0x1d)
/go/pkg/mod/github.com/go-openapi/loads@v0.19.5/spec.go:123 +0xec
github.com/go-swagger/go-swagger/generator.(*GenOpts).validateAndFlattenSpec(0xc000638fc0, 0x7fffdebefe40, 0xb, 0x0)
/go/src/github.com/go-swagger/go-swagger/generator/spec.go:22 +0x50
github.com/go-swagger/go-swagger/generator.(*GenOpts).analyzeSpec(0xc000638fc0, 0x0, 0x0, 0x7f73563f87d0, 0x0)
/go/src/github.com/go-swagger/go-swagger/generator/spec.go:88 +0x35
github.com/go-swagger/go-swagger/generator.newAppGenerator(0x7fffdebefdf7, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc000638fc0, 0xc00001c540, ...)
/go/src/github.com/go-swagger/go-swagger/generator/support.go:61 +0x88
github.com/go-swagger/go-swagger/generator.GenerateServer(0x7fffdebefdf7, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc000638fc0, 0xc000638fc0, ...)
/go/src/github.com/go-swagger/go-swagger/generator/support.go:36 +0x94
github.com/go-swagger/go-swagger/cmd/swagger/commands/generate.(*Server).generate(0xc00000a5a0, 0xc000638fc0, 0x0, 0x0)
/go/src/github.com/go-swagger/go-swagger/cmd/swagger/commands/generate/server.go:88 +0x94
github.com/go-swagger/go-swagger/cmd/swagger/commands/generate.createSwagger(0xea6e40, 0xc00000a5a0, 0x8b4a01, 0x7f732f76b2b8)
/go/src/github.com/go-swagger/go-swagger/cmd/swagger/commands/generate/shared.go:175 +0x225
github.com/go-swagger/go-swagger/cmd/swagger/commands/generate.(*Server).Execute(0xc00000a5a0, 0xc0001b4a80, 0x0, 0xe, 0xc00000a5a0, 0x1)
/go/src/github.com/go-swagger/go-swagger/cmd/swagger/commands/generate/server.go:115 +0x37
github.com/jessevdk/go-flags.(*Parser).ParseArgs(0xc000185e00, 0xc00018c010, 0xe, 0xe, 0x10, 0xd54c3a, 0x2a, 0xbda6e0, 0xc0003b1ef0)
/go/pkg/mod/github.com/jessevdk/go-flags@v1.4.0/parser.go:316 +0x8c0
github.com/jessevdk/go-flags.(*Parser).Parse(...)
/go/pkg/mod/github.com/jessevdk/go-flags@v1.4.0/parser.go:186
main.main()
/go/src/github.com/go-swagger/go-swagger/cmd/swagger/swagger.go:145 +0xafc
rake aborted!
Command failed with status (2): [/repo/build-root/tools/v0.23.0/swagger_lin...]
/repo/build-root/Rakefile:195:in `block (2 levels) in <top (required)>'
/repo/build-root/Rakefile:194:in `chdir'
/repo/build-root/Rakefile:194:in `block in <top (required)>'
Tasks: TOP => install_server => build_server => gen_server => /repo/build-root/backend/server/gen/restapi/configure_stork.go
(See full trace by running task with --trace)
rake aborted!
Command failed with status (1): [cd ./build-root && GOPATH=/repo/build-root...]
/repo/Rakefile:551:in `block in <top (required)>'
Tasks: TOP => build_all_copy_in_subdir
(See full trace by running task with --trace)
rake aborted!
Command failed with status (1): [docker run -v $PWD:/repo --rm stork-builde...]
/home/thomson/devel/stork/Rakefile:544:in `block in <top (required)>'
/usr/share/rubygems-integration/all/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
Tasks: TOP => docker_up => build_all_in_container
(See full trace by running task with --trace)
```
This is actually a kernel bug, details [go#35777](https://github.com/golang/go/issues/35777) and [go#37436](https://github.com/golang/go/issues/37436). This was so common that go added an actual test to detect if the kernel is buggy on not, that's why it prints this:
```
runtime: mlock of signal stack failed: 12
runtime: increase the mlock limit (ulimit -l) or
runtime: update your kernel to 5.3.15+, 5.4.2+, or 5.5+
```
This works fine when building natively, but fails in Docker containers. This ticket proposes a workaround for this problem.
It is intended to be temporary (couple months). However, at this time there is no newer kernel available for Ubuntu 20.04 (the lastest as of today) and we can't realistically expect people to compile new kernel for Stork compilation.0.9Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/331Issues with initial fetch of user groups2020-07-09T15:26:51ZMarcin SiodelskiIssues with initial fetch of user groupsWhen I was reviewing #310 I found that system groups are not properly fetched by the UI. When I entered the users view, the drop down that normally allows for selecting which group the new user should belong to was empty. Also, the non a...When I was reviewing #310 I found that system groups are not properly fetched by the UI. When I entered the users view, the drop down that normally allows for selecting which group the new user should belong to was empty. Also, the non admin user had 'unknown' group assigned in the users list. It seems there was a race between services in getting the list of groups.
The viable solution seems to be to move the initialization of the groups to the `ServerDataService`.0.9https://gitlab.isc.org/isc-projects/stork/-/issues/330Blank page after logging2020-07-09T15:26:51ZMarcin SiodelskiBlank page after loggingReproduction steps:
- Login to the system and display dashboard page.
- Login to the database and remove a session from the sessions table
- Refresh the page and you should be taken to the login page
- Login to the system again
- Blank p...Reproduction steps:
- Login to the system and display dashboard page.
- Login to the database and remove a session from the sessions table
- Refresh the page and you should be taken to the login page
- Login to the system again
- Blank page should be displayed
It appears that the dashboard component displays the contents only when some stats are available. The stats are gathered upon page refresh or when the interval of 30 mins elapses. When we log in to the system there is no page refresh so the stats are not gathered. This seems to cause the page to remain blank.0.9Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/329Enable authentication for the traffic generators2020-07-09T15:26:51ZMarcin SiodelskiEnable authentication for the traffic generatorsNow that we have fixed a bug that allowed for unauthorized access to some Stork views we need to modify the DHCP and DNS traffic generators to create the session (login) prior to getting configured DHCP subnets from the server. Without t...Now that we have fixed a bug that allowed for unauthorized access to some Stork views we need to modify the DHCP and DNS traffic generators to create the session (login) prior to getting configured DHCP subnets from the server. Without this, the traffic generators fail t get the list of subnets and this makes them unusable.
The useful reference I got from @godfryd was: https://requests.readthedocs.io/en/master/user/advanced/0.9Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/326prombind9exporter does not unregister all collectors2020-07-10T12:35:26ZMichal Nowikowskiprombind9exporter does not unregister all collectorsCurrently it registers:
```go
pbe.Registry.MustRegister(version.NewCollector("bind_exporter"))
pbe.Registry.MustRegister(pbe)
if bind9Pid > 0 {
procExporter := prometheus.NewProcessCollector(
prometheus.ProcessCollectorOpts{
...Currently it registers:
```go
pbe.Registry.MustRegister(version.NewCollector("bind_exporter"))
pbe.Registry.MustRegister(pbe)
if bind9Pid > 0 {
procExporter := prometheus.NewProcessCollector(
prometheus.ProcessCollectorOpts{
PidFn: func() (int, error) {
return int(bind9Pid), nil
},
Namespace: namespace,
})
pbe.Registry.MustRegister(procExporter)
}
```
but only deregisters:
```go
// unregister bind9 counters from prometheus framework
pbe.Registry.Unregister(pbe)
```0.9Matthijs Mekkingmatthijs@isc.orgMatthijs Mekkingmatthijs@isc.org