Agent installation script doesn't work with stork configured for https
name: Bug report
about: Create a report to help us improve
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT REPORT IT HERE. Please use https://www.isc.org/community/report-bug/ instead or send mail to security-office(at)isc(dot)org.
Describe the bug Stork 1.15.0 configured with https. Agent installation script from GUI details : wget https://x.x.x.x:8080/stork-install-agent.sh
However, stork-install-agent.sh is configured to download package via : curl -o /tmp/isc-stork-agent.deb "x.x.x.x:8080/assets/pkgs/isc-stork-agent_1.15.0.240205220739_amd64.deb" Note that "https://" is not specified.
Resulting in a downloaded file that contains: Client sent an HTTP request to an HTTPS server.
To Reproduce Steps to reproduce the behavior:
- Install Stork 1.15.0 and configure with https
- Execute provided agent installation from GUI
- Script fails because isc stork agent package is attempted to be downloaded via http, but stork is configured with https
Expected behavior Stork should code agent installation script to download asset package via https, if STORK_REST_TLS_CERTIFICATE is configured.
Environment:
- Stork: 1.15.0
- OS: Ubuntu 20.04