Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • stork stork
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 260
    • Issues 260
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 27
    • Merge requests 27
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • storkstork
  • Merge requests
  • !41

Resolve "Services: listing, add new service, fetch a service in both frontend and the backend."

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthijs Mekking requested to merge matthijs/stork:24-services-clean-commits into master Dec 13, 2019
  • Overview 18
  • Commits 10
  • Pipelines 0
  • Changes 43

This MR replaces !29 (closed)

The difference is that this MR divides the feature into commits, one individual change per commit. The fixup commits are reactions to code review comments. MR !29 (closed) has two commits, all changes in these two commits are now divided into many split up commits and fixup commits. Since the changes are identical, all these commits are authored by @godfryd

On top of these commits there are some minor fixup commits to address some more small review comments authored by @matthijs

This MR must not be merged until all issues from !29 (closed) !39 (closed) and !41 (merged) (this MR) are resolved. If changes are approved, all the fixup commits should be squashed prior to merging.

Closes #24 (closed)

Edited Dec 23, 2019 by Michal Nowikowski
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 24-services-clean-commits