... | ... | @@ -42,7 +42,7 @@ cd stork |
|
|
|
|
|
- as a developer: look for issues that are assigned to you. Do your best with addressing the comments. Put a witty response to snarky comments. Push your improvements to the branch. Once done, reassign back to the reviewer. DO NOT MERGE until the reviewer says the code is ready.
|
|
|
|
|
|
- as a reviewer: Once all your comments are addressed, put a note that the code is ready to merge, open the MR, edit it and click on "remove WIP status". Removal of the WIP status is a clear indication the code is ready to go. Recenty gitlab versions also have Approve button. Use it.
|
|
|
- as a reviewer: Once all your comments are addressed, put a note that the code is ready to merge, open the MR, edit it and click on "remove WIP status". Removal of the WIP status is a clear indication the code is ready to go. Recently, Gitlab versions have also gained an Approve button. Use it.
|
|
|
|
|
|
- If you can't reach an agreement after several review rounds, you can do one of three things: ask for a third opinion (any developer will do), ask the manager to solve the problem, or perhaps rethink if this is the right approach. As disappointing as it may be, sometimes abandoning the changes and starting from scratch may be the best option in the long term. Also, think about your own arguments. Are you trying to push your point of view, simply because you like it? It's an art of compromise.
|
|
|
|
... | ... | |