... | ... | @@ -26,15 +26,15 @@ cd stork |
|
|
|
|
|
# Working on an issue
|
|
|
|
|
|
- Once you start working on an issue, assign the issue to yourself. You should also assign Doing label. There are two ways of doing that. First, you can add the label manually when browsing an issue. Alternatively, you can go to https://gitlab.isc.org/isc-projects/stork/boards and drag and drop your issue to appropriate stage.
|
|
|
- Once you start working on an issue, assign the issue to yourself. You should also assign `Doing` label. There are two ways of doing that. First, you can add the label manually when browsing an issue. Alternatively, you can go to https://gitlab.isc.org/isc-projects/stork/boards and drag and drop your issue to the appropriate stage.
|
|
|
|
|
|
- Open the issue page, e.g. https://gitlab.isc.org/isc-projects/stork/issues/3 and click create a MR. A good trick is to click on the triangle button to get the extended create MR menu. In particular, you can use a shorter branch name. The branch name MUST start with the issue number.
|
|
|
- Open the issue page, e.g. https://gitlab.isc.org/isc-projects/stork/issues/3 and click create an MR. A good trick is to click on the triangle button to get the extended create MR menu. In particular, you can use a shorter branch name. The branch name MUST start with the issue number.
|
|
|
|
|
|
- ```git pull```. Note the branch that was just created will be there. Check it out and start working on the code. If you dislike the branch name being too long, see the trick about about using shorter name. Also, if you have bash-completion package installed (and using bash), you can type: git checkout 3, and hit tab. The full name of the branch will be completed for you.
|
|
|
- ```git pull```. Note the branch that was just created will be there. Check it out and start working on the code. If you dislike the branch name being too long, see the trick about using a shorter name. Also, if you have bash-completion package installed (and using bash), you can type: git checkout 3, and hit tab. The full name of the branch will be completed for you.
|
|
|
|
|
|
- Commit your changes, push it on that branch.
|
|
|
|
|
|
- Once you are done, do the following: unassign yourself from the issue and MR, remove "Doing" label, add "Review" label. The doing and review labels should be put on both the issue and the MR. This indicates the MR is ready for a review. This looks like a duplication of work, but it serves different purposes. The issues are tracked using a board (see [this Stork 0.1 board](https://gitlab.isc.org/isc-projects/stork/-/boards?scope=all&utf8=%E2%9C%93&state=opened&milestone_title=Stork-0.1) for example). Once you assign a label to an issue it is shown in the appropriate column. Now, the review label on MR indicates that particular one is ready for review. The illusion of duplication disappears when there are multiple MRs assigned to a single issue.
|
|
|
- Once you are done, do the following: unassign yourself from the issue and MR, remove `Doing` label, add `Review` label. The doing and review labels should be put on both the issue and the MR. This indicates the MR is ready for a review. This looks like a duplication of work, but it serves different purposes. The issues are tracked using a board (see [this Stork 0.1 board](https://gitlab.isc.org/isc-projects/stork/-/boards?scope=all&utf8=%E2%9C%93&state=opened&milestone_title=Stork-0.1) for example). Once you assign a label to an issue it is shown in the appropriate column. Now, the review label on MR indicates that particular one is ready for review. The illusion of duplication disappears when there are multiple MRs assigned to a single issue.
|
|
|
|
|
|
# Reviewing an issue
|
|
|
|
... | ... | |