stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2024-03-05T14:58:46Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/1316Create a page showing all connectivity errors2024-03-05T14:58:46ZMarcin SiodelskiCreate a page showing all connectivity errorsFollowing the work from #1222, I would like to propose that we add a page where we're going to show the apps with the connectivity issues. We can use the new endpoint from #1222 to get this list.Following the work from #1222, I would like to propose that we add a page where we're going to show the apps with the connectivity issues. We can use the new endpoint from #1222 to get this list.1.17https://gitlab.isc.org/isc-projects/stork/-/issues/1315Prometheus exporters should fetch the data on demand2024-03-05T14:56:38ZSlawek FigielPrometheus exporters should fetch the data on demandCurrently, we periodically aggregate the metrics for Prometheus purposes using internal Stork intervals. It means the Prometheus collector always pulls a bit of outdated cached values.
We should avoid using the internal collecting loop ...Currently, we periodically aggregate the metrics for Prometheus purposes using internal Stork intervals. It means the Prometheus collector always pulls a bit of outdated cached values.
We should avoid using the internal collecting loop and our own intervals. The Prometheus collector should be the one to decide when and how often the data are fetched.
- [ ] The Stork agent should send the `statistics-get-all` command and process the response on request to the `/metrics` endpoint
- [ ] The Stork server should retrieve the adjusted utilizations and machine counters on request to the `/metrics` endpointbackloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1314Include the DHCP option names in the hash calculations2024-03-05T14:46:08ZSlawek FigielInclude the DHCP option names in the hash calculationsIn #977, we decided to calculate the DHCP option hash excluding its name, because the lookup for custom DHCP options is not implemented. It causes the DHCP option name to be unknown in several use cases, so we don't acquire an expected h...In #977, we decided to calculate the DHCP option hash excluding its name, because the lookup for custom DHCP options is not implemented. It causes the DHCP option name to be unknown in several use cases, so we don't acquire an expected hash.
The support for the custom DHCP option will be added in #954. After merging it, we should include the DHCP option in the hash calculations and remove the temporary workaround.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1313Incorrect default *.env file.2024-02-27T09:52:35ZAndreas JentschIncorrect default *.env file.---
name: Bug report
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. Please use https://www.isc.org/community/report-bug/...---
name: Bug report
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. Please use https://www.isc.org/community/report-bug/ instead or send mail to
security-office(at)isc(dot)org.
**Describe the bug**
If you start the agent with the following command, this output is generated.
/usr/bin/stork-agent --use-env-file
FATA[2024-02-08 10:39:55] main.go:406 invalid environment file: '/etc/stork/server.env': ...
**To Reproduce**
Steps to reproduce the behavior:
1. /usr/bin/stork-agent --env-file '/etc/stork/agent.env' --use-env-file
**Expected behavior**
You should adjust the default value for the .*env file.
**Environment:**
/usr/bin/stork-agent -v
1.15.0
Static hostname: dhcp-01-xgs.glattnet.ch
Icon name: computer-server
Chassis: server 🖳
Machine ID: cf6ef911a0974dbfa031e35e8f775125
Boot ID: 96edd982af2d4745a030003205e7fae2
Operating System: Rocky Linux 9.3 (Blue Onyx)
CPE OS Name: cpe:/o:rocky:rocky:9::baseos
Kernel: Linux 5.14.0-362.18.1.el9_3.x86_64
Architecture: x86-64
Hardware Vendor: HPE
Hardware Model: ProLiant DL360 Gen10
Firmware Version: U32
- Kea version: 2.2.0
tarball
linked with:
log4cplus 2.0.5
OpenSSL 3.0.7 1 Nov 2022
database:
MySQL backend 14.0, library 3.2.6
PostgreSQL backend 13.0, library 130013
Memfile backend 2.1
- Stork: 1.15.0
- OS: Rocky Linux 9.3 (Blue Onyx)
- Kea: Which features were compiled in (in particular which backends)
- Kea: If/which hooks where loaded in
**Contacting you**
E-Mail1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1312Follow-up from the 1.15 release2024-03-28T10:14:09ZAndrei Pavelandrei@isc.orgFollow-up from the 1.15 releaseIssues with the release that need to be fixed:
- The `upload_to_repo` job was not able to trigger any gitlab runner after the migration in issue 1170. The job has too many tags. Removing `stork-repo` or `aws` would solve the impasse.
- ...Issues with the release that need to be fixed:
- The `upload_to_repo` job was not able to trigger any gitlab runner after the migration in issue 1170. The job has too many tags. Removing `stork-repo` or `aws` would solve the impasse.
- The release notes are currently folded at 73 characters. This includes folding changelog entryes. There seems to be a gentleman's agreement that changelog entries should be capped at 80 characters. This makes the changelog in the release notes less readable than it could be. Look at the [1.14 release notes](https://downloads.isc.org/isc/stork/1.14.0/Stork-1.14.0-ReleaseNotes.txt) for example. This has been manually fixed for 1.15, but extending the folding to 80 would be good. A lint step in CI to make sure this rule is respected for changelog entries wouldn't hurt either.
-1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1311After PrimeNG update some buttons behave differently2024-03-26T14:48:07ZPiotrek ZadrogaAfter PrimeNG update some buttons behave differentlyFor example, Machines list view - Authorized and Unauthorized buttons work like toggles now. 2 consecutive clicks on Unauthorized toggles active/non-active state of the button, and the list itself shows different data.
![image](/uploads...For example, Machines list view - Authorized and Unauthorized buttons work like toggles now. 2 consecutive clicks on Unauthorized toggles active/non-active state of the button, and the list itself shows different data.
![image](/uploads/19aefedb53d49f7863cd891a01f5631c/image.png)
![image](/uploads/109a5db2e701ab2e044ef08c6b6ca0f8/image.png)1.17https://gitlab.isc.org/isc-projects/stork/-/issues/1310BIND 9 returns poor statistics if the bind-dyndb-ldap plugin2024-03-05T14:39:31ZSlawek FigielBIND 9 returns poor statistics if the bind-dyndb-ldap pluginThe issue was reported on [our mailing list](https://lists.isc.org/pipermail/stork-dev/2024-February/000049.html).
> on one of the authoritative bind instances, i am using views there
> too, which i might reconsider, i am using the bind...The issue was reported on [our mailing list](https://lists.isc.org/pipermail/stork-dev/2024-February/000049.html).
> on one of the authoritative bind instances, i am using views there
> too, which i might reconsider, i am using the bind-dyndb-ldap plugin
> to host the zone data in ldap, and when i curl for the json/v1 stats
> URL, only get back:
> [brendan@server3 ~]$ curl http://localhost:8053/json/v1/
>
> ```json
> {
> "json-stats-version":"1.7",
> "boot-time":"2024-02-01T09:01:21.914Z",
> "config-time":"2024-02-01T09:01:27.425Z",
> "current-time":"2024-02-06T21:45:33.123Z",
> "version":"9.18.20"
> }
> ```
>
> even though the statistics are configured. it seems the caching
> mechanisms are not being used:
>
> ```
> ++ Cache Statistics ++
> [View: internal (Cache: internal)]
> 0 cache hits
> 0 cache misses
> 0 cache hits (from query)
> 0 cache misses (from query)
> 0 cache records deleted due to memory exhaustion
> 0 cache records deleted due to TTL expiration
> 0 covering nsec returned
> 0 cache database nodes
> 0 cache NSEC auxiliary database nodes
> XX cache database hash buckets
> XXXXXXXXXX cache tree memory total
> XXXXX cache tree memory in use
> 0 cache tree highest memory in use
> XXXXXXXXX cache heap memory total
> XXXX cache heap memory in use
> 0 cache heap highest memory in use
> [View: _bind (Cache: _bind)]
> 0 cache hits
> 0 cache misses
> 0 cache hits (from query)
> 0 cache misses (from query)
> 0 cache records deleted due to memory exhaustion
> 0 cache records deleted due to TTL expiration
> 0 covering nsec returned
> 0 cache database nodes
> 0 cache NSEC auxiliary database nodes
> XX cache database hash buckets
> XXXXX cache tree memory total
> XXXXX cache tree memory in use
> 0 cache tree highest memory in use
> XXXX cache heap memory total
> XXXX cache heap memory in use
> 0 cache heap highest memry in use
> ```
The reported problem prevents Stork agent from forwarding statistics to Prometheus and Stork server.outstandinghttps://gitlab.isc.org/isc-projects/stork/-/issues/1309Support for non-default BIND 9 views2024-03-05T14:37:16ZSlawek FigielSupport for non-default BIND 9 viewsThe issue was reported on [our mailing list](https://lists.isc.org/pipermail/stork-dev/2024-February/000049.html):
> the fact that i use views in my bind config is why there is no data
showing up for one host.
The attached statistics:
...The issue was reported on [our mailing list](https://lists.isc.org/pipermail/stork-dev/2024-February/000049.html):
> the fact that i use views in my bind config is why there is no data
showing up for one host.
The attached statistics:
> ```
> ++ Cache Statistics ++
> [View: internal (Cache: internal)]
> 0 cache hits
> 0 cache misses
> 0 cache hits (from query)
> 0 cache misses (from query)
> 0 cache records deleted due to memory exhaustion
> 0 cache records deleted due to TTL expiration
> 0 covering nsec returned
> 0 cache database nodes
> 0 cache NSEC auxiliary database nodes
> XX cache database hash buckets
> XXXXXXXXXX cache tree memory total
> XXXXX cache tree memory in use
> 0 cache tree highest memory in use
> XXXXXXXXX cache heap memory total
> XXXX cache heap memory in use
> 0 cache heap highest memory in use
> [View: _bind (Cache: _bind)]
> 0 cache hits
> 0 cache misses
> 0 cache hits (from query)
> 0 cache misses (from query)
> 0 cache records deleted due to memory exhaustion
> 0 cache records deleted due to TTL expiration
> 0 covering nsec returned
> 0 cache database nodes
> 0 cache NSEC auxiliary database nodes
> XX cache database hash buckets
> XXXXX cache tree memory total
> XXXXX cache tree memory in use
> 0 cache tree highest memory in use
> XXXX cache heap memory total
> XXXX cache heap memory in use
> 0 cache heap highest memry in use
> ```
> there is no _default zone, which might be due to my use of
> views, or different naming convention (_bind vs _default).
>
> is there a way to tell Stork that i want the stats from the views that
> i am running, or global stats from all views?
Unfortunately, Stork has no possibility to change the BIND 9 view name. The `_default` name is hard-coded in several places.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1308Missing HTTP 404 dedicated page2024-03-05T14:33:42ZSlawek FigielMissing HTTP 404 dedicated pageThe issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434193
It looks like there is no proper 404 handling?
I try to open e.g. `127.0.0.1:8080/random/url` and I get redi...The issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434193
It looks like there is no proper 404 handling?
I try to open e.g. `127.0.0.1:8080/random/url` and I get redirected to home url, but the page body is blank, there is no feedback about redirection/404.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/25290aede3bbe1af07533048cc13a0cd/image.png)backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1307Missing empty placeholder in some tables2024-03-05T14:33:04ZSlawek FigielMissing empty placeholder in some tablesThe issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434139
Some tables don't display feedback about empty data set:
![image](https://gitlab.isc.org/isc-projects/stork/...The issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434139
Some tables don't display feedback about empty data set:
![image](https://gitlab.isc.org/isc-projects/stork/uploads/497ba0f438fff4d1587a392bfe251491/image.png)
Also Total# of subnets is not 0, but nothing is displayed.1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1306Reset subnet pagination on filter2024-03-05T14:32:02ZSlawek FigielReset subnet pagination on filterThe issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434138
Pagination not reset when filtering Subnets by Kea app: ![image](https://gitlab.isc.org/isc-projects/stork/up...The issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434138
Pagination not reset when filtering Subnets by Kea app: ![image](https://gitlab.isc.org/isc-projects/stork/uploads/d75cedb560b9c06590aa8c95ccd96d23/image.png)1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1305Help tip is exceed the viewport2024-03-05T14:30:58ZSlawek FigielHelp tip is exceed the viewportThe issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434131
Minor UI issue - sometimes help tool-tip Header/title is out of view (it happened when I started to resize my...The issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434131
Minor UI issue - sometimes help tool-tip Header/title is out of view (it happened when I started to resize my browser window)
![image](https://gitlab.isc.org/isc-projects/stork/uploads/f3d815e3344748445a4f4ff5164801fc/image.png)1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1304Host reservation list - Reset or re-apply the filter2024-03-05T14:30:07ZSlawek FigielHost reservation list - Reset or re-apply the filterThe issue was found during 1.15 sanity checks by @piotrek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434121 and @slawek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434179
Piotrek wrote:
Yet another ...The issue was found during 1.15 sanity checks by @piotrek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434121 and @slawek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434179
Piotrek wrote:
Yet another issue found in filtered tables. This applies to all tables that use `queryParams` to keep the filter state and use `TabView` / `TabPanel` (most of tables use it).
E.g. for hosts:
* go to any Kea app
* Host Reservations -> button click
* We have filtered hosts only for that Kea app
* Click on a reservation
* Detailed view opens in tab
* Click on Host Reservations tab to go back to Table view
* We see all Host Reservations (filtering by Kea app is cleared). Text input of the filter displays remaining filter by Kea `appId`.
Slawek wrote:
Clicking the first tab on the host page lists all results but keeps the old filter.
Steps to reproduce:
1. Go to the host reservation list
1. Provide any valid value in the filter box
1. Click the first tab titled "Host Reservations"
1. Observe the table contains all host reservations, but the filter box is not empty1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1303BIND 9 generates no events2024-03-28T09:53:37ZSlawek FigielBIND 9 generates no eventsThe issue was found by @slawek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434177
The BIND 9 application generates no events. I think there should be at least a notification about connecting t...The issue was found by @slawek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434177
The BIND 9 application generates no events. I think there should be at least a notification about connecting to the daemon.1.16Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1302Add spacing between subnet tab menu and filter box2024-02-13T14:56:20ZSlawek FigielAdd spacing between subnet tab menu and filter boxThe issue was found by @slawek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434170
There is no spacing between the filter box and menu tab on the subnet list:
![image](https://gitlab.isc.org/i...The issue was found by @slawek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434170
There is no spacing between the filter box and menu tab on the subnet list:
![image](https://gitlab.isc.org/isc-projects/stork/uploads/01e35be142883b9ce9856f237341de07/image.png)backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1301Length of input for lease6-get-by-duid is not validated2024-03-07T12:08:15ZSlawek FigielLength of input for lease6-get-by-duid is not validatedThe issue was found by @andrei during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434113
Searching leases by two-character or four-character words provide warnings.
![image](https://gitlab.isc.org/i...The issue was found by @andrei during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434113
Searching leases by two-character or four-character words provide warnings.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/084c42bee2b770bbb47bad0d3e83212d/image.png)
This is caused by an error response e.g. `[ { "result": 1, "text": "identifier is too short (2), at least 3 is required" } ]` to the `lease6-get-by-duid` command. This could be avoided by having Stork check this requirement up front and prevent the command from being sent, as it does with other input. As the comment in `lease.go` says
> // Kea does not accept empty DUIDs. Empty DUID in Kea is represented by 1 zero byte (Kea < 2.3.8) or 3 zero bytes (Kea >= 2.3.8).\`
The current situation can be confusing to a user trying to determine why an even number of characters and bytes is more problematic than an odd number of characters which is checked upfront by Stork.1.16Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1300Check the minimum Java version in build system and describe it in docs2024-02-13T14:52:11ZSlawek FigielCheck the minimum Java version in build system and describe it in docsThe issue was found by @marcin during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434164
The current version of the OpenAPI generator requires at least OpenJRE 11. The build system checks only if the...The issue was found by @marcin during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434164
The current version of the OpenAPI generator requires at least OpenJRE 11. The build system checks only if the `java` binary is present and the documentation specifies that Java is required without providing a minimum version.
We should somehow cover the java requirement checks in the rake files or/and the docs.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1299CIDR on the subnet bar shouldn't be word-breakable2024-03-27T15:47:26ZSlawek FigielCIDR on the subnet bar shouldn't be word-breakableThe issue was found by @marcin during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434279
The size of the subnet prefix column for v6 is broken
![Zrzut_ekranu_2024-02-6_o_20.27.13](https://gitlab.isc...The issue was found by @marcin during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434279
The size of the subnet prefix column for v6 is broken
![Zrzut_ekranu_2024-02-6_o_20.27.13](https://gitlab.isc.org/isc-projects/stork/uploads/080a509020d7ab72abb6e5e3d9838a59/Zrzut_ekranu_2024-02-6_o_20.27.13.png)1.16Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/1298Coherent color scheme2024-02-13T14:50:02ZAndrei Pavelandrei@isc.orgCoherent color schemeStork has a blue-centered color scheme, but occassionally you see a gray background color reminiscent of Windows 95. It looks out of place. The color scheme could be more coherent.Stork has a blue-centered color scheme, but occassionally you see a gray background color reminiscent of Windows 95. It looks out of place. The color scheme could be more coherent.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1297Keep the list of tested systems in ARM up to date2024-02-13T14:42:14ZAndrei Pavelandrei@isc.orgKeep the list of tested systems in ARM up to dateNeed a methodology for keeping this list up to date, which currently has both EOL systems and systems that we are not testing anything on.
> Stork is tested on the following systems:
>
> - Ubuntu 18.04 and 20.04
> - Fedora 31 and 32
> -...Need a methodology for keeping this list up to date, which currently has both EOL systems and systems that we are not testing anything on.
> Stork is tested on the following systems:
>
> - Ubuntu 18.04 and 20.04
> - Fedora 31 and 32
> - CentOS 8
> - MacOS 11.3*1.16