stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2024-03-28T09:04:35Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/13471.15.1 Clean up2024-03-28T09:04:35ZMarcin Godzina1.15.1 Clean upThings to do after 1.15.1 release:
- [ ] Move private code to public repository
- [ ] Mark [Tag](https://gitlab.isc.org/isc-projects/stork/-/tags) and [Release](https://gitlab.isc.org/isc-projects/stork/-/releases) in Repository
- [ ] R...Things to do after 1.15.1 release:
- [ ] Move private code to public repository
- [ ] Mark [Tag](https://gitlab.isc.org/isc-projects/stork/-/tags) and [Release](https://gitlab.isc.org/isc-projects/stork/-/releases) in Repository
- [ ] Rebuild Read The Docks (It can not pull from a private repository.)
- [ ] Fix `upload_to_repo` and `upload_to_repo_hooks` jobs/runners problem https://gitlab.isc.org/isc-projects/stork/-/issues/1348 https://gitlab.isc.org/isc-projects/stork/-/issues/13121.16https://gitlab.isc.org/isc-projects/stork/-/issues/1341Add a reference from the Stork ARM to the KB on how to generate the certifica...2024-03-28T10:29:47ZMarcin SiodelskiAdd a reference from the Stork ARM to the KB on how to generate the certificates?We have created KB on how to generate and import the certificates to Stork. I wonder if we maybe need to give a link from the Stork ARM to this article?We have created KB on how to generate and import the certificates to Stork. I wonder if we maybe need to give a link from the Stork ARM to this article?1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1322Upgrade Grafana and its dashboards2024-03-05T15:02:12ZSlawek FigielUpgrade Grafana and its dashboardsYou cannot import the example Grafana dashboards to a modern Grafana instance.
![image](/uploads/a95f33a1aa876ae18d92057fd933fc5f/image.png)
The Stork demo uses the `8.3.7` Grafana version. The latest version is `10.3.3`.
We should up...You cannot import the example Grafana dashboards to a modern Grafana instance.
![image](/uploads/a95f33a1aa876ae18d92057fd933fc5f/image.png)
The Stork demo uses the `8.3.7` Grafana version. The latest version is `10.3.3`.
We should upgrade the Grafana (and maybe Prometheus) used in the demo and migrate the example dashboards to a modern format.1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1320Duplicated rows in the service table2024-02-28T16:28:53ZSlawek FigielDuplicated rows in the service tableThe problem was reported [on the Stork-users mailing list](https://lists.isc.org/pipermail/stork-users/2024-February/000245.html).
The `service` table rows may be duplicated on some unknown conditions. It causes the HA status displayed ...The problem was reported [on the Stork-users mailing list](https://lists.isc.org/pipermail/stork-users/2024-February/000245.html).
The `service` table rows may be duplicated on some unknown conditions. It causes the HA status displayed on the Dashboard to diverge from the status presented on the application page.
The user reports that the problem occurs in Stork 1.15 but was also observed in the previous versions. The first installed version was 1.12.
Stork was installed long after configuring HA in Kea.
It seems the same problem was reported in #616 and #818.
We should check if the problem were fixed correctly in 1.7 and if the invalid table state may preserved from the previous versions.
We should also analyze if adding the unique constraint on the `service` table would be beneficial to avoid similar issues.1.16Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1319Package issues during update2024-03-28T13:33:54ZDarren AnkneyPackage issues during updateIt was found that when updating to Stork 1.15.0 (in this case from 1.14.0) on RHEL 7 (and CentOS 7 though engineering states that this problem likely applies to all versions) that there are two problems encountered:
1. The Stork Server ...It was found that when updating to Stork 1.15.0 (in this case from 1.14.0) on RHEL 7 (and CentOS 7 though engineering states that this problem likely applies to all versions) that there are two problems encountered:
1. The Stork Server service ends up stopped in the disabled state even though it was enabled and started prior to update.
2. The `useradd` call in the postinstall script sets the homedir to `/var/lib` instead of `/var/lib/stork-server`.
A patch was provided by the reporter:
```
diff --git a/etc/hooks/rpm/isc-stork-server.postinst b/etc/hooks/rpm/isc-stork-server.postinst
index 3b890b75..7833efd4 100644
--- a/etc/hooks/rpm/isc-stork-server.postinst
+++ b/etc/hooks/rpm/isc-stork-server.postinst
@@ -4,5 +4,5 @@ set -eu
# add stork-server user if does not exist
if ! getent passwd stork-server > /dev/null; then
- useradd --system --home-dir /var/lib/ stork-server
+ useradd --system --base-dir /var/lib/ stork-server
fi
diff --git a/etc/hooks/rpm/isc-stork-server.prerm b/etc/hooks/rpm/isc-stork-server.prerm
index e4649e2c..cc007fbc 100644
--- a/etc/hooks/rpm/isc-stork-server.prerm
+++ b/etc/hooks/rpm/isc-stork-server.prerm
@@ -1,16 +1,17 @@
#!/bin/sh
set -eu
-
-has_active_systemd=0
-if command -v systemctl > /dev/null; then
- status=$(systemctl is-system-running || true)
- if [ "${status}" = "running" ] || [ "${status}" = "degraded" ] || [ "${status}" = "maintenance" ]; then
- has_active_systemd=1
+if [ "$1" -eq 0 ]; then # Uninstall == 0 not Upgrade == 1
+ has_active_systemd=0
+ if command -v systemctl > /dev/null; then
+ status=$(systemctl is-system-running || true)
+ if [ "${status}" = "running" ] || [ "${status}" = "degraded" ] || [ "${status}" = "maintenance" ]; then
+ has_active_systemd=1
+ fi
fi
-fi
-if [ $has_active_systemd -eq 1 ]; then
- systemctl disable isc-stork-server
- systemctl stop isc-stork-server
-fi
+ if [ $has_active_systemd -eq 1 ]; then
+ systemctl disable isc-stork-server
+ systemctl stop isc-stork-server
+ fi
+fi
```
[SF1727](https://isc.lightning.force.com/lightning/r/Case/500S6000005dJugIAE/view)1.16Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1318Change database for migrating hosts2024-03-12T08:19:13ZSlawek FigielChange database for migrating hostsBelow is our current database schema:
![image](/uploads/6ff3034985b96c7a7c984478bb4ff11d/image.png)
In this structure, it is impossible to recognize which Kea daemon holds a specific IP or hostname reservation.
So, we don't know on whi...Below is our current database schema:
![image](/uploads/6ff3034985b96c7a7c984478bb4ff11d/image.png)
In this structure, it is impossible to recognize which Kea daemon holds a specific IP or hostname reservation.
So, we don't know on which Kea daemon perform the migration.
I want to make the below changes:
- Replace the `ip_reservation` table's reference to `host` table with reference to `local_host`.
- Move the `hostname` column from `host` to `local_host` table
- (Optionally) Add a single-column primary key to the `local_host` table and add a unique index on the `host_id`, `data_source`, and `daemon_id` to preserve the existing constraints.1.16Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1313Incorrect default *.env file.2024-02-27T09:52:35ZAndreas JentschIncorrect default *.env file.---
name: Bug report
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. Please use https://www.isc.org/community/report-bug/...---
name: Bug report
about: Create a report to help us improve
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT
REPORT IT HERE. Please use https://www.isc.org/community/report-bug/ instead or send mail to
security-office(at)isc(dot)org.
**Describe the bug**
If you start the agent with the following command, this output is generated.
/usr/bin/stork-agent --use-env-file
FATA[2024-02-08 10:39:55] main.go:406 invalid environment file: '/etc/stork/server.env': ...
**To Reproduce**
Steps to reproduce the behavior:
1. /usr/bin/stork-agent --env-file '/etc/stork/agent.env' --use-env-file
**Expected behavior**
You should adjust the default value for the .*env file.
**Environment:**
/usr/bin/stork-agent -v
1.15.0
Static hostname: dhcp-01-xgs.glattnet.ch
Icon name: computer-server
Chassis: server 🖳
Machine ID: cf6ef911a0974dbfa031e35e8f775125
Boot ID: 96edd982af2d4745a030003205e7fae2
Operating System: Rocky Linux 9.3 (Blue Onyx)
CPE OS Name: cpe:/o:rocky:rocky:9::baseos
Kernel: Linux 5.14.0-362.18.1.el9_3.x86_64
Architecture: x86-64
Hardware Vendor: HPE
Hardware Model: ProLiant DL360 Gen10
Firmware Version: U32
- Kea version: 2.2.0
tarball
linked with:
log4cplus 2.0.5
OpenSSL 3.0.7 1 Nov 2022
database:
MySQL backend 14.0, library 3.2.6
PostgreSQL backend 13.0, library 130013
Memfile backend 2.1
- Stork: 1.15.0
- OS: Rocky Linux 9.3 (Blue Onyx)
- Kea: Which features were compiled in (in particular which backends)
- Kea: If/which hooks where loaded in
**Contacting you**
E-Mail1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1312Follow-up from the 1.15 release2024-03-28T13:47:02ZAndrei Pavelandrei@isc.orgFollow-up from the 1.15 releaseIssues with the release that need to be fixed:
- The `upload_to_repo` job was not able to trigger any gitlab runner after the migration in issue 1170. The job has too many tags. Removing `stork-repo` or `aws` would solve the impasse.
- ...Issues with the release that need to be fixed:
- The `upload_to_repo` job was not able to trigger any gitlab runner after the migration in issue 1170. The job has too many tags. Removing `stork-repo` or `aws` would solve the impasse.
- The release notes are currently folded at 73 characters. This includes folding changelog entryes. There seems to be a gentleman's agreement that changelog entries should be capped at 80 characters. This makes the changelog in the release notes less readable than it could be. Look at the [1.14 release notes](https://downloads.isc.org/isc/stork/1.14.0/Stork-1.14.0-ReleaseNotes.txt) for example. This has been manually fixed for 1.15, but extending the folding to 80 would be good. A lint step in CI to make sure this rule is respected for changelog entries wouldn't hurt either.
-1.16Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/1307Missing empty placeholder in some tables2024-03-28T15:39:46ZSlawek FigielMissing empty placeholder in some tablesThe issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434139
Some tables don't display feedback about empty data set:
![image](https://gitlab.isc.org/isc-projects/stork/...The issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434139
Some tables don't display feedback about empty data set:
![image](https://gitlab.isc.org/isc-projects/stork/uploads/497ba0f438fff4d1587a392bfe251491/image.png)
Also Total# of subnets is not 0, but nothing is displayed.1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1306Reset subnet pagination on filter2024-03-05T14:32:02ZSlawek FigielReset subnet pagination on filterThe issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434138
Pagination not reset when filtering Subnets by Kea app: ![image](https://gitlab.isc.org/isc-projects/stork/up...The issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434138
Pagination not reset when filtering Subnets by Kea app: ![image](https://gitlab.isc.org/isc-projects/stork/uploads/d75cedb560b9c06590aa8c95ccd96d23/image.png)1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1305Help tip is exceed the viewport2024-03-28T15:29:13ZSlawek FigielHelp tip is exceed the viewportThe issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434131
Minor UI issue - sometimes help tool-tip Header/title is out of view (it happened when I started to resize my...The issue was found by @piotrek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434131
Minor UI issue - sometimes help tool-tip Header/title is out of view (it happened when I started to resize my browser window)
![image](https://gitlab.isc.org/isc-projects/stork/uploads/f3d815e3344748445a4f4ff5164801fc/image.png)1.16Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/1304Host reservation list - Reset or re-apply the filter2024-03-05T14:30:07ZSlawek FigielHost reservation list - Reset or re-apply the filterThe issue was found during 1.15 sanity checks by @piotrek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434121 and @slawek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434179
Piotrek wrote:
Yet another ...The issue was found during 1.15 sanity checks by @piotrek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434121 and @slawek: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434179
Piotrek wrote:
Yet another issue found in filtered tables. This applies to all tables that use `queryParams` to keep the filter state and use `TabView` / `TabPanel` (most of tables use it).
E.g. for hosts:
* go to any Kea app
* Host Reservations -> button click
* We have filtered hosts only for that Kea app
* Click on a reservation
* Detailed view opens in tab
* Click on Host Reservations tab to go back to Table view
* We see all Host Reservations (filtering by Kea app is cleared). Text input of the filter displays remaining filter by Kea `appId`.
Slawek wrote:
Clicking the first tab on the host page lists all results but keeps the old filter.
Steps to reproduce:
1. Go to the host reservation list
1. Provide any valid value in the filter box
1. Click the first tab titled "Host Reservations"
1. Observe the table contains all host reservations, but the filter box is not empty1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1303BIND 9 generates no events2024-03-28T12:11:05ZSlawek FigielBIND 9 generates no eventsThe issue was found by @slawek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434177
The BIND 9 application generates no events. I think there should be at least a notification about connecting t...The issue was found by @slawek during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434177
The BIND 9 application generates no events. I think there should be at least a notification about connecting to the daemon.1.16Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1301Length of input for lease6-get-by-duid is not validated2024-03-28T12:24:48ZSlawek FigielLength of input for lease6-get-by-duid is not validatedThe issue was found by @andrei during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434113
Searching leases by two-character or four-character words provide warnings.
![image](https://gitlab.isc.org/i...The issue was found by @andrei during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434113
Searching leases by two-character or four-character words provide warnings.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/084c42bee2b770bbb47bad0d3e83212d/image.png)
This is caused by an error response e.g. `[ { "result": 1, "text": "identifier is too short (2), at least 3 is required" } ]` to the `lease6-get-by-duid` command. This could be avoided by having Stork check this requirement up front and prevent the command from being sent, as it does with other input. As the comment in `lease.go` says
> // Kea does not accept empty DUIDs. Empty DUID in Kea is represented by 1 zero byte (Kea < 2.3.8) or 3 zero bytes (Kea >= 2.3.8).\`
The current situation can be confusing to a user trying to determine why an even number of characters and bytes is more problematic than an odd number of characters which is checked upfront by Stork.1.16Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1299CIDR on the subnet bar shouldn't be word-breakable2024-03-28T12:19:45ZSlawek FigielCIDR on the subnet bar shouldn't be word-breakableThe issue was found by @marcin during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434279
The size of the subnet prefix column for v6 is broken
![Zrzut_ekranu_2024-02-6_o_20.27.13](https://gitlab.isc...The issue was found by @marcin during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434279
The size of the subnet prefix column for v6 is broken
![Zrzut_ekranu_2024-02-6_o_20.27.13](https://gitlab.isc.org/isc-projects/stork/uploads/080a509020d7ab72abb6e5e3d9838a59/Zrzut_ekranu_2024-02-6_o_20.27.13.png)1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1297Keep the list of tested systems in ARM up to date2024-02-13T14:42:14ZAndrei Pavelandrei@isc.orgKeep the list of tested systems in ARM up to dateNeed a methodology for keeping this list up to date, which currently has both EOL systems and systems that we are not testing anything on.
> Stork is tested on the following systems:
>
> - Ubuntu 18.04 and 20.04
> - Fedora 31 and 32
> -...Need a methodology for keeping this list up to date, which currently has both EOL systems and systems that we are not testing anything on.
> Stork is tested on the following systems:
>
> - Ubuntu 18.04 and 20.04
> - Fedora 31 and 32
> - CentOS 8
> - MacOS 11.3*1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1293UI code coverage2024-02-13T14:38:49ZSlawek FigielUI code coverageWe have a utility to generate coverage for the backend but not for the frontend. We should fill this gap.
The development of this feature was excluded from #800.We have a utility to generate coverage for the backend but not for the frontend. We should fill this gap.
The development of this feature was excluded from #800.1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1278Backend profiler and performance monitor2024-01-16T14:43:02ZSlawek FigielBackend profiler and performance monitorTo improve the quality of our solutions, I propose to add to the Stork project the following:
- Profiler for the backend unit tests
- On-demand profiler for currently executed Stork server or agent
- Performance monitor for system tests...To improve the quality of our solutions, I propose to add to the Stork project the following:
- Profiler for the backend unit tests
- On-demand profiler for currently executed Stork server or agent
- Performance monitor for system tests
These components were implemented to recognize the cause of the performance problems reported in #1263.1.16https://gitlab.isc.org/isc-projects/stork/-/issues/1276github-friendly security policy2024-01-16T14:41:55ZTomek Mrugalskigithub-friendly security policyThis is mostly to check off some extra check boxes on github.
Something similar as we have in Kea: [Kea security policy](https://github.com/isc-projects/kea/security/policy).
This is just writing down what we already have spread out in...This is mostly to check off some extra check boxes on github.
Something similar as we have in Kea: [Kea security policy](https://github.com/isc-projects/kea/security/policy).
This is just writing down what we already have spread out in several places, condensed and formatted in github friendly format. No specific process changes proposed.1.16Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1275Password change fails with character '+' that form states is allowable2024-01-16T14:41:07ZBaxil (aka Horizon)Password change fails with character '+' that form states is allowable
**Description**
Stork will refuse to validate passwords using the plus sign, one of the characters the password change screen explicitly states is an allowed special character.
**To Reproduce**
1. visit /profile/password page for passw...
**Description**
Stork will refuse to validate passwords using the plus sign, one of the characters the password change screen explicitly states is an allowed special character.
**To Reproduce**
1. visit /profile/password page for password change
2. In both password and confirm password boxes type: abc+123
3. Password box will error out with an allowed characters message and confirm box will error out stating passwords don't match
![20240109-stork-passwords](/uploads/76d84e097f9c19cc31850f9bc204c36e/20240109-stork-passwords.png)
**Expected behavior**
Any characters which cause password processing errors should be removed from acceptable character lists.
**Environment:**
- Stork: 1.14.0
- OS: unknown, my apologies (I'm an end user)
- Kea version: unknown
- BIND9 version: unknown
**Additional Information**
This is possibly related to issue #1246 if the db password is processed in the same fashion.1.16