1. 10 Oct, 2019 21 commits
    • Thomas Markwalder's avatar
      [#35,!517] Updated ChangeLog · ac0bbcf6
      Thomas Markwalder authored
      ac0bbcf6
    • Thomas Markwalder's avatar
      [#35,!517] Addressed final review comments · 49ce6286
      Thomas Markwalder authored
      src/lib/dhcpsrv/parsers/simple_parser4.cc
      src/lib/dhcpsrv/parsers/simple_parser6.cc
          Fixed indentations in defaults list
      49ce6286
    • Francis Dupont's avatar
      8a63e7c0
    • Francis Dupont's avatar
    • Francis Dupont's avatar
    • Francis Dupont's avatar
    • Thomas Markwalder's avatar
      [#35,!517] Addressed review comments · 7cfc5d3f
      Thomas Markwalder authored
      Addressed a myriad of minor typos and wording issues.
      
      modified:
      ChangeLog
      doc/examples/kea4/all-keys.json
      doc/examples/kea6/all-keys.json
      doc/sphinx/arm/dhcp4-srv.rst
      doc/sphinx/arm/dhcp6-srv.rst
      src/bin/dhcp4/dhcp4_srv.cc
      src/bin/dhcp4/tests/config_parser_unittest.cc
      src/bin/dhcp4/tests/fqdn_unittest.cc
      src/bin/dhcp6/tests/config_parser_unittest.cc
      src/bin/dhcp6/tests/d2_unittest.cc
      src/bin/dhcp6/tests/fqdn_unittest.cc
      src/lib/dhcpsrv/alloc_engine.cc
      src/lib/dhcpsrv/alloc_engine.h
      src/lib/dhcpsrv/d2_client_cfg.h
      src/lib/dhcpsrv/parsers/base_network_parser.cc
      src/lib/dhcpsrv/srv_config.h
      7cfc5d3f
    • Francis Dupont's avatar
    • Thomas Markwalder's avatar
      [#35,!517] Updated ARM and example confings · 4ac6e5b9
      Thomas Markwalder authored
      Updated:
          doc/examples/kea4/all-keys.json
          doc/examples/kea4/with-ddns.json
          doc/examples/kea6/all-keys.json
          doc/sphinx/arm/dhcp4-srv.rst
          doc/sphinx/arm/dhcp6-srv.rst
      
      Added ChangeLogEntry
      4ac6e5b9
    • Thomas Markwalder's avatar
      [#35,!517] Removed ddns params from INHERIT_TO_SUBNETX lists · 1f60cb9d
      Thomas Markwalder authored
      src/bin/dhcp4/tests/get_config_unittest.cc
      src/bin/dhcp6/tests/get_config_unittest.cc
          regenerated tests
      
      src/lib/dhcpsrv/parsers/simple_parser4.cc
          Removed DDNS params from INHERIT_TO_SUBNET4 list
      
      src/lib/dhcpsrv/parsers/simple_parser6.cc
          Removed DDNS params from INHERIT_TO_SUBNET6 list
      1f60cb9d
    • Thomas Markwalder's avatar
      [#35,!517] Added v6 scope test · f5179e12
      Thomas Markwalder authored
      src/bin/dhcp6/tests/fqdn_unittest.cc
          TEST_F(FqdnDhcpv6SrvTest, ddnsScopeTest)  - new test
      f5179e12
    • Thomas Markwalder's avatar
      [#35,!517] Rework kea-dhcp6 parsing and server · ce14110b
      Thomas Markwalder authored
      src/bin/dhcp6/ctrl_dhcp6_srv.cc
          Removed setting D2ClientCfg fetch function
      
      src/bin/dhcp6/dhcp6_lexer.ll
      src/bin/dhcp6/dhcp6_parser.yy
          ddns-send-updates
          ddns-override-no-update
          ddns-override-client-update
          ddns-replace-client-name
          ddns-generated-prefix
          ddns-qualifying-suffix
          - added to DHCP4,SHARED_NETWORK,SUBNET4
      
          hostname-char-set
          hostname-char-replacement
          - added to SHARED_NETWORK,SUBNET4
      
      src/bin/dhcp6/dhcp6_srv.cc
          Dhcpv6Srv::processClientFqdn()
          Dhcpv6Srv::createNameChangeRequests()
          Dhcpv6Srv::updateReservedFqdn()
          - use cxt.getDdnsParams()
      
      src/bin/dhcp6/json_config_parser.cc
          configureDhcp6Server()
          - use SrvConfig::moveDdnsParams() to move dhcp-ddns parameters
          - handle new "ddns-" globals
      
      src/bin/dhcp6/tests/config_parser_unittest.cc
      src/bin/dhcp6/tests/fqdn_unittest.cc
      src/bin/dhcp6/tests/get_config_unittest.cc
          Updated tests
      ce14110b
    • Thomas Markwalder's avatar
      [#35,!517] Rework kea-dhcp4 parsing and server · 256feda6
      Thomas Markwalder authored
      src/bin/dhcp4/ctrl_dhcp4_srv.cc
          Removed setting D2ClientCfg fetch function
      
      src/bin/dhcp4/dhcp4_lexer.ll
      src/bin/dhcp4/dhcp4_parser.yy
          ddns-send-updates
          ddns-override-no-update
          ddns-override-client-update
          ddns-replace-client-name
          ddns-generated-prefix
          ddns-qualifying-suffix
              - added to DHCP4,SHARED_NETWORK,SUBNET4
      
          hostname-char-set
          hostname-char-replacement
              - added to SHARED_NETWORK,SUBNET4
      
      src/bin/dhcp4/dhcp4_srv.cc
      
          Dhcpv4Srv::processClientFqdnOption()
          Dhcpv4Srv::processHostnameOption()
          Dhcpv4Srv::assignLease()
              Use scoped DdnsParams from context to make decisions, pass
              into D2ClientMgr functions, and supply hostname sanitizer
      
      src/bin/dhcp4/json_config_parser.cc
          configureDhcp4Server()
          - use SrvConfig::moveDdnsParams() to move dhcp-ddns parameters
          - handle new "ddns-" globals
      
      src/bin/dhcp4/tests/config_parser_unittest.cc
      src/bin/dhcp4/tests/d2_unittest.cc
      src/bin/dhcp4/tests/dhcp4_test_utils.cc
      src/bin/dhcp4/tests/fqdn_unittest.cc
      src/bin/dhcp4/tests/get_config_unittest.cc
          Updated and new tests
      256feda6
    • Thomas Markwalder's avatar
      [#35,!517] Added getDdnsParams() to AllocEngine::ClientContext4/6 · 77cfe4bc
      Thomas Markwalder authored
      src/lib/dhcpsrv/alloc_engine.*
          AllocEngine::ClientContext6::getDdnsParams()
          AllocEngine::ClientContext4::getDdnsParams() - new
          methods which return a DdnsParams instance scoped by
          currently selected subnet
      
          Replaced direct references to context::ddns_params_ with
          new getter methods.
      
      src/lib/dhcpsrv/parsers/simple_parser4.cc
      src/lib/dhcpsrv/parsers/simple_parser6.cc
          Removed global defaults for hostname-char-set/replacement
      77cfe4bc
    • Thomas Markwalder's avatar
      [#35,!517] Changed moveDdnsParams to modify element map instead of SrvConfig · 6d6a3eed
      Thomas Markwalder authored
      Moving the parameters needs to be done before defaults are applied to the
      config, so moveDdnsParams was changed to modify a mutable top level
      element map instead of SrvConfig contents.
      
      src/lib/dhcpsrv/parsers/simple_parser4.cc
      src/lib/dhcpsrv/parsers/simple_parser6.cc
          Change ddns-send-updates default to true.
      
      src/lib/dhcpsrv/srv_config.*
          SrvConfig::getConfiguredGlobal() - new method to fetch a
          global by name
      
          SrvConfig::moveDdnsParams() - changed to accept/modify
          a top-level Element map
      
      src/lib/dhcpsrv/tests/srv_config_unittest.cc
          updated unit tests accordingly
      6d6a3eed
    • Thomas Markwalder's avatar
      [#35,!517] Added function to move of DDNS cfg elements to global scope to SrvConfig · d3eda7f2
      Thomas Markwalder authored
      src/lib/dhcpsrv/dhcpsrv_messages.*
          DHCPSRV_CFGMGR_DDNS_PARAMETER_IGNORED
          DHCPSRV_CFGMGR_DDNS_PARAMETER_MOVED
      
      src/lib/dhcpsrv/srv_config.*
          SrvConfig::moveDdnsParams() - new method to move
          parameters from dhcp-ddns to configured globals.
      
      src/lib/dhcpsrv/tests/srv_config_unittest.cc
          TEST_F(SrvConfigTest, moveDdnsParamsTest) - new test
      d3eda7f2
    • Thomas Markwalder's avatar
      [#35,!517] Added hostname-char-set to hostname-char-replacement network/subnet scopes · 590767d4
      Thomas Markwalder authored
      src/lib/dhcpsrv/d2_client_cfg.*
          Added hostname-char-set and hostname-char-replacement to DdnsParms
          DdnsParams::getHostnameSanitizer()  - new function to return a sanitizer
      
      src/lib/dhcpsrv/d2_client_mgr.h
          D2ClientMgr::adjustDomainName() - now gets sanitizer from ddns_params
      
      src/lib/dhcpsrv/network.*
      src/lib/dhcpsrv/parsers/base_network_parser.cc
      src/lib/dhcpsrv/parsers/simple_parser4.cc
      src/lib/dhcpsrv/parsers/simple_parser6.cc
          Added hostname-char-set and hostname-char-replacement to networks and subnets
      590767d4
    • Thomas Markwalder's avatar
      [#35,!517] Added fetch of scoped DDNS parameters to SrvConfig · f0d9fef2
      Thomas Markwalder authored
      src/lib/dhcpsrv/srv_config.*
          SrvConfig::getDdnsParams() - new method to fetch
          scoped DDNS parameters based on a given subnet
      
      src/lib/dhcpsrv/tests/srv_config_unittest.cc
          TEST_F(SrvConfigTest, getDdnsParamsTest4)
          TEST_F(SrvConfigTest, getDdnsParamsTest6) - new tests
      f0d9fef2
    • Thomas Markwalder's avatar
      [#35,!517] Added DDDNS parameters to networks,subnets, and their parsers · e782a9d5
      Thomas Markwalder authored
      src/lib/dhcpsrv/network.*
          Network - added DDNS parameters: Optional members, getters, setters
          Network::toElement() - added DDNS parameters
      
      src/lib/dhcpsrv/parsers/base_network_parser.*
          BaseNetworkParser::parseDdnsParams() - new method to parse DDNS parameters
      
          BaseNetworkParser::parseLifetime() - fixed unitialized variables warning
      
      src/lib/dhcpsrv/parsers/dhcp_parsers.cc
          Subnet4ConfigParser::initSubnet()
          Subnet6ConfigParser::initSubnet()  - added call to parseDdnsParms().
      
      src/lib/dhcpsrv/parsers/shared_network_parser.cc
          SharedNetwork4Parser::parse()
          SharedNetwork6Parser::parse() - added call to parseDdnsParms().
      
      src/lib/dhcpsrv/parsers/simple_parser4.cc
          SimpleParser4::GLOBAL4_PARAMETERS
          SimpleParser4::GLOBAL4_DEFAULTS
          SimpleParser4::SUBNET4_PARAMETERS
          SimpleParser4::INHERIT_TO_SUBNET4
          SimpleParser4::SHARED_NETWORK4_PARAMETERS - added DDNS parameters
      
      src/lib/dhcpsrv/parsers/simple_parser6.cc
          SimpleParser6::GLOBAL6_PARAMETERS
          SimpleParser6::GLOBAL6_DEFAULTS
          SimpleParser6::SUBNET6_PARAMETERS
          SimpleParser6::INHERIT_TO_SUBNET6
          SimpleParser6::SHARED_NETWORK6_PARAMETERS - added DDNS parameters
      
      src/lib/dhcpsrv/tests/cfg_shared_networks4_unittest.cc
      src/lib/dhcpsrv/tests/cfg_shared_networks6_unittest.cc
      src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
      src/lib/dhcpsrv/tests/network_unittest.cc
      src/lib/dhcpsrv/tests/shared_network_parser_unittest.cc
      src/lib/dhcpsrv/tests/shared_network_unittest.cc
      src/lib/dhcpsrv/tests/subnet_unittest.cc
          Updated tests.
      e782a9d5
    • Thomas Markwalder's avatar
      [#35,!517] Removed DDNS params from D2ClientCfg and tests · 4f57cfa2
      Thomas Markwalder authored
      src/lib/dhcpsrv/d2_client_cfg.*
          D2ClientConfig - removed DDNS params
      
      src/lib/dhcpsrv/parsers/dhcp_parsers.cc
          D2ClientConfigParser::parse() - removed DDNS params
      
      src/lib/dhcpsrv/parsers/simple_parser4.cc
          SimpleParser4::GLOBAL4_PARAMETERS
          SimpleDefaults SimpleParser4::GLOBAL4_DEFAULTS
          - added DDSN params
      
      src/lib/dhcpsrv/tests/cfgmgr_unittest.cc
          Updated calls to D2ClientCfg ctor
      
      src/lib/dhcpsrv/tests/d2_client_unittest.cc
          Removed DDNS and hostname params from tests
      
      src/lib/dhcpsrv/tests/d2_udp_unittest.cc
          Updated calls to D2ClientCfg ctor
      
      src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
          Removed DDNS and hostname params from tests
      4f57cfa2
    • Thomas Markwalder's avatar
      [#35,!517] Modify D2ClientMgr functions to accept DdnsParams parameter · b767f944
      Thomas Markwalder authored
      D2ClientMgr functions now get behavior parameters from a passed in
      structure instead of D2ClientMgr::d2_client_config_.
      
      src/lib/dhcpsrv/d2_client_cfg.h
          struct DdnsParams  - new structure to convey request specific
          (i.e.scopable) Ddns params
      
      src/lib/dhcpsrv/alloc_engine.cc
      src/lib/dhcpsrv/alloc_engine.h
          Added ddns_params_ to ClientContext4/6
      
      src/lib/dhcpsrv/d2_client_mgr.*
          D2ClientMgr::adjustFqdnFlags()
          D2ClientMgr::adjustDomainName()
          D2ClientMgr::analyzeFqdn()
          D2ClientMgr::generateFqdn()
          D2ClientMgr::qualifyName() - now accept DdnsParams instance as
          parameter
      
      src/lib/dhcpsrv/tests/d2_client_unittest.cc
          Reworked tests to use DdnsParams
      b767f944
  2. 07 Oct, 2019 1 commit
  3. 01 Oct, 2019 1 commit
  4. 30 Sep, 2019 1 commit
  5. 27 Sep, 2019 10 commits
  6. 26 Sep, 2019 6 commits