Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Sebastian Schrader
Kea
Commits
04f940ed
Commit
04f940ed
authored
Aug 16, 2013
by
Marcin Siodelski
Browse files
[3082] Added cppcheck suppression for the enum to be passed by reference.
parent
33edd2ed
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/lib/dhcp/option4_client_fqdn.cc
View file @
04f940ed
...
...
@@ -127,6 +127,11 @@ Option4ClientFqdnImpl::
Option4ClientFqdnImpl
(
const
uint8_t
flags
,
const
Option4ClientFqdn
::
Rcode
&
rcode
,
const
std
::
string
&
domain_name
,
// cppcheck 1.57 complains that const enum value is not passed
// by reference. Note that, it accepts the non-const enum value
// to be passed by value. In both cases it is unneccessary to
// pass the enum by reference.
// cppcheck-suppress passedByValue
const
Option4ClientFqdn
::
DomainNameType
name_type
)
:
flags_
(
flags
),
rcode1_
(
rcode
),
...
...
@@ -189,6 +194,11 @@ Option4ClientFqdnImpl::operator=(const Option4ClientFqdnImpl& source) {
void
Option4ClientFqdnImpl
::
setDomainName
(
const
std
::
string
&
domain_name
,
// cppcheck 1.57 complains that const enum value is not passed
// by reference. Note that, it accepts the non-const enum
// to be passed by value. In both cases it is unneccessary to
// pass the enum by reference.
// cppcheck-suppress passedByValue
const
Option4ClientFqdn
::
DomainNameType
name_type
)
{
// domain-name must be trimmed. Otherwise, string comprising spaces only
// would be treated as a fully qualified name.
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment