Commit 3f9c7bb8 authored by Jelte Jansen's avatar Jelte Jansen
Browse files

[2445] Remove setLogLevel(TRACE) in createBufferAppender

This has a chance that some log messages get lost (DEBUG messages during startup in case -v is not given but the config has DEBUG set)
parent 0a9dafbe
...@@ -145,9 +145,6 @@ LoggerManagerImpl::createBufferAppender(log4cplus::Logger& logger) { ...@@ -145,9 +145,6 @@ LoggerManagerImpl::createBufferAppender(log4cplus::Logger& logger) {
log4cplus::SharedAppenderPtr bufferapp(new internal::BufferAppender()); log4cplus::SharedAppenderPtr bufferapp(new internal::BufferAppender());
bufferapp->setName("buffer"); bufferapp->setName("buffer");
logger.addAppender(bufferapp); logger.addAppender(bufferapp);
// Since we do not know at what level the loggers will end up
// running, set it to the highest for now
logger.setLogLevel(log4cplus::TRACE_LOG_LEVEL);
} }
// Syslog appender. // Syslog appender.
......
...@@ -22,7 +22,7 @@ using namespace isc::log; ...@@ -22,7 +22,7 @@ using namespace isc::log;
namespace { namespace {
void usage() { void usage() {
std::cout << "Usage: buffer_logger_test [-n]" << std::endl; std::cout << "Usage: buffer_logger_test [-nv]" << std::endl;
} }
} // end unnamed namespace } // end unnamed namespace
...@@ -52,10 +52,10 @@ main(int argc, char** argv) { ...@@ -52,10 +52,10 @@ main(int argc, char** argv) {
} }
} }
// Note, level is INFO, so DEBUG should normally not show // Note, level is set to DEBUG here, but back to INFO
// up. Unless process is never called (at which point it // in process(), so when flushing to stdout (-n), the DEBUG
// will end up in the dump at the end). // message should show up
initLogger("buffertest", isc::log::INFO, 0, NULL, true); initLogger("buffertest", isc::log::DEBUG, 99, NULL, true);
Logger logger("log"); Logger logger("log");
// No need for file interprocess locking in this test // No need for file interprocess locking in this test
logger.setInterprocessSync(new isc::util::InterprocessSyncNull("logger")); logger.setInterprocessSync(new isc::util::InterprocessSyncNull("logger"));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment