Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Sebastian Schrader
Kea
Commits
57a25a01
Commit
57a25a01
authored
Jul 02, 2013
by
Stephen Morris
Browse files
[2980] Changes as a result for the first part of the review
parent
d63e340a
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
src/lib/hooks/callout_handle.cc
View file @
57a25a01
...
...
@@ -52,12 +52,12 @@ CalloutHandle::~CalloutHandle() {
context_collection_
.
clear
();
// Normal destruction of the remaining variables will include the
// destruction of lm_collection_,
w
n action that
will
decrement the
//
reference
count on the library manager collection (which holds the
//
libraries that
could have allocated memory in the argument and context
//
members). When
that goes to zero, the libraries will be unloaded:
//
at that point nothing
in the hooks framework will be pointing to memory
//
in the libraries'
address space.
// destruction of lm_collection_,
a
n action that decrement
s
the
reference
// count on the library manager collection (which holds the
libraries that
// could have allocated memory in the argument and context
members.) When
// that goes to zero, the libraries will be unloaded:
at that point nothing
// in the hooks framework will be pointing to memory
in the libraries'
// address space.
//
// It is possible that some other data structure in the server (the program
// using the hooks library) still references the address space and attempts
...
...
src/lib/hooks/callout_handle.h
View file @
57a25a01
...
...
@@ -80,11 +80,11 @@ class LibraryManagerCollection;
/// "context_destroy" callout. The information is accessed through the
/// {get,set}Context() methods.
///
/// - Per-library handle
. Allows the callout to dynamically register and
/// deregister callouts.
(
In the latter
case, only functions registered by
/// functions in the same library as the
callout doing the deregistration
/// can be removed: callouts registered by
other libraries cannot be
/// modified.
)
/// - Per-library handle
(LibraryHandle). The library handle allows the
///
callout to dynamically register and
deregister callouts. In the latter
///
case, only functions registered by
functions in the same library as the
///
callout doing the deregistration
can be removed: callouts registered by
///
other libraries cannot be
modified.
class
CalloutHandle
{
public:
...
...
src/lib/hooks/hooks_component_developer.dox
View file @
57a25a01
This diff is collapsed.
Click to expand it.
src/lib/hooks/server_hooks.h
View file @
57a25a01
...
...
@@ -151,7 +151,7 @@ private:
///
/// Constructor is declared private to enforce the singleton nature of
/// the object. A reference to the singleton is obtainable through the
///
g
getServerHooks() static method.
/// getServerHooks() static method.
///
/// @throws isc::Unexpected if the registration of the pre-defined hooks
/// fails in some way.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment