Commit 57a25a01 authored by Stephen Morris's avatar Stephen Morris
Browse files

[2980] Changes as a result for the first part of the review

parent d63e340a
...@@ -52,12 +52,12 @@ CalloutHandle::~CalloutHandle() { ...@@ -52,12 +52,12 @@ CalloutHandle::~CalloutHandle() {
context_collection_.clear(); context_collection_.clear();
// Normal destruction of the remaining variables will include the // Normal destruction of the remaining variables will include the
// destruction of lm_collection_, wn action that will decrement the // destruction of lm_collection_, an action that decrements the reference
// reference count on the library manager collection (which holds the // count on the library manager collection (which holds the libraries that
// libraries that could have allocated memory in the argument and context // could have allocated memory in the argument and context members.) When
// members). When that goes to zero, the libraries will be unloaded: // that goes to zero, the libraries will be unloaded: at that point nothing
// at that point nothing in the hooks framework will be pointing to memory // in the hooks framework will be pointing to memory in the libraries'
// in the libraries' address space. // address space.
// //
// It is possible that some other data structure in the server (the program // It is possible that some other data structure in the server (the program
// using the hooks library) still references the address space and attempts // using the hooks library) still references the address space and attempts
......
...@@ -80,11 +80,11 @@ class LibraryManagerCollection; ...@@ -80,11 +80,11 @@ class LibraryManagerCollection;
/// "context_destroy" callout. The information is accessed through the /// "context_destroy" callout. The information is accessed through the
/// {get,set}Context() methods. /// {get,set}Context() methods.
/// ///
/// - Per-library handle. Allows the callout to dynamically register and /// - Per-library handle (LibraryHandle). The library handle allows the
/// deregister callouts. (In the latter case, only functions registered by /// callout to dynamically register and deregister callouts. In the latter
/// functions in the same library as the callout doing the deregistration /// case, only functions registered by functions in the same library as the
/// can be removed: callouts registered by other libraries cannot be /// callout doing the deregistration can be removed: callouts registered by
/// modified.) /// other libraries cannot be modified.
class CalloutHandle { class CalloutHandle {
public: public:
......
This diff is collapsed.
...@@ -151,7 +151,7 @@ private: ...@@ -151,7 +151,7 @@ private:
/// ///
/// Constructor is declared private to enforce the singleton nature of /// Constructor is declared private to enforce the singleton nature of
/// the object. A reference to the singleton is obtainable through the /// the object. A reference to the singleton is obtainable through the
/// ggetServerHooks() static method. /// getServerHooks() static method.
/// ///
/// @throws isc::Unexpected if the registration of the pre-defined hooks /// @throws isc::Unexpected if the registration of the pre-defined hooks
/// fails in some way. /// fails in some way.
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment