Commit 619abfd9 authored by Thomas Markwalder's avatar Thomas Markwalder

[#101,!73] Addressed missed review items

parent 0be1868f
......@@ -11,11 +11,6 @@ This message is printed when DHCPv4 server enabled an interface to be used
to receive DHCPv4 traffic. IPv4 socket on this interface will be opened once
Interface Manager starts up procedure of opening sockets.
% DHCP4_ADDING_CONFIG_DB Opening configuration database: %1
This message is printed when the DHCPv4 server is attempting to open a
configuration database. The database access string with password redacted
is logged.
% DHCP4_ALREADY_RUNNING %1 already running? %2
This is an error message that occurs when the DHCPv4 server encounters
a pre-existing PID file which contains the PID of a running process.
......@@ -416,6 +411,11 @@ This warning message is issued when current server configuration specifies
no interfaces that server should listen on, or specified interfaces are not
configured to receive the traffic.
% DHCP4_OPEN_CONFIG_DB Opening configuration database: %1
This message is printed when the DHCPv4 server is attempting to open a
configuration database. The database access string with password redacted
is logged.
% DHCP4_OPEN_SOCKET opening sockets on port %1
A debug message issued during startup, this indicates that the DHCPv4
server is about to open sockets on the specified port.
......
......@@ -645,7 +645,7 @@ bool databaseConfigConnect(const SrvConfigPtr& srv_cfg) {
// Iterate over the configured DBs and instantiate them.
for (auto db : config_ctl->getConfigDatabases()) {
LOG_INFO(dhcp4_logger, DHCP4_ADDING_CONFIG_DB)
LOG_INFO(dhcp4_logger, DHCP4_OPEN_CONFIG_DB)
.arg(db.redactedAccessString());
mgr.addBackend(db.getAccessString());
}
......
......@@ -86,7 +86,7 @@ databaseConfigConnect(const SrvConfigPtr& srv_cfg);
/// @param srv_cfg Server configuration into which database configuration should be merged
/// @param mutable_cfg parsed configuration from the configuration file plus default values
void
databaseConfigFetch(const SrvConfigPtr& srv_cfg, isc::data::ElementPtr /*mutable_scope*/);
databaseConfigFetch(const SrvConfigPtr& srv_cfg, isc::data::ElementPtr /* mutable_cfg */);
}; // end of isc::dhcp namespace
}; // end of isc namespace
......
......@@ -20,7 +20,7 @@ namespace isc {
namespace dhcp {
namespace test {
/// @brief Test backend for that implements all of the DHCPv4 API calls
/// @brief Test backend that implements all of the DHCPv4 API calls
///
/// Currently all API get calls which return a single entry, will return an
/// empty pointer of appropriate type. API calls which return a collection of
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment