Commit 6b65ea8a authored by Marcin Siodelski's avatar Marcin Siodelski
Browse files

[1555] Minor: added a todo comment.

parent 0d4abba2
...@@ -852,6 +852,8 @@ Dhcpv4Srv::openActiveSockets(const uint16_t port, ...@@ -852,6 +852,8 @@ Dhcpv4Srv::openActiveSockets(const uint16_t port,
} }
// Let's reopen active sockets. openSockets4 will check internally whether // Let's reopen active sockets. openSockets4 will check internally whether
// sockets are marked active or inactive. // sockets are marked active or inactive.
// @todo Optimization: we should not reopen all sockets but rather select
// those that have been affected by the new configuration.
if (!IfaceMgr::instance().openSockets4(port, use_bcast)) { if (!IfaceMgr::instance().openSockets4(port, use_bcast)) {
LOG_WARN(dhcp4_logger, DHCP4_NO_SOCKETS_OPEN); LOG_WARN(dhcp4_logger, DHCP4_NO_SOCKETS_OPEN);
} }
......
...@@ -1133,6 +1133,8 @@ Dhcpv6Srv::openActiveSockets(const uint16_t port) { ...@@ -1133,6 +1133,8 @@ Dhcpv6Srv::openActiveSockets(const uint16_t port) {
} }
// Let's reopen active sockets. openSockets6 will check internally whether // Let's reopen active sockets. openSockets6 will check internally whether
// sockets are marked active or inactive. // sockets are marked active or inactive.
// @todo Optimization: we should not reopen all sockets but rather select
// those that have been affected by the new configuration.
if (!IfaceMgr::instance().openSockets6(port)) { if (!IfaceMgr::instance().openSockets6(port)) {
LOG_WARN(dhcp6_logger, DHCP6_NO_SOCKETS_OPEN); LOG_WARN(dhcp6_logger, DHCP6_NO_SOCKETS_OPEN);
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment