Commit 6d1d496e authored by JINMEI Tatuya's avatar JINMEI Tatuya
Browse files

[master] skip test cases that rely on select.poll. it's not always available.

this is an urgent care fix to #3014; we'll need cleaner solution (I
suggest #2690), but we should keep the master branch testable at least
for all developers and buildbots.
parent 18155a69
......@@ -19,6 +19,7 @@ from msgq import SubscriptionManager, MsgQ
import unittest
import os
import socket
import select # needed only for #3014. can be removed once it's solved
import signal
import sys
import time
......@@ -273,6 +274,8 @@ class MsgQTest(unittest.TestCase):
sock = Sock(1)
return notifications, sock
@unittest.skipUnless('POLLIN' in select.__dict__,
'cannot perform tests requiring select.poll')
def test_notifies(self):
"""
Test the message queue sends notifications about connecting,
......@@ -312,6 +315,8 @@ class MsgQTest(unittest.TestCase):
self.__msgq.kill_socket(sock.fileno(), sock)
self.assertEqual([('disconnected', {'client': lname})], notifications)
@unittest.skipUnless('POLLIN' in select.__dict__,
'cannot perform tests requiring select.poll')
def test_notifies_implicit_kill(self):
"""
Test that the unsubscription notifications are sent before the socket
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment