Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Sebastian Schrader
Kea
Commits
8edba879
Commit
8edba879
authored
Jan 15, 2014
by
Thomas Markwalder
Browse files
[3264] One more review change.
Forgot to document params to doOneExchange.
parent
432acd7e
Changes
1
Hide whitespace changes
Inline
Side-by-side
src/bin/d2/tests/nc_trans_unittests.cc
View file @
8edba879
...
...
@@ -302,6 +302,9 @@ public:
/// This method is used to build and send and update request. It is used
/// in conjuction with FauxServer to test various message response
/// scenarios.
/// @param name_change Transaction under test
/// @param run_time Maximum time to permit IO processing to run before
/// timing out (in milliseconds)
void
doOneExchange
(
NameChangeStubPtr
name_change
,
unsigned
int
run_time
=
500
)
{
// Create a valid request for the transaction.
...
...
@@ -856,6 +859,10 @@ TEST_F(NameChangeTransactionTest, sendUpdateTimeout) {
// Build a valid request, call sendUpdate and process the response.
// Note we have to wait for DNSClient timeout plus a bit more to allow
// DNSClient to timeout.
// The method, doOneExchange, can suffer fatal assertions which invalidate
// not only it but the invoking test as well. In other words, if the
// doOneExchange blows up the rest of test is pointless. I use
// ASSERT_NO_FATAL_FAILURE to abort the test immediately.
ASSERT_NO_FATAL_FAILURE
(
doOneExchange
(
name_change
,
NameChangeTransaction
::
DNS_UPDATE_DEFAULT_TIMEOUT
+
100
));
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment