Commit 8f3f6eef authored by JINMEI Tatuya's avatar JINMEI Tatuya
Browse files

[1502] revised the logic of checking equality of RR types as suggested in review

parent 760720cb
...@@ -166,9 +166,8 @@ class Diff: ...@@ -166,9 +166,8 @@ class Diff:
'''A helper routine to identify whether two RRsets are of the '''A helper routine to identify whether two RRsets are of the
same 'type'. For RRSIGs we should consider type covered, too. same 'type'. For RRSIGs we should consider type covered, too.
''' '''
if rrset1.get_type() != rrset2.get_type(): if rrset1.get_type() != isc.dns.RRType.RRSIG() or \
return False rrset2.get_type != isc.dns.RRType.RRSIG():
if rrset1.get_type() != isc.dns.RRType.RRSIG():
return rrset1.get_type() == rrset2.get_type() return rrset1.get_type() == rrset2.get_type()
# RR type of the both RRsets is RRSIG. Compare type covered. # RR type of the both RRsets is RRSIG. Compare type covered.
# We know they have exactly one RDATA. # We know they have exactly one RDATA.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment