Commit 9b930275 authored by JINMEI Tatuya's avatar JINMEI Tatuya
Browse files

[2850] unrelated cleanup: make some test methods non public when possible

also clarify TearDown is inherited by explicitly adding 'virtual'.
parent f7cfb333
...@@ -39,7 +39,7 @@ namespace { ...@@ -39,7 +39,7 @@ namespace {
class TestException {}; class TestException {};
class ZoneWriterTest : public ::testing::Test { class ZoneWriterTest : public ::testing::Test {
public: protected:
ZoneWriterTest() : ZoneWriterTest() :
segment_(ZoneTableSegment::create(RRClass::IN(), "local")), segment_(ZoneTableSegment::create(RRClass::IN(), "local")),
writer_(new writer_(new
...@@ -51,11 +51,10 @@ public: ...@@ -51,11 +51,10 @@ public:
load_null_(false), load_null_(false),
load_data_(false) load_data_(false)
{} {}
void TearDown() { virtual void TearDown() {
// Release the writer // Release the writer
writer_.reset(); writer_.reset();
} }
protected:
scoped_ptr<ZoneTableSegment> segment_; scoped_ptr<ZoneTableSegment> segment_;
scoped_ptr<ZoneWriter> writer_; scoped_ptr<ZoneWriter> writer_;
bool load_called_; bool load_called_;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment