Commit ad91831c authored by JINMEI Tatuya's avatar JINMEI Tatuya
Browse files

[1068] avoid using ASSERT_EQ in a constructor. ASSERT_EQ is not appropriate

since it would have to have a return value, and even any xxx_EQ doesn't
make much sense because this is not actually what we are trying to test.
I choise to simply let it fail (should it ever happens); we should be able
to know by seeing some of the subsequent tests fail.
parent ad36c799
...@@ -299,9 +299,10 @@ const char* const deleted_data[] = { ...@@ -299,9 +299,10 @@ const char* const deleted_data[] = {
class SQLite3Update : public SQLite3AccessorTest { class SQLite3Update : public SQLite3AccessorTest {
protected: protected:
SQLite3Update() { SQLite3Update() {
ASSERT_EQ(0, system(INSTALL_PROG " " TEST_DATA_DIR // Note: if "installing" the test file fails some of the subsequent
"/test.sqlite3 " // tests will fail and we should be able to notice that.
TEST_DATA_BUILDDIR "/test.sqlite3.copied")); system(INSTALL_PROG " " TEST_DATA_DIR
"/test.sqlite3 " TEST_DATA_BUILDDIR "/test.sqlite3.copied");
initAccessor(TEST_DATA_BUILDDIR "/test.sqlite3.copied", RRClass::IN()); initAccessor(TEST_DATA_BUILDDIR "/test.sqlite3.copied", RRClass::IN());
zone_id = accessor->getZone(Name("example.com")).second; zone_id = accessor->getZone(Name("example.com")).second;
another_accessor.reset(new SQLite3Accessor( another_accessor.reset(new SQLite3Accessor(
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment