Commit d93715fd authored by Shawn Routhier's avatar Shawn Routhier
Browse files

[trac3867] Update PIDFile test code per review comments

Update the PIDFile test code to create the file for the
not writable test.

Add entry in ChangeLog
parent 337f5221
880. [func] sar
A utility class has been added which handles writing and
deleting pid files as well as checking if the process with
the given pid is running.
879. [bug] fdupont
Drop DHCPREQUEST message from an unknown client in the
INIT-REBOOT state.
......
......@@ -23,7 +23,6 @@ using namespace isc::util;
// Filenames used for testing.
const char* TESTNAME = "pid_file.test";
const char* TESTNAME2 = "pid_file.test.2";
class PIDFileTest : public ::testing::Test {
public:
......@@ -66,7 +65,6 @@ private:
/// @brief Removes any remaining test files
void removeTestFile() const {
remove(TESTNAME);
remove(TESTNAME2);
}
};
......@@ -184,8 +182,14 @@ TEST_F(PIDFileTest, pidGarbage) {
/// @brief Test failing to write a file.
TEST_F(PIDFileTest, pidWriteFail) {
PIDFile pid_file(absolutePath(TESTNAME2));
PIDFile pid_file(absolutePath(TESTNAME));
// Create the test file and change it's permission bits
// so we can't write to it.
pid_file.write(10);
chmod(absolutePath(TESTNAME).c_str(), S_IRUSR);
// Now try a write to the file, expecting an exception
EXPECT_THROW(pid_file.write(10), PIDFileError);
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment