Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
7
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
Sebastian Schrader
Kea
Commits
ece21d1b
Commit
ece21d1b
authored
Mar 25, 2011
by
Jeremy C. Reed
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[master] typo and misspelling fixes
parent
90946cbc
Changes
9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
15 additions
and
15 deletions
+15
-15
src/lib/log/README
src/lib/log/README
+2
-2
src/lib/log/dummylog.h
src/lib/log/dummylog.h
+1
-1
src/lib/log/logger.h
src/lib/log/logger.h
+1
-1
src/lib/log/logger_support.cc
src/lib/log/logger_support.cc
+1
-1
src/lib/log/logger_support.h
src/lib/log/logger_support.h
+1
-1
src/lib/log/message_dictionary.cc
src/lib/log/message_dictionary.cc
+1
-1
src/lib/log/message_reader.cc
src/lib/log/message_reader.cc
+1
-1
src/lib/log/messagedef.mes
src/lib/log/messagedef.mes
+5
-5
src/lib/log/strutil.h
src/lib/log/strutil.h
+2
-2
No files found.
src/lib/log/README
View file @
ece21d1b
...
...
@@ -158,7 +158,7 @@ The symbols define the keys in the global message dictionary.
The namespace enclosing the symbols is set by the $NAMESPACE directive.
The "PREFIX_" part of the symbol name is the string defined in the $PREFIX
the argument to the directive. So "$PREFIX MSG_" would prefix the identifer
the argument to the directive. So "$PREFIX MSG_" would prefix the identif
i
er
ABC with "MSG_" to give the symbol MSG_ABC. Similarly "$PREFIX E" would
prefix it with "E" to give the symbol EABC. If no $PREFIX is given, no
prefix appears (so the symbol in this example would be ABC).
...
...
@@ -330,7 +330,7 @@ When logging events, make a distinction between events related to the server
and events related to DNS messages received. Caution needs to be exercised
with the latter as, if the logging is enabled in the normal course of events,
such logging could be a denial of service vector. For example, suppose that
the main authorit
i
ative service logger were to log both zone loading and
the main authoritative service logger were to log both zone loading and
unloading as INFO and a warning message if it received an invalid packet. An
attacker could make the INFO messages unusable by flooding the server with
malformed packets.
...
...
src/lib/log/dummylog.h
View file @
ece21d1b
...
...
@@ -38,7 +38,7 @@ extern std::string dprefix;
* places where logging should happen. When it is removed, compiler will do
* our work of finding the places.
*
* The only thing it does is printing the
d
program prefix, message and
* The only thing it does is printing the program prefix, message and
* a newline if denabled is true.
*
* There are no tests for this function, since it is only temporary and
...
...
src/lib/log/logger.h
View file @
ece21d1b
...
...
@@ -73,7 +73,7 @@ public:
/// deletion of the underlying log4cxx data structures when the logger is
/// deleted. Setting it false for externally-declared loggers inhibits
/// their deletion; so at program exit the memory is not reclaimed during
/// program rundown, only when the process is
d
elected. Setting it true
/// program rundown, only when the process is
s
elected. Setting it true
/// for loggers that will be deleted in the normal running of the program
/// enables their deletion - which causes no issues as the problem only
/// manifests itself during program rundown.
...
...
src/lib/log/logger_support.cc
View file @
ece21d1b
...
...
@@ -21,7 +21,7 @@
/// appropriate).
/// b) Reads in the local message file is one has been supplied.
///
/// These functions will be replaced once the code has b
n
een written to obtain
/// These functions will be replaced once the code has been written to obtain
/// the logging parameters from the configuration database.
#include <algorithm>
...
...
src/lib/log/logger_support.h
View file @
ece21d1b
...
...
@@ -34,7 +34,7 @@ namespace log {
///
/// \param root Name of the root logger
/// \param severity Severity at which to log
/// \param dbglevel Debug severiy (ignored if "severity" is not "DEBUG")
/// \param dbglevel Debug severi
t
y (ignored if "severity" is not "DEBUG")
/// \param file Name of the local message file.
void
initLogger
(
const
std
::
string
&
root
,
isc
::
log
::
Severity
severity
,
int
dbglevel
,
const
char
*
file
);
...
...
src/lib/log/message_dictionary.cc
View file @
ece21d1b
...
...
@@ -109,5 +109,5 @@ MessageDictionary::globalDictionary() {
}
// namspace log
}
// nam
e
space log
}
// namespace isc
src/lib/log/message_reader.cc
View file @
ece21d1b
...
...
@@ -186,7 +186,7 @@ MessageReader::parseNamespace(const vector<string>& tokens) {
// Process message. By the time this method is called, the line has been
// stripped of leading and trailing spaces, and we believe that it is a line
// defining a message. The first token on the line is convered to uppercase
// defining a message. The first token on the line is conver
t
ed to uppercase
// and becomes the message ID; the rest of the line is the message text.
void
...
...
src/lib/log/messagedef.mes
View file @
ece21d1b
...
...
@@ -37,12 +37,12 @@ DUPMSGID duplicate message ID (%s) in compiled code
DUPLNS duplicate $NAMESPACE directive found
+ When reading a message file, more than one $NAMESPACE directive was found. In
+ this version of the code, such a condition is regarded as an error and the
+ read will be abandon
d
ed.
+ read will be abandoned.
DUPLPRFX duplicate $PREFIX directive found
+ When reading a message file, more than one $PREFIX directive was found. In
+ this version of the code, such a condition is regarded as an error and the
+ read will be abandon
d
ed.
+ read will be abandoned.
IDNOTFND could not replace message for '%s': no such message identification
+ During start-up a local message file was read. A line with the listed
...
...
@@ -53,7 +53,7 @@ IDNOTFND could not replace message for '%s': no such message identification
+ identification has been removed.
+
+ This message may appear a number of times in the file, once for every such
+ unknown m
n
essage identification.
+ unknown message identification.
MSGRDERR error reading from message file %s: %s
+ The specified error was encountered reading from the named message file.
...
...
@@ -69,9 +69,9 @@ NSEXTRARG $NAMESPACE directive has too many arguments
NSINVARG $NAMESPACE directive has an invalid argument ('%s')
+ The $NAMESPACE argument should be a valid C++ namespace. The reader does a
+ cursory check on its validity, checking that the characters in the namspace
+ cursory check on its validity, checking that the characters in the nam
e
space
+ are correct. The error is generated when the reader finds an invalid
+ character. (Valid are alphanumeric characters, undersc
r
oes and colons.)
+ character. (Valid are alphanumeric characters, undersco
r
es and colons.)
NOMSGTXT a line containing a message ID ('%s') and nothing else was found
+ Message definitions comprise lines starting with a message identification (a
...
...
src/lib/log/strutil.h
View file @
ece21d1b
...
...
@@ -79,7 +79,7 @@ std::vector<std::string> tokens(const std::string& text,
///
/// Used in uppercase() to pass as an argument to std::transform(). The
/// function std::toupper() can't be used as it takes an "int" as its argument;
/// this confuses the template expansion mechanism because de
fer
erencing a
/// this confuses the template expansion mechanism because de
ref
erencing a
/// string::iterator returns a char.
///
/// \param chr Character to be upper-cased.
...
...
@@ -104,7 +104,7 @@ inline void uppercase(std::string& text) {
///
/// Used in lowercase() to pass as an argument to std::transform(). The
/// function std::tolower() can't be used as it takes an "int" as its argument;
/// this confuses the template expansion mechanism because de
fer
erencing a
/// this confuses the template expansion mechanism because de
ref
erencing a
/// string::iterator returns a char.
///
/// \param chr Character to be lower-cased.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment