Commit f9b16524 authored by Yoshitaka Aharen's avatar Yoshitaka Aharen
Browse files

[2157] remove extra comments, remove zone_origin_

parent 425b14dc
...@@ -494,7 +494,6 @@ AuthSrv::processMessage(const IOMessage& io_message, Message& message, ...@@ -494,7 +494,6 @@ AuthSrv::processMessage(const IOMessage& io_message, Message& message,
{ {
InputBuffer request_buffer(io_message.getData(), io_message.getDataSize()); InputBuffer request_buffer(io_message.getData(), io_message.getDataSize());
// statistics: check transport carrying the message (IP, transport)
impl_->stats_attrs_.setQueryIPVersion( impl_->stats_attrs_.setQueryIPVersion(
io_message.getRemoteEndpoint().getFamily()); io_message.getRemoteEndpoint().getFamily());
impl_->stats_attrs_.setQueryTransportProtocol( impl_->stats_attrs_.setQueryTransportProtocol(
...@@ -554,8 +553,6 @@ AuthSrv::processMessage(const IOMessage& io_message, Message& message, ...@@ -554,8 +553,6 @@ AuthSrv::processMessage(const IOMessage& io_message, Message& message,
**impl_->keyring_)); **impl_->keyring_));
tsig_error = tsig_context->verify(tsig_record, io_message.getData(), tsig_error = tsig_context->verify(tsig_record, io_message.getData(),
io_message.getDataSize()); io_message.getDataSize());
// statistics: check TSIG attributes
// SIG(0) is currently not implemented in Auth
impl_->stats_attrs_.setQuerySig(true, false, impl_->stats_attrs_.setQuerySig(true, false,
tsig_error != TSIGError::NOERROR()); tsig_error != TSIGError::NOERROR());
} }
...@@ -570,8 +567,7 @@ AuthSrv::processMessage(const IOMessage& io_message, Message& message, ...@@ -570,8 +567,7 @@ AuthSrv::processMessage(const IOMessage& io_message, Message& message,
const Opcode opcode = message.getOpcode(); const Opcode opcode = message.getOpcode();
bool send_answer = true; bool send_answer = true;
try { try {
// statistics: check EDNS // note: This can only be reliable after TSIG check succeeds.
// note: This can only be reliable after TSIG check succeeds.
ConstEDNSPtr edns = message.getEDNS(); ConstEDNSPtr edns = message.getEDNS();
if (edns) { if (edns) {
impl_->stats_attrs_.setQueryEDNS(true, impl_->stats_attrs_.setQueryEDNS(true,
...@@ -579,8 +575,7 @@ AuthSrv::processMessage(const IOMessage& io_message, Message& message, ...@@ -579,8 +575,7 @@ AuthSrv::processMessage(const IOMessage& io_message, Message& message,
impl_->stats_attrs_.setQueryDO(edns->getDNSSECAwareness()); impl_->stats_attrs_.setQueryDO(edns->getDNSSECAwareness());
} }
// statistics: check OpCode // note: This can only be reliable after TSIG check succeeds.
// note: This can only be reliable after TSIG check succeeds.
impl_->stats_attrs_.setQueryOpCode(opcode.getCode()); impl_->stats_attrs_.setQueryOpCode(opcode.getCode());
if (opcode == Opcode::NOTIFY()) { if (opcode == Opcode::NOTIFY()) {
......
...@@ -53,8 +53,6 @@ private: ...@@ -53,8 +53,6 @@ private:
bool req_is_tsig_; // signed with valid TSIG bool req_is_tsig_; // signed with valid TSIG
bool req_is_sig0_; // signed with valid SIG(0) bool req_is_sig0_; // signed with valid SIG(0)
bool req_is_badsig_; // signed but bad signature bool req_is_badsig_; // signed but bad signature
// zone origin
std::string zone_origin_; // zone origin
// response attributes // response attributes
bool answer_sent_; // DNS message has sent bool answer_sent_; // DNS message has sent
bool res_is_truncated_; // DNS message is truncated bool res_is_truncated_; // DNS message is truncated
...@@ -116,7 +114,6 @@ inline QRAttributes::QRAttributes() : ...@@ -116,7 +114,6 @@ inline QRAttributes::QRAttributes() :
req_is_edns_0_(false), req_is_edns_badver_(false), req_is_edns_0_(false), req_is_edns_badver_(false),
req_is_dnssec_ok_(false), req_is_dnssec_ok_(false),
req_is_tsig_(false), req_is_sig0_(false), req_is_badsig_(false), req_is_tsig_(false), req_is_sig0_(false), req_is_badsig_(false),
zone_origin_(),
answer_sent_(false), answer_sent_(false),
res_is_truncated_(false) res_is_truncated_(false)
{} {}
...@@ -175,7 +172,6 @@ QRAttributes::reset() { ...@@ -175,7 +172,6 @@ QRAttributes::reset() {
req_is_tsig_ = false; req_is_tsig_ = false;
req_is_sig0_ = false; req_is_sig0_ = false;
req_is_badsig_ = false; req_is_badsig_ = false;
zone_origin_.clear();
answer_sent_ = false; answer_sent_ = false;
res_is_truncated_ = false; res_is_truncated_ = false;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment