Commit fb246fec authored by Yoshitaka Aharen's avatar Yoshitaka Aharen
Browse files

[2155] update test case according to the review comment

Conflicts:
	src/bin/auth/tests/auth_srv_unittest.cc
parent 081f73d8
......@@ -131,17 +131,8 @@ protected:
// Checks whether all Rcode counters are set to zero
void checkAllRcodeCountersZero() const {
const std::map<std::string, ConstElementPtr>
stats_map(server.getStatistics()->get("zones")->get("_SERVER_")->
get("rcode")->mapValue());
for (std::map<std::string, ConstElementPtr>::const_iterator
i = stats_map.begin(), e = stats_map.end();
i != e;
++i)
{
checkRcodeCounter(i->first, i->second->intValue(), 0);
}
// with checking NOERROR == 0 and the others are 0
checkAllRcodeCountersZeroExcept(Rcode::NOERROR(), 0);
}
// Checks whether all Rcode counters are set to zero except the given
......@@ -242,6 +233,8 @@ createBuiltinVersionResponse(const qid_t qid, vector<uint8_t>& data) {
renderer.getLength());
}
// Check if the item has expected value.
// Before reading the item, check the item exists.
void
expectCounterItem(ConstElementPtr stats,
const std::string& item, const int expected) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment