GitLab

Provide separate list of parameter strings for deleting NSEC3 records.
It is cleaner to have separate enum for listing the parameters needed to
delete NSEC3 than re-using generic delete parameters and having the hash
passed twice.

mostly in documentation or in comments

reviewed by muks via jabber

includes output changes for two isc_throw.

Describe the value of the column in the NSEC3 case.

For the previous commit, adding the reverse name to the list of
parameters for delete.

This is significantly faster, as the rname has an index on it, while the
name doesn't.

Applied verbatim as sent on the mailing list. Documentation will come
soon.

reviewed by jelte via jabber.

Changes some log message descriptions and some
function arguments and some output.

also added some more hack to the DB unittests so add/delete zone tests
can work with mock accessor, too.

don't duplicate the duplicate zone check in sqlite3 accessor's addZone()
added documentation

Note: currently called createZone so as not to interfere with an existing addZone() call in MemoryClient.
Instead of pure virtual I made it have a default 'NotImplemented' method.
Also, the DatabaseClient holds the transaction (not the SQLite3Accessor); we could do it on that level but we already have a transaction API on a higher level and it makes a little bit more sense to me to do it there

See bug #2367 for the fix-scaffolding.py tool.

... instead of stripping them later.

Do it in the database data source itself. We also adjust doFindTest()
so that we only check for returned RRSIGs if FIND_DNSSEC option is
specified.  Otherwise we assert that no RRSIGs are returned by find().

Except in the database, which was changed to private.  It was not meant
to be public and hasn't actually been used except for tests and internally
in the database version.

so it will be clearer that they are used only for NSEC3-related records.
as suggested in review.

(as suggested in review)

updated DatabaseUpdater::deleteRRset so it would use the new method when
deleting NSEC3.

this is the first step to support updating the NSEC3 namespace of a zone.
to help support various cases in addRRset() in a less expensive way,
introduced a helper RRParameterConverter class.
one simple test case was added to confirm the behavior.

I also renamed init() to probe() as the latter seemed more appropriate
in terms of what it does.

these are short, and only used in FindDNSSECContext, so it'd make more sense
to enclose them there.
Other cleanups:
- also made FindDNSSECContext::isNSEC/isNSEC3 private as they now don't need
  to be called outside the class
- removed isInited(); simpy doesn't see the need for it as a separate method
- simplified the code logic of getResultFlag()

the latter has been merged to getDNSSECRRset().  doxygen comments were
also merged.

to do this, I extended getDNSSECRRset(name) further: it now takes 'covering'
parameter, depending on whether the requested NSEC is for the exact name
or the covering ("previous") name.  In the latter case it does the same
thing as findNSECCover() (which will be merged to getDNSSECRRset later).

- renamed getNSECRRset to getDNSSECRRset to clarify it's for generic DNSSEC
  purpose, even though it's essentially NSEC specific.
- moved the 'isNSEC' check to the now-renamed getDNSSECRRset, thereby removing
  the need for checking that within findOnNameResult.

instead of a pointer.
IMO, finderp_ should better be a reference than a pointer if we'd
worry about the case where it's NULL later on, like getNSECRRset
does (which shouldn't never happen in our usage).
the NULL pointer check was therefore removed with this change.

removed origin_ or complete flags_ from the class members.  non DNSSEC-specific
processing was recovered from the original version.
also made FindDNSSECContext private inside ZoneFinder; it doesn't have to
be publicly usable.
also made indentation policy more consistent for the class.

The high-level logic of finding it is similar, so we take the loop from
the in-memory data source and adapt it to the database.

- indentation
- spelling: 'other else' should be 'otherwise'
- constify
- avoid using an unnecessary temporary variable

They are only used for FindDNSSECContext, which is part of ZoneFinder
and can refer to its private members.

deal with the flag.