The previous commit disabled unused parameter warnings in the DHCP
code  when compiling with clang.  g++ picked up some additional
warnings/errors, and this fix corrects those.

On my home system I received error when running unit tests like:

Message DHCP4_SERVERID_LOADED server-id /home/reed/opt/bind10/var/b10-dhcp4-serverid has been loaded from file %2
assertion ""Excess logger placeholders still exist in message" == NULL" failed: file "../../../../src/lib/log/log_formatter.cc", line 69, function "void isc::log::checkExcessPlaceholders(std::string*, unsigned int)"

I am using --enable-logger-checks. The build farm also uses that.
I am not sure why this was not seen  on the build farm.

I added the missing value for dhcp4 and dhcp6 and the make check completed.

It had slight review on jabber.

Logging XFRIN_TRANSFER_PROTOCOL_ERROR as INFO level message could be
confusing. Rename to XFRIN_TRANSFER_PROTOCOL_VIOLATION, which is
neutral which has a neutral name regarding the log levels.

Also, include one known difference to bind9. This is both to store it
somewhere before we forget about it and to have an example to how the
file would look like.

The old version with . didn't work well with the form
  wait … for MESSAGE not OTHER_MESSAGE
Since the whole "MESSAGE not OTHER_MESSAGE" was captured into the first
(.+). This broke several tests in around xfrin and possibly others.

Now the tests pass and reviewed on jabber.

Perform post transfer validation of zone in XfrIn by isc.dn.check_zone and
reject broken zones.

To be aligned with the exception it describes.

Conflicts:
	src/lib/datasrc/zone.h
	src/lib/python/isc/datasrc/updater_inc.cc

- adjusted header file position to be more consistent
- remove unnecessary "`" (only needed for trac)
- refer to dns::RRsetCollectionBase instead of datasrc::RRsetCollectionBase

also moved convertRRset insde InMemoryZoneFinderTest class as a member
function so it can access origin_.

Test they have no side effects as to the acceptance of the zone, just
log stuff.

We check the result is of correct type, so use isinstance. It is unclear
how the original code could pass, though.

Fix a code in comment. It wouldn't work, but it was saying what not to
do anyway.

The XFRIN_INVALID_ZONE_DATA was numbered from %2, not from %1.

Or more specifically, make the tests not depend on dict ordering

Clarify one exception and document one old exception.

reviewed on jabber (muks)

When these methods are implemented, the author can look at the API
documentation of the base class as suggested.