GitLab

Adding such comments was discussed and agreed on jabber with Jinmei.

Some versions of GCC warn about some versions of Boost regarding
missing initializer for members in its posix_time.
https://svn.boost.org/trac/boost/ticket/3477
But older GCC compilers don't have the flag.

This is the same as on a few other Makefiles too.

The -no-undefined I added previously caused failures on Mac.
On my Linux and NetBSD tests it didn't notice. But the Macmini
detected it.  The top of error output is clear:

Undefined symbols:
  "isc::asiolink::IOAddress::operator unsigned int() const", referenced
from:
      isc::dhcp::IfaceMgr::send(boost::shared_ptr<isc::dhcp::Pkt4>
const&)in libdhcp___la-iface_mgr.o

Okayed by tomek via jabber.

The libdhcp++ API was changed as part of the refactoring.

When linking new tests to old library it fails with:

/libexec/ld-elf.so.1:
/usr/home/jreed/builder/work/BIND10-cppcheck/20120516153001-FreeBSD8-amd64-GCC/build/src/bin/dhcp4/tests/.libs/dhcp4_unittests:
Undefined symbol "_ZN3isc4dhcp6OptionC1ENS1_8UniverseEtRKSt6vectorIhSaIhEE"

This is:
 isc::dhcp::Option::Option(isc::dhcp::Option::Universe, unsigned short,
std::vector<unsigned char, std::allocator<unsigned char> > const&)

See http://bind10.isc.org/wiki/LibraryVersioning for details.

and renamed libdhcp_unittest to libdhcp++_unittest

(but didn't change LibDHCP within code)

- Interface detection implemented for Linux.
- OS-specific defines added to configure.ac
- Added stub interface detection for BSD systems.

- IfaceMgr moved
- Added new, simple test for b10-dhcp4 daemon
- Added skeleton man page for b10-dhcp4

Added Option4_AddrLst class that represents DHCPv4 option that stores
a single IPv4 address or a list of IPv4 addresses.
Added tests for this new option.
Added check in Option6_AddrLst, so it accepts only IPv6 addresses.
Removed unnecessary pack4() method in Option class.

 - dhcp4.h added to Makefile.am
 - Pkt4.cc: address fields initialized in more efficient way
 - Pkt4.h: many improvements in comments
 - Minor improvements in Pkt4 unittests

 - added consts in packOption6, unpackOptions6
 - removed version() method
 - alignments fixed in dhcp6.h

- buffer type changed: char => uint8_t
- removed unnecessary statements in Makefile.am

- include paths fixed
- dangling spaces removed
- many parameters are now passed by reference
- added doxygen comments for all methods in dhcp6_srv.h
- src/bin/dhcp6/Makefile.am no longer references Pkt6.{cc|h}

 - IA support (Option6IA class) added.
 - Support for suboptions in IA option.
 - IAADDR support (Option6IAAddr class) added.
 - Initial tests added for new classes added.