GitLab

This has a chance that some log messages get lost (DEBUG messages during startup in case -v is not given but the config has DEBUG set)

by encapsulating the appender in SharedAppenderPtr immediately after the
creation, we can make sure buffer_appender1 won't leak even if the
creation of the second appender fails.

- renamed test class
- added a subclass of BufferAppender to directly test append()
(and re-enabled the relevant test case)
- minor doxy updates

And use those in the case of flushStdout() upon destruction

Since LogBuffer no longer exists, the file name did not match its content anymore

and pull its functionality into BufferAppender
(one unit test temporarily disabled, might be removed in next commit or updated to get around the protected method it uses)

LogBuffers are now members of BufferAppender instances, and the singleton has been removed. LoggerManagerImpl keeps them (if any) around while processing a new specification, and flushes them when done.

- update README
- copy vector of event on flush
- only use very basic functions in case of flush-on-destruct

To prevent accidental outside use, all LogBugger (and BufferAppender) code is in the namespace isc::log::internal now, and the files have been renamed to _impl

And clean up the process() calls and processSpecification() method (which should mostly look like they were now)

slightly changed outer layer process() call so it isn't necessary anymore

even when -s was not given but it reverts to standalone because of a session error

including docstring updates

Also updated log's README

needs cleanup and tests

Removed the socket.shutdown() before socket.close() again, this seemed to cause some errors with the statistics tests (which we will look into separately)

Discussed on jabber

callable() has been removed in Python 3, but was reintroduced in Python 3.2. This fix (check for isinstance(obj, collections.Callable) should make the test work with 3.1 and older versions of 3.

(acked on jabber)

- reduced a line that was 1 character too long
- flipped order of check with isdigit()
- renamed Token::NUMBER_RANGE to Token::NUMBER_OUT_OF_RANGE