GitLab

Merge of #2380 missed a couple of cases, and added a few more sleeps to help with background loading checks.

this is necessary for distcheck.

it can take time without any feedback while deleting old zone data,
so it's probably better to note that explicitly.

this seems to be the actual intent of the RFC, and it's compatible with
BIND 9, too.  This fix will resolve the remaining regression for the
old loadzone tests.

see the log for the previous commit for the rationale.

test parameters were adjusted accordingly.
there are some non trivial adjustments needed for the 'correct' test
cases for the original loadzone:
- completing the origin for some RDATA paramaeters (NS, SOA) does not
  work yet until we complete the RDATA support.  At the moment
  I made them FQDNs with comments
- a few TXT data were actually incorrect in the original tests, which
  caused a seeming regression.  I fixed the test data.
- there was one real bug in the $INCLUDE + origin support.  I'll go
  fix it; right now it fails

The 'error' test cases for the original loadzone also fail, but overall
the intended behavior looked preserved.  Fixing the tests to make it pass
seems to be quite difficult (because log output are different, and
the new loadzone ng is more verbose), so I plan to simply remove these
tests.

Value stored to 'opt_len' during its initialization is never read

discussed via jabber

also use const

New feature was added: deleteSubnets4

okayed via jabber.

The $ORIGIN handling.

Conflicts:
	src/lib/dns/master_loader.cc
	src/lib/dns/tests/master_loader_unittest.cc

It is probably unusual and most probably a typo, resulting in broken
zone.

Update the warning message to be usable for this case too. Also,
explicitly check and fix lexer again for this case.

OpenBSD, NetBSD and some builds on MacOS don't like it.

Conflicts:
	src/lib/dns/master_loader.cc

Fixed conflicts:
	src/lib/dns/master_loader.cc
	src/lib/dns/tests/master_loader_unittest.cc

With fixing conflicts:
	src/lib/dns/master_loader.cc
	src/lib/dns/tests/master_loader_unittest.cc

This reverts commit 2c50eecd.

Conflicts:
	src/lib/dns/rrcollator.cc
	src/lib/dns/rrcollator.h

This reverts commit 822fa315.