GitLab

Split the logging into three loggers
 config & general
 dhcp to d2
 d2 to dns (and back)

Print out a request ID for each NCR event.  Currently this is the
DHCID but it could be changed in the future to allow for comparing
log entries between DHCP servers and D2.

Fix up some typos I ran across while reading the code

Consolidated DNSClient::doUpdate variants into a single method which
accepts a smart pointer to a TSIGKey instead of TSIGKey reference.
Simplified some unit tests.
Added missing commentary.
Corrected typos and copyright dates.

Change D2UpdateMessage to support TSIG signing and verification via its
toWire and fromWire methods.  Both now accept a pointer to a TSIGContext,
which they should use, if its not NULL.

Implemented DNSCLient::doUpdate variant that accepts a TSIGKey. It will
use the key to create a TSIGContext that will then be used to sign the
outbound request and to verify the response in the operator() method.

Added appropriate unit tests.

Added todo to dns_client.cc commentary regarding
trac# 3286 and the behavior isc::dns::Message::fromWire.

Changed DNSClient ctor to require response param be
an empty pointer and clarified related commentary.
Added debug log statement to log transaction start.
Other minor cosmetics.

Now that NameAddTransaction and NameRemoveTransction classes
have been implemented, D2UpdateMgr has been updated to use
them.  It now creates instances of NameAddTransaction and
NameRemoveTransaction based on the change type specified in
received NameChangeRequests as designed.

Good deal of commentary clean up, rolled back IOService reference
changes to DNSClient, and most significantly added unit tests
for NameChangeTransaction::sendUpdate.  These tests involve an
actual message exchange.

Some classes were using references to isc::asiolink::IOService, others
where using d2::IOServicePtr.  The latter is now used throughout for
consistency as well as support for future, possible, multi-threaded
implementation.

In particular, added a doUpdate version which supports TSIG. It is also
possible to specify Transport layer protocol preferred.