GitLab

offset values can actually be larger than max_labellen (63).  we should have
check label length field of the name data.  added tests that would trigger
this bug.

added a test case for it and updated the doc.
rbtree/domaintree was modified to avoid such operations.

in response to buildbot report.  confirmed the fix on the box, and should be
trivial.  so directly committing.

- typos
- few code fixes
- test updates

these were basically for this serialization, but now that we have a
different version of serialization/deserialization, we don't need them
for this purpose.  Until we see the need for them for specific purposes,
it'd be better to clean them up.

This simplifies some internal part of the code, and eliminates the need for
offsets_size_ (so it's removed).  This change is a preparation for making
the "from raw data" construction more generic to support non absolute labels.
This is a purely internal refactoring, and public interfaces aren't changed.

if one is absoulte and the other is not, they won't have common labels,
so the main logic can detect their relationship is NONE.  We don't need
to handle this case separately for performance (if that was the reason)
because we generally don't expect to do this type of mismatch comparison.

unit tests need to be adjusted because the order is now non 0.

if nlabels == 0, it must not be absolute because otherwise the other
should also be absolute, in which case nlabes != 0.

the originally intended behavior was to return non 0 order for these cases,
so this point was adjusted.
the code was also simplified by removing unnecessary conditions like:
-                     ((last_label_ < getLabelCount()) ||
-                      (other.last_label_ < other.getLabelCount())))) {

this is meaningless because getLabelCount() is last_label_ - first_label_,
so the codntion is actually first_label_ < 0, which is always false.
whatever the real intent of this condition was, such additional checks
didn't seem to be necessary for the intended behavior of compare() anyway,
so I simply removed them.
some test cases were adjusted for the change, and some were added to confirm
related cases that were not tested before.

- style fix in return value
- updated header documentation
- added common label count checks to tests

instead of reference to Name
- moved actual name comparison code to labelsequence
- removed Name reference
- replaced by data, offsets, and offset_size values
- added 'raw' constructor for LabelSequence