GitLab

- renamed 'bind10' to 'b10-init'
- renamed related files as well
- left alone the 'run' script, as well as the directory name
- added new 'bind10' script that execs b10-init

note this commit only handles file names, and internal references have not been updated yet

On my home system I received error when running unit tests like:

Message DHCP4_SERVERID_LOADED server-id /home/reed/opt/bind10/var/b10-dhcp4-serverid has been loaded from file %2
assertion ""Excess logger placeholders still exist in message" == NULL" failed: file "../../../../src/lib/log/log_formatter.cc", line 69, function "void isc::log::checkExcessPlaceholders(std::string*, unsigned int)"

I am using --enable-logger-checks. The build farm also uses that.
I am not sure why this was not seen  on the build farm.

I added the missing value for dhcp4 and dhcp6 and the make check completed.

It had slight review on jabber.

Logging XFRIN_TRANSFER_PROTOCOL_ERROR as INFO level message could be
confusing. Rename to XFRIN_TRANSFER_PROTOCOL_VIOLATION, which is
neutral which has a neutral name regarding the log levels.

To be aligned with the exception it describes.

- adjusted header file position to be more consistent
- remove unnecessary "`" (only needed for trac)
- refer to dns::RRsetCollectionBase instead of datasrc::RRsetCollectionBase

also moved convertRRset insde InMemoryZoneFinderTest class as a member
function so it can access origin_.

Test they have no side effects as to the acceptance of the zone, just
log stuff.

We check the result is of correct type, so use isinstance. It is unclear
how the original code could pass, though.

Fix a code in comment. It wouldn't work, but it was saying what not to
do anyway.

The XFRIN_INVALID_ZONE_DATA was numbered from %2, not from %1.

Or more specifically, make the tests not depend on dict ordering

Clarify one exception and document one old exception.

reviewed on jabber (muks)

When these methods are implemented, the author can look at the API
documentation of the base class as suggested.

http://git.bind10.isc.org/~tester/builder//BIND10-cppcheck/20130125000502-FreeBSD8-amd64-GCC/logs/unittests.out

Due to the difference of timing of invoking datetime.now(), _stop_timer()
should return greater than one second. But depending on runtime environment, it
happens to return one second exactly. For supporting this behaviour, regarding
checking of the returned value, 'assertGreater' is changed to
'assertGreaterEqual'.

the latter is relatively new and doesn't work for all of our supported
python versions.  will fix a buildbot report.  committing at my discretion.

And make the test slightly cleaner by that. No change in functionality,
just rely on assumptions about what breaking of API don't matter little
bit less.

Use separate error message and exception for the case when received zone
data doesn't pass basic validation.