GitLab

- renamed 'bind10' to 'b10-init'
- renamed related files as well
- left alone the 'run' script, as well as the directory name
- added new 'bind10' script that execs b10-init

note this commit only handles file names, and internal references have not been updated yet

On my home system I received error when running unit tests like:

Message DHCP4_SERVERID_LOADED server-id /home/reed/opt/bind10/var/b10-dhcp4-serverid has been loaded from file %2
assertion ""Excess logger placeholders still exist in message" == NULL" failed: file "../../../../src/lib/log/log_formatter.cc", line 69, function "void isc::log::checkExcessPlaceholders(std::string*, unsigned int)"

I am using --enable-logger-checks. The build farm also uses that.
I am not sure why this was not seen  on the build farm.

I added the missing value for dhcp4 and dhcp6 and the make check completed.

It had slight review on jabber.

Logging XFRIN_TRANSFER_PROTOCOL_ERROR as INFO level message could be
confusing. Rename to XFRIN_TRANSFER_PROTOCOL_VIOLATION, which is
neutral which has a neutral name regarding the log levels.

To be aligned with the exception it describes.

Test they have no side effects as to the acceptance of the zone, just
log stuff.

The XFRIN_INVALID_ZONE_DATA was numbered from %2, not from %1.

Clarify one exception and document one old exception.

the latter is relatively new and doesn't work for all of our supported
python versions.  will fix a buildbot report.  committing at my discretion.

Use separate error message and exception for the case when received zone
data doesn't pass basic validation.

- small updates to doc and comments
- changed __try_login to _try_login
- replaced direct calls to print() with self._print(), to override in tests
  (and more easily check output)
- added some more test cases
- made cmdctl tests fail is environment vars aren't set

some test cases needed to be adjusted accordingly.

Report any issues found in the zone through logging.

If we can't even import the DNS library, we are doomed and there's no
reason to continue running. So remove the check. We would probably crash
in a very short time anyway due to a call to something from the not
imported library.

There's a lot of mocking within the tests, but it seems hard without it.

Check a zone without NS (we can't really make a zone without SOA by XFR)
is rejected.

There'll be more of this code soon, to check the zone data.

Also correct error messages in the configuration parser: the
same error is logged on any parser error, both creation and
running.  The text was made more general.

When the boss process was unable to connect to the msgq, it would
exit. However, it would leave the msgq process running. This patch
fixes that by killing the msgq if it is running in this case.