GitLab

Fix failure to connect in msgq tests.

Conflicts:
	ChangeLog

and also remove dash before beta revision in version naming

unit tests.

trivial, no review

I wrote this some month ago.
Didn't get reviewed.

some compilers claim it causes a copy whie it's defined non copyable,
triggering an error.  this fixes some build failure reported by the bots.
should mostly trivial, so committing at my discretion.

acknowledged on jabber

(used tools/reorder_message_file.py)

instead of the "static" BIND zone.  there's no difference between these two
any more, so this is just a matter of style.

 - using namespace boost is no longer used in pkt6_unittest.cc
 - copyright years updated
 - Pkt6::getRelayOption() documented
 - several methods are now better commented
 - ChangeLog now refers to libdhcp++, not b10-dhcp6

Even if we fail to connect, close the socket. It is loosely related to
the previous commit, as that one used unsuccessful connection attempts
to discover msgq is not ready yet and the unit tests complained. It
should have no real effect, since the garbage collector would reclaim
the socket after a while anyway.

This should solve the race condition when the socket file is created,
but connect to it does not work yet, because listen() was not called on
it yet. Really connecting ensures it is possible to connect.

may need some more discussion, but not the point for this branch anyway,
and at least it's more consistent with rest of the source code.

Okayed via jabber yesterday.

I am not adding a changelog entry as it is minor.

we can do everything that the dedicated static data source did with
"MasterFiles" type of data source with preconfigured parameters.
this cleanup is not directly related to the subject of this task, but
will make later changes simpler.

this is not a program error, so CacheConfigError should be more appropriate.

that would be better abstraction.  also remove getLoadAction for now as
we won't implement it in this task.

also simplified the constructor interface; we actually don't need the
other one.