GitLab

Added todo to dns_client.cc commentary regarding
trac# 3286 and the behavior isc::dns::Message::fromWire.

Added commentary to d2/tests/nc_test_utils.h::FauxServer
Corrected doxygen errors

Changed DNSClient ctor to require response param be
an empty pointer and clarified related commentary.
Added debug log statement to log transaction start.
Other minor cosmetics.

Now that NameAddTransaction and NameRemoveTransction classes
have been implemented, D2UpdateMgr has been updated to use
them.  It now creates instances of NameAddTransaction and
NameRemoveTransaction based on the change type specified in
received NameChangeRequests as designed.

Fixed two missed minor cleanups from the initial review.

Changes are largely clean up and commentary.

 - flag => configuration parameter
 - echoClientId test uses ASSERTs rather than EXPECTs

 - tests/methods descriptions improved
 - CfgMgrTest.echoClientId improved
 - Redundant checks removed from Dhcpv4SrvTest.discoverEchoClientId
 - BIND10 Guide clarified
 - ChangeLog added

d2/nc_add.cc contained some inaccurate RFC references.

Added methods for constructing all three types of DNS update requests
required by d2::NameRemoveTransaction to complete the implementation of its
state machine.  Also refactored some unit test code into nc_test_utils.h
and .cc. Renamed request verification functions in nc_test_utils to match
the build request function names.

Interrim check-in for 3088, which introduces the initial
implementation of d2:NameRemoveTransaction.  This class
implements the state model logic necessary for removing
DNS entries per RFC 4703.  The state model logic is
complete, what remains is the logic to build the actual
request messages.

Changed dhcp_ddns::NameChangeRequest to store lease address as
IOAddress only.  Corrected logic that handles request build
exceptions and added unit tests for same.  Other minor changes.

Added methods for constructing all three types of DNS update requests
required by d2::NameAddTransaction to complete the implementation of its
state machine.  Also refactored some unit test code into nc_test_utils.h
and .cc, and ran much needed spell checking.

Fixed a typo and added a bit more diagnostic output to two unit tests.

Minor corrections based on re-review.

Addressed minor compilation issues in nc_trans_unittests.cc under
FreeBSD.

Good deal of commentary clean up, rolled back IOService reference
changes to DNSClient, and most significantly added unit tests
for NameChangeTransaction::sendUpdate.  These tests involve an
actual message exchange.

This test covers the scenario which server didn't handle and which resulted
in submission of the 3220 ticket.

The minor issues addressed are:
- Missing comments
- Lack of todo
- Log messages

If you attempt to pipe commands in to bindctl and the session is not
interactive (i.e it is not a TTY) then do not attempt to read the user
name and password.

Observed compilation issues on Debian 7 when libdhcp++ was not explicitly
linked to the DDNS module.

Created unit tests for all of the states implemented by NameAddTransaction
in b10-dhcp-ddns.  The class lacks only proper construction of DNS update
requests.

This interrim checkin includes the initial implementation of
NameAddTransaction to b10-dhcp-ddns.  It provides the preliminary
state model needed to add forward and/or reverse DNS entries for
and FQDN.  It does not yet construct the actual DNS update requests.

Some classes were using references to isc::asiolink::IOService, others
where using d2::IOServicePtr.  The latter is now used throughout for
consistency as well as support for future, possible, multi-threaded
implementation.

When bind10 is run in verbose mode, as is indicated to the user by
certain error messages, do not redirect b10-msgq's STDOUT to /dev/null
so that the user can see the actual cause for startup failure.

No ChangeLog entry required.

When there is an error connecting to the message queue socket file
because it wasn't cleaned up properly, and we know the name of the
socket file, display its name as part of the error message.

No ChangeLog entry required.

As per review, update the tests to ensure that the existing message
queue daemon still works even after we have had a failed attempt to
start a second copy of the daemon.