GitLab

Added todo to dns_client.cc commentary regarding
trac# 3286 and the behavior isc::dns::Message::fromWire.

Added commentary to d2/tests/nc_test_utils.h::FauxServer
Corrected doxygen errors

Changed DNSClient ctor to require response param be
an empty pointer and clarified related commentary.
Added debug log statement to log transaction start.
Other minor cosmetics.

Now that NameAddTransaction and NameRemoveTransction classes
have been implemented, D2UpdateMgr has been updated to use
them.  It now creates instances of NameAddTransaction and
NameRemoveTransaction based on the change type specified in
received NameChangeRequests as designed.

Fixed two missed minor cleanups from the initial review.

Changes are largely clean up and commentary.

d2/nc_add.cc contained some inaccurate RFC references.

Added methods for constructing all three types of DNS update requests
required by d2::NameRemoveTransaction to complete the implementation of its
state machine.  Also refactored some unit test code into nc_test_utils.h
and .cc. Renamed request verification functions in nc_test_utils to match
the build request function names.

Interrim check-in for 3088, which introduces the initial
implementation of d2:NameRemoveTransaction.  This class
implements the state model logic necessary for removing
DNS entries per RFC 4703.  The state model logic is
complete, what remains is the logic to build the actual
request messages.

Changed dhcp_ddns::NameChangeRequest to store lease address as
IOAddress only.  Corrected logic that handles request build
exceptions and added unit tests for same.  Other minor changes.

Added methods for constructing all three types of DNS update requests
required by d2::NameAddTransaction to complete the implementation of its
state machine.  Also refactored some unit test code into nc_test_utils.h
and .cc, and ran much needed spell checking.

Fixed a typo and added a bit more diagnostic output to two unit tests.

Minor corrections based on re-review.

Addressed minor compilation issues in nc_trans_unittests.cc under
FreeBSD.

Good deal of commentary clean up, rolled back IOService reference
changes to DNSClient, and most significantly added unit tests
for NameChangeTransaction::sendUpdate.  These tests involve an
actual message exchange.

Observed compilation issues on Debian 7 when libdhcp++ was not explicitly
linked to the DDNS module.

Created unit tests for all of the states implemented by NameAddTransaction
in b10-dhcp-ddns.  The class lacks only proper construction of DNS update
requests.

This interrim checkin includes the initial implementation of
NameAddTransaction to b10-dhcp-ddns.  It provides the preliminary
state model needed to add forward and/or reverse DNS entries for
and FQDN.  It does not yet construct the actual DNS update requests.

Some classes were using references to isc::asiolink::IOService, others
where using d2::IOServicePtr.  The latter is now used throughout for
consistency as well as support for future, possible, multi-threaded
implementation.

Added empty implemenation of StateMode::onModelFailure and
renamed event and state boundary constants.

This commit replaces the state specification mechanism in d2::StateModel
with one derived from LabeledValue and LabeledValueSet.

Created new classes, LabeledValue and LabeledValueSet to
provide a cleaner mechanism for defining the set of valid events
and states.  With this commit, events now use these new constructs.
The modifications to use these constructs for states will be done
as separate commit.

Some addtional, minor review comments were also addressed.

b10-dhcp-ddns Finite state machine logic was refactored into its own class,
StateModel.

Added virtual method for validating state handler map, added additional unit tests and commentary.

Added methods to base class for supporting server selection from a list
of DNS servers.

Interim commit for 3086 which includes the preliminary implementation
of the base class, NameChangeTransaction.  b10-dhcp-ddns module will use
derivations of this class to carry out NameChangeRequests.

Replaced use of EXPECT_EQ(false,) with EXPECT_FALSE()
in d2_process_unittests.cc.  These were failing to
compile under Fedora 18/gtest 1.6. This appears to be
a gtest bug.  Other minor changes.

Minor corrections only, there were no major revisions.

Added main process event loop to D2Process which is the
primary application "object" in b10-dchp-ddns.

Along the way it was necessary to adjust D2QueueManager to treat
stopping as an asyncrhonous event when IO is pending. This
requied a change in lib-dchp-ddns to have awareness of when
IO is pending.

Fixed a bug in D2 configuration parsing in which parsing a
a subsequent configuration caused duplicate TSIGKeyInfo
entries.

D2UpdateMgr::checkFinishedTransaction was issuing an invalid read
when attempting to prefix increment an iterator used in an std::map erase
call.  This was flagged by valgrind and also core dumped under FreeBSD10.

D2UpdateMgr members were rescoped to be more appropriate
and unit tests adjusted accordingly. Other minor changes.