GitLab

DatabaseIterator instead of the hardcoded IN class.

constructor.  Since we should manage the transaction inside the
DatabaseIterator class, it will make more sense to start it within the class.

in a subseuqnet it could miss SOA after update.
also cleanup the iterator test using checkRRset.

SOA contained in the iteration result.

accordingly.  The current API doesn't require any specific order, so it doesn't
break, but we'll probably eventually need this ordering to support
differtiating zone contents.  For the purpose of this ticket, it's convenient
if the order is the same for both sqlite3 and mock accessors, so I made
this change right now.

and have the new method return the result.
note: I decided to change it from the more generic 'getFinder()', because
I found it wouldn't work for some types of database backend such as MySQL.

they can be used in more generic context.  We'll use them in subsequent
changes.  other than the method name change no behavior change yet.

unless tp_alloc succeeds.

Enable the man page generation from docbook y uncommenting in the
makefile.

Add the xml version. Minor changes, but still quite incomplete.
This is just a dummy manpage for now.

also logged it when such an event happens.

reference leak.  To test this case, introduced a framework for testing
process_xfrin().  This setup will be used for subseuent related fixes.

also fixed another possible (but quite unlikely) leak in case tp_alloc() fails.

this problem surfaced when 1246 got merged; the ModuleCCSession start in bind10 actually relied on some environment variable leaking out (which 1246 fixed).
This change makes it an explicit optional argument to ModuleCCSession (which can still be overridden by the environment variable)

and fix category of an earlier entry i made

like missing NULL check or exception safety.  also as a cleanup got rid
of unnecessary reinterpret_cast.

Proper solution (enabled, passing tests that use generateTestPacket2()
function) is available in #1226 that is currently under review.