GitLab

also clarify TearDown is inherited by explicitly adding 'virtual'.

This also makes ZoneWriter a concrete class (and removes
ZoneWriterLocal).

as details are implemented the latter now seems more appropriate for the
responsibility of this class.

this eliminated the need for if-else cases in
ConfigurableClientList::configure().  to make it possible getDataSourceClient()
was slightly updated so that it recognizes "MasterFiles".

some non trivial adjusments were needed for its users.

Removing the release from the test, since the segment now destroys it
itself. We can't check all memory is deallocated at that moment in the
test (since we can't do it before the destroy -- it is not deallocated
fully yet, and can't do it after also, since the memory segment doesn't
exist). But that doesn't matter, since the segment checks by assert.

We try to put some data there and see it survived.

But the benefit of this change is questionable.

Into a separate file. It is not needed to be too public.

According to the review, Updater might be misleading.

As we want to directly modify the ZoneTable in ZoneReloaderLocal
(because it is memory-type dependant), we don't need the InstallAction
for anything. If we don't need it, we don't pass it as constructor
parameter -- it'll be called from a factory anyway and the factory may
know we don't need it.

Also adding a setTable() method to ZoneTableHeader. The header had no
way to specify the table currently and we need it for the tests. The
method is currently tentative, we'll probably replace it by something.

NULL makes no sense, so throw in that case.

We allocate the ZoneData in the LoadAction, to match what happens in
ticket #2268 -- there's a function to load zone which allocates it
itself, we want to use it.

This might be less confusing.

Someone O:-) forgot to add it in the ^^ commit.