GitLab

Added the constant D2ClientConfig::DFT_ALWAYS_INCLUDE_FQDN

Added a method to ValueType<> template, getOptionalParam.
Defined constants for dhcp-ddns default values in D2ClientConfig.
D2ClientConfigParser uses these in conjuction with calls to
ValueType<>getOptionalParam() to ensure all the parameters needed
have values.
Modifed unit tests accordingly.

 - RelayInfoParser now takes Option::Universe as last parameter;
 - Extra tests for checking invalid parameters in RelayInfoParser
 - Comments in subnet.h improved
 - Sanity checks in RelayInfoParser implemented, doc improved

Most notable change is the removeal of the remove-on-renew
configuration parameter.  Other changes were to commentary
or minor code improvements.

D2CLientConfigParser now supports parsing all parameters even if
enable-updates is false.  This allows values like generated-prefix
and qualifying-suffix to be used even if udpates are turned off.
The parser still supports an abbreviated dhcp-ddns entry that has only
enable-updates defined as false.

Changed IP addresses used in tests in dhcp_parsers_unittest.cc
to comply test values recommened by RFCs.

Removed configuration parameter allow-client-update.
It was deemed to really just be the inverse of override-client-update.
Renamed convenience method isDhcpDdns to ddnsEnabled.
Made enum to string converion functions case insenstive.
Updated copyright dates and other cosmetic changes.

Added configuration paramters to dhcp4 and its spec file to support DHCP-DDNS.
Created new classes D2ClientMgr, D2ClientConfig, and D2CientConfigParser in the
libdhcpsrv.   The new parameters are parsed, validated, and stored  but do
not yet affect behavior.  That will be implemented as a seperate ticket.

 - config parsers updated
 - new unit-tests for vendor options written
 - libdhcp++ cleaned up
 - fixes in option_vendor.cc
 - comments added and cleaned up

This apparently happens when gtest-1.5 is in use. Patch was reviewed by
Thomas Markwalder.

This commit also changes the ParserContext copy constructor and assignment
operator to handle copying of the NULL shared pointers.

Now awaiting the merging of #2980 (the hooks code) so that the
configuration validation code can check if the libraries are valid
before accepting the configuration.

platforms.

exception under Ubuntu. Added logic to reset all of CfgMgr data between tests. Did not fail under Mac OS-X. New unit tests added for options definition tests were leaving data in CfgMgr.

a unit test in DHCP4, and it appears we rely on being able to set a string
configuration value from any element type.

dhcp_parsers_unittest.cc.  Added Element type checks to
Boolean and String parsers, corrected some commentary.