GitLab

Update manager now passes the D2 config manager reference into transactions
when it creates them. This makes D2 configuration services available at
the transaction level.

Changed NameChangeTransaction::sendUpdate() to get the timeout value from
configuration rather than use hard-coded constant.

Added methods to D2CfgMgr to return whether or not forward or reverse
updates are enabled. Altered D2UpdateMgr::makeTransaction to utlilize
these new methods. Added additional logs and unittests.

Changed DNSClient ctor to require response param be
an empty pointer and clarified related commentary.
Added debug log statement to log transaction start.
Other minor cosmetics.

Now that NameAddTransaction and NameRemoveTransction classes
have been implemented, D2UpdateMgr has been updated to use
them.  It now creates instances of NameAddTransaction and
NameRemoveTransaction based on the change type specified in
received NameChangeRequests as designed.

Some classes were using references to isc::asiolink::IOService, others
where using d2::IOServicePtr.  The latter is now used throughout for
consistency as well as support for future, possible, multi-threaded
implementation.

Added virtual method for validating state handler map, added additional unit tests and commentary.

Interim commit for 3086 which includes the preliminary implementation
of the base class, NameChangeTransaction.  b10-dhcp-ddns module will use
derivations of this class to carry out NameChangeRequests.

D2UpdateMgr::checkFinishedTransaction was issuing an invalid read
when attempting to prefix increment an iterator used in an std::map erase
call.  This was flagged by valgrind and also core dumped under FreeBSD10.

Reverse IP address methods in D2UpdateMgr were declared static. Other
cosmetic changes.

Added initial implemenation of D2UpdateMgr class to src/bin/d2.