GitLab

Update manager now passes the D2 config manager reference into transactions
when it creates them. This makes D2 configuration services available at
the transaction level.

Changed NameChangeTransaction::sendUpdate() to get the timeout value from
configuration rather than use hard-coded constant.

Changed NameRemoveTransaction to test for NXRRSET not NXDOMAIN.  Since
the remove prequisites are RRSet tests, if the RRSets do no exist the
DNS server will return NXRRSET. NameRemoveTransaction now correctly
checks for this and treats it as success.

In addition to minor corrections, unit tests for NameChangeTransaction::
responseString was added.  Also added a similiar method NameChangeTransaction::
transactionOutcomeString() and unit tests.

Added descriptive message comment log statement for
to outbound DNS update requests, and conversion of status
and RCODEs for DNS inbound responses to b10-dhcp-ddns log.

Now that NameAddTransaction and NameRemoveTransction classes
have been implemented, D2UpdateMgr has been updated to use
them.  It now creates instances of NameAddTransaction and
NameRemoveTransaction based on the change type specified in
received NameChangeRequests as designed.

Changes are largely clean up and commentary.

Added methods for constructing all three types of DNS update requests
required by d2::NameRemoveTransaction to complete the implementation of its
state machine.  Also refactored some unit test code into nc_test_utils.h
and .cc. Renamed request verification functions in nc_test_utils to match
the build request function names.

Interrim check-in for 3088, which introduces the initial
implementation of d2:NameRemoveTransaction.  This class
implements the state model logic necessary for removing
DNS entries per RFC 4703.  The state model logic is
complete, what remains is the logic to build the actual
request messages.

Changed dhcp_ddns::NameChangeRequest to store lease address as
IOAddress only.  Corrected logic that handles request build
exceptions and added unit tests for same.  Other minor changes.

Added methods for constructing all three types of DNS update requests
required by d2::NameAddTransaction to complete the implementation of its
state machine.  Also refactored some unit test code into nc_test_utils.h
and .cc, and ran much needed spell checking.

Good deal of commentary clean up, rolled back IOService reference
changes to DNSClient, and most significantly added unit tests
for NameChangeTransaction::sendUpdate.  These tests involve an
actual message exchange.

Created unit tests for all of the states implemented by NameAddTransaction
in b10-dhcp-ddns.  The class lacks only proper construction of DNS update
requests.

This interrim checkin includes the initial implementation of
NameAddTransaction to b10-dhcp-ddns.  It provides the preliminary
state model needed to add forward and/or reverse DNS entries for
and FQDN.  It does not yet construct the actual DNS update requests.