GitLab

This change affects DHCP servers and D2.

Surrounded position info in error messages with parens.
Replaced use of vector with map for tracking position values.
General cleanup.

Modified DCfgContextBase::getParam() variants to return the parameter's
Element::Position.  This makes it available during parsing.

Modified TSIGKeyInfoParser::build to validate parameters and use position
in error messages.

Added element position argument to DCfgMgrBase::createConfigParser(),
so derivations have access to print position info unsupported top level
element errors.

Removed two log messages DCT_ORDER_ERROR and DCT_ORDER_NO_ELEMENT. These
conditions are well explained in exceptions thrown and these logs just
cluttered the log output.

Removed extra text from DCTL_CONFIG_LOAD_FAIL and DCTL_PARSER_FAIL log
messages. The log ID is self-explanatory and the underlying exceptions
provide ample explanation of the error.  Makes the log output much easier
to understand.

Revised items-not-in-parse-order detection in DCfgMgrBase::parseConfig().
Rather than complicated counting logic, objects are removed from the list
as they are parsed.  Any left over were not in the parsing-order.

Removed try-catch-throw from DCfgMgrBase::buildAndCommit. This method
already throws its own exception. Catching, logging, and re-throwing
exceptions from underneath it really just server to clutter the log.

Added missing commentary, corrected typos.

Restructured DCfgMgrBase to group the top level elements in a configuration
into scalars (strings, bools, ints, etc...) and objects (maps, lists, etc),
and parse the scalars first, then objects.  This permits the top level
scalars to be treated as a group of global parameters that are parsed first.

Ordered parsing is now relegated to only object elements. Scalars are parsed
first before any objects.

Also added the ability to reset config manager's context and rather than
than starting configuration parsing with a copy of the current context, it
starts with an empty context.

Modified unit tests accordingly.

information.

collection of classes for housing and parsing the application configuration
necessary for the DHCP-DDNS application. This rounds out the D2CfgMgr initial
implementation.

New files:
   src/bin/d2/d2_config.cc
   src/bin/d2/d2_config.h
   src/bin/d2/tests/d2_cfg_mgr_unittests.cc

D2. It introduces DCfgMgrBase, abstract class for processing updates
to configuration, DCfgContext for storing configuration; and D2
specific initial derivations of each, D2CfgMgr and D2CfgContext.
These are skeletal derivations that will be expanded to handle
DHCP-DDNS specific configuration. New files added:

  src/bin/d2/d_cfg_mgr.h
  src/bin/d2/d_cfg_mgr.cc
  src/bin/d2/d2_cfg_mgr.h
  src/bin/d2/d2_cfg_mgr.cc
  src/bin/d2/tests/d_cfg_mgr_unittests.cc