add comment
change from unused-parameter to unused-variable
remove additional change as was not needed.

discussed on jabber
and I tested directly with clang on Mac OS X (where problem
was seen).

cases (which currently fail due to other problem)

Change reviewed on Jabber.

Correct src/bin/resolver/main.cc which got changed in master after
this branch was started.

Conflicts:
	src/bin/resolver/tests/Makefile.am
	src/lib/config/tests/Makefile.am
	src/lib/log/tests/Makefile.am
	src/lib/resolve/tests/Makefile.am
	src/lib/server_common/tests/Makefile.am
	tests/tools/badpacket/tests/Makefile.am

For one, because we can, it's synchronous call, for second, ignoring
error is bad no matter what, for third, this makes us use default config
if it's bad, which is potentially even worse. Killing the app is safe.

The FreeBSD compiler complained that the member variable logger_
could not be constructed because the data type (log4cplus::Logger)
has no default constructor.  It is therefore initialized to point
to the log4cplus root logger (the one that is guaranteed to exist),
even though the LoggerImpl constructor may reset it immediately
afterwards.

and added a check for the right identifier

accidental remove like this.

[trac951] Revert "[trac951] we do have truncation support (at least in the api), so remove check and enable tests"

This reverts commit 76ae47d1.

We cannot yet remove the additional check and re-enable the corresponding
tests.  See my comment on ticket #951.

removed libnsas, added liblog

also added a note in updateKeyring() about why we need to catch the case
of list==NULL explicitly.

Also added a note to the addRemoteConfig() document that when it's called
for a module the module cc session must not have been "started".

This was noticed on the distcheck build.

constructor.  this fixes a regression report from cppcheck.