GitLab

I didn't test yet, but was missing and I see the
distcheck autobuilder had problem related to this.

- updateRTT now accepts 0 (and will change it internally to 1 as it needs a value >0 for division)
- improved check for negative values due to clock changes in the caller

Copyright on this BIND 10 work from CZ.NOC belonfs to ISC.

(reviewed on jabber)

This branch removed the shared pointer that the NSAS used to link
to the resolver.  As a result we now have to make sure that the
resolver stays in existence while the NSAS is active.  This commit
fixes that problem in a unit test.

If so, for now treat these as a timeout and resend if there are retries left, fail otherwise

.stop() followed directly by .reset() doesn't work. It seems asio has a
"can run" boolean variable, stop sets it to false, reset to true, so if
they are both called from inside the .run() main loop, it does nothing.

Reverted ZoneEntry to the original version and added the destructor
to TestResolver to call all the saved callbacks.  This breaks
internal shared_ptr loops, allowing the NSAS to destoy itself
gracefully, and avoiding memory leaks.

Previously when compiled without NDEBUG set it did, if a check
failed it called assert().  The tests checks for this using
ASSERT_DEATH.  However, ASSERT_DEATH leaks memory and this was
obscuring the valgrind output.  The changes here cause an exception
to be thrown (instead of a call to abort()) in the case of an error
and the unit tests now EXPECT_THROW instead of ASSERT_DEATH.

The ZoneEntry object was creating a callback and keeping a shared
pointer to it, but the callback was also using a shared pointer to
link back to the ZoneEntry.  This change removed the shared pointers
in the callback objects - they now use a "raw" pointer to point back
to the ZoneEntry.

- need stdlib.h for random()
- need return even after assert()
- cppcheck mentioned a few args that could be passed by reference

... to make it easier to comment out sets of tests for debugging.

Added an option to tcpSendReturnTest that makes it not send all data, resulting in a timeout

In the NSAS, store a pointer to the resolver as a "raw" pointer,
not a shared pointer.  The NSAS is part of the resolver, although
it can call back into the resolver.  If both store a shared pointer
to each other we can have the case where the reference counts can
never drop to zero.

(on the initial configuration)

also added a special case for the 'version' config element in the configuration checker (this caused the configuration to be rejected, while for the purposes of validation it should either be ignored or cause a different validation path)