minor bugfix in mdig: when using +multi, +norrcomments was ignored

See merge request !2208

Resolve "deadlock hangs named"

Closes #1148

See merge request !2236

so that cleanup can all be done in dns_client_destroy().

(cherry picked from commit e80c4c34)
(cherry picked from commit ebc48cda)

Mark Andrews authored Aug 06, 2019 and Ondřej Surý committed Aug 07, 2019

so that cleanup can all be done in dns_view_weakattach().

(cherry picked from commit be8af3af)
(cherry picked from commit e3946327)

There's a deadlock in BIND 9 code where (dns_view_t){ .lock } and
(dns_resolver_t){ .buckets[i].lock } gets locked in different order.  When
view->weakrefs gets converted to a reference counting we can reduce the locking
in dns_view_weakdetach only to cases where it's the last instance of the
dns_view_t object.

(cherry picked from commit a7c9a52c)
(cherry picked from commit 232140ed)

Update the flycheck configuration for gcc and cppcheck

See merge request !2234

Resolve "dig +nocomment still comments"

Closes #1170

See merge request !2207

Resolve "Use referral DS record when validating"

Closes #964

See merge request !1755

so that the validator can validate the records as part of validating
the current request.

Resolve "a race in ht.c can cause REQUIRE failures"

Closes #1175

See merge request !2225

Do not use target-specific variables in Makefiles and fix LD_WRAP for non-libtool builds

Closes #1174

See merge request !2224

Remove the autoconf checks for etags/ctags and `make tags` target

Closes #4

See merge request !2223

There's no strong reason to keep `make tags` in our build system.  The previous
functionality of `make tags` could be simply retained by aliasing variant of:

    etags $(git ls-files '*.c' '*.h')

which would be universal for all C-code projects.

Convert the configure.ac rules for zlib library to use pkg-config

Closes #4

See merge request !2222

Resolve "Bits 64..71 of the dns64 prefix are supposed to be zero"

Closes #1159

See merge request !2193

Cleanup the isc_thread API

See merge request !2159

Previously isc_thread_join() would return ISC_R_UNEXPECTED on a failure to
create new thread.  All such occurences were caught and wrapped into assert
function at higher level.  The function was simplified to assert directly in the
isc_thread_join() function and all caller level assertions were removed.

Previously isc_thread_create() would return ISC_R_UNEXPECTED on a failure to
create new thread.  All such occurences were caught and wrapped into assert
function at higher level.  The function was simplified to assert directly in the
isc_thread_create() function and all caller level assertions were removed.

Merge branch 'michal/wildcard-system-test-make-root-hints-consistent-with-authoritative-data' into 'master'

"wildcard" system test: make root hints consistent with authoritative data

See merge request isc-projects/bind9!2190

Multiple resolvers in the "wildcard" system test are configured with a
single root hint: "ns.root-servers.nil", pointing to 10.53.0.1, which is
inconsistent with authoritative data served by ns1.  This may cause
intermittent resolution failures, triggering false positives for the
"wildcard" system test.  Prevent this from happening by making ns2, ns3,
and ns5 use root hints corresponding to the contents of ns1/root.db.in.

The BIND 9 libraries are now internal-only, so remove isc-config.sh

Closes #1123

See merge request isc-projects/bind9!2115

The isc-config.sh script was introduced before pkg-config as is a purely
historical thing.  There are two reason for removal of isc-config.sh scripts:

a) The BIND 9 libraries are now meant to be used only from BIND 9, so there's no
   reason to provide convenience script to link with the libraries.

b) Even if that was not the case, we should and would replace the isc-config.sh
   with respective pkg-config (.pc) file for every library.

Resolve "Replace the isc_mem_put(mctx, ...)+isc_mem_detach(&mctx) usage with isc_mem_putanddetach(&mctx)"

Closes #1160

See merge request isc-projects/bind9!2195