1. 28 Feb, 2019 2 commits
  2. 27 Feb, 2019 3 commits
  3. 22 Feb, 2019 10 commits
    • Matthijs Mekking's avatar
      Merge branch '813-matthijs-failure-loading-rpz-v9_14' into 'v9_14' · 06d5da02
      Matthijs Mekking authored
      Resolve "Problems after failure of loading rpz [ISC-support #14002]"
      
      See merge request isc-projects/bind9!1562
      06d5da02
    • Matthijs Mekking's avatar
      Update CHANGES · 0f520ac0
      Matthijs Mekking authored
      0f520ac0
    • Matthijs Mekking's avatar
      Unregister RPZ CATZ db cbs when zone load fails · 05f156e8
      Matthijs Mekking authored
      In case when a zone fails to load because the file does not exist
      or is malformed, we should not run the callback that updates the
      zone database when the load is done.  This is achieved by
      unregistering the callbacks if at zone load end if the result
      indicates something else than success.
      05f156e8
    • Matthijs Mekking's avatar
      Update copyrights · ae159914
      Matthijs Mekking authored
      ae159914
    • Matthijs Mekking's avatar
      Add test for rpz zone load fail · d6cb3022
      Matthijs Mekking authored
      d6cb3022
    • Matthijs Mekking's avatar
      Remove rpz->db_registered · 6594f7ac
      Matthijs Mekking authored
      As pointed out in !813 db_registered is sort of redundant.  It is
      set to `true` only in `dns_zone_rpz_enable_db()` right before the
      `dns_rpz_dbupdate_callback()` callback is registered.  It is only
      required in that callback and it is the only place that the callback
      is registered.  Therefore there is no path that that `REQUIRE` can
      fail.
      
      The `db_registered` variable is only set to `false` in
      `dns_rpz_new_zone`, so it is not like the variable is unset again
      later.
      
      The only other place where `db_registered` is checked is in
      `rpz_detach()`.  If `true`, it will call
      `dns_db_updatenotify_unregister()`.  However if that happens, the
      `db_registered` is not set back to `false` thus this implies that
      this may happen multiple times.  If called a second time, most
      likely the unregister function will return `ISC_R_NOTFOUND`, but
      the return value is not checked anyway.  So it can do without the
      `db_registered` check.
      6594f7ac
    • Matthijs Mekking's avatar
      Add curly brackets on if statements · a4cd74e7
      Matthijs Mekking authored
      a4cd74e7
    • Matthijs Mekking's avatar
      named crashes on shutdown after load rpz failed · 48d7e4bb
      Matthijs Mekking authored
      This may happen when loading an RPZ failed and the code path skips
      calling dns_db_endload().  The dns_rpz_zone_t object is still kept
      marked as having registered db.  So when this object is finally
      destroyed in rpz_detach(), this code will incorrectly call
      `dns_db_updatenotify_unregister()`:
      
         if (rpz->db_registered)
           dns_db_updatenotify_unregister(rpz->db,
                                          dns_rpz_dbupdate_callback, rpz);
      
      and trigger this assertion failure:
      
         REQUIRE(db != NULL);
      
      To fix this, only call `dns_db_updatenotify_unregister()` when
      `rpz->db` is not NULL.
      48d7e4bb
    • Matthijs Mekking's avatar
      Make RPZ tests more readable · e2def297
      Matthijs Mekking authored
      e2def297
    • Matthijs Mekking's avatar
      Add README to RPZ tests · c01d6337
      Matthijs Mekking authored
      c01d6337
  4. 21 Feb, 2019 20 commits
  5. 20 Feb, 2019 3 commits
    • Evan Hunt's avatar
      Merge branch '428-remove-contrib-sdb' into 'master' · f4ade46f
      Evan Hunt authored
      remove contrib/sdb
      
      Closes #428
      
      See merge request isc-projects/bind9!1501
      f4ade46f
    • Evan Hunt's avatar
      CHANGES · bcc2fd67
      Evan Hunt authored
      bcc2fd67
    • Evan Hunt's avatar
      remove contrib/sdb · c79e2f12
      Evan Hunt authored
      removed the SDB databases in contrib/sdb as they hadn't been
      maintained in some time, and were no longer able to link to named
      without modification.  also:
      
      - cleaned up contrib/README, which still referred to contrib
        subdirectores that were removed already, and linked to an obsolete URL.
      - removed references to sdb in doc/misc/roadmap and doc/misc/sdb.
      c79e2f12
  6. 19 Feb, 2019 2 commits