1. 01 Jul, 2020 6 commits
    • Diego Fronza's avatar
      Added test for the fix · 042e5097
      Diego Fronza authored
      This test ensures that named will correctly shutdown
      when receiving multiple control connections after processing
      of either "rncd stop" or "kill -SIGTERM" commands.
      
      Before the fix, named was crashing due to a race condition happening
      between two threads, one running shutdown logic in named/server.c
      and other handling control logic in controlconf.c.
      
      This test tries to reproduce the above scenario by issuing multiple
      queries to a target named instance, issuing either rndc stop or kill
      -SIGTERM command to the same named instance, then starting multiple rndc
      status connections to ensure it is not crashing anymore.
      042e5097
    • Ondřej Surý's avatar
      Don't continue opening a new rndc connection if we are shutting down · be6cc53e
      Ondřej Surý authored
      Due to lack of synchronization, whenever named was being requested to
      stop using rndc, controlconf.c module could be trying to access an already
      released pointer through named_g_server->interfacemgr in a separate
      thread.
      
      The race could only be triggered if named was being shutdown and more
      rndc connections were ocurring at the same time.
      
      This fix correctly checks if the server is shutting down before opening
      a new rndc connection.
      be6cc53e
    • Evan Hunt's avatar
      Merge branch '1936-blackhole-fix' into 'main' · 402e1654
      Evan Hunt authored
      Resolve "blackhole ACL broken"
      
      Closes #1936
      
      See merge request isc-projects/bind9!3751
      402e1654
    • Evan Hunt's avatar
      CHANGES, release note · 08401e38
      Evan Hunt authored
      08401e38
    • Evan Hunt's avatar
      restore "blackhole" functionality · 23c7373d
      Evan Hunt authored
      the blackhole ACL was accidentally disabled with respect to client
      queries during the netmgr conversion.
      
      in order to make this work for TCP, it was necessary to add a return
      code to the accept callback functions passed to isc_nm_listentcp() and
      isc_nm_listentcpdns().
      23c7373d
    • Evan Hunt's avatar
      update the acl system test to include a blackhole test case · e3ee1380
      Evan Hunt authored
      this ACL was previously untested, which allowed a regression to
      go undetected.
      e3ee1380
  2. 30 Jun, 2020 7 commits
  3. 29 Jun, 2020 18 commits
  4. 26 Jun, 2020 9 commits