Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • BIND BIND
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 526
    • Issues 526
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 101
    • Merge requests 101
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • BINDBIND
  • Issues
  • #139

Closed
Open
Created Mar 09, 2018 by Ondřej Surý@ondrejOwner0 of 1 task completed0/1 task

Tests for IDNA2008 (libidn2)

The following discussion from !56 (closed) should be addressed:

  • @ondrej started a discussion:

    This mostly looks fine to me (after the nits being fixed), but the biggest issue before merging the code would be having tests for the code.

    Could you come up with couple of tests cases (IDNA2008 compliant, and also some tests that should "fail" because the encoding is broken, etc.) and either write the tests yourself (preferred :)), or just shove it to us and we'll take care of the tests. But they need to be present before the final merge.

Edited Mar 13, 2018 by Michał Kępień
Assignee
Assign to
Time tracking